Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Cannot find the declaration of element 'web-app' in version 3.0 files. (OFBIZ-6993)

I missed to backport changes web.xml (was OK in plugins)

  1. … 24 more files in changeset.
Improved: unify style application

(OFBIZ-11458)

remove unused property 'align-float'

  1. … 6 more files in changeset.
Improved: unify style application

(OFBIZ-11458)

remove unused property 'align-float'

  1. … 6 more files in changeset.
Improved: style alignment properties

(OFBIZ-11458)

Adding alignment properties (creating consistency across themes.

  1. … 6 more files in changeset.
Improved: style alignment properties

(OFBIZ-11458)

Adding alignment properties (creating consistency across themes.

  1. … 6 more files in changeset.
Reverted: "Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)"

This reverts commit 3075027df7c82bcb381810d9d438150ef696254f.

  1. … 24 more files in changeset.
Reverted: "Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)"

This reverts commit a93b1fcb7859a754ba84b810c4736e7ef6778689.

  1. … 24 more files in changeset.
Revert "Improved: Update “web.xml” files version 3.0 → 4.0 (OFBIZ-6993)"

This reverts commit 226e901981b68941bbcf3e1025d2208061d28db6.

  1. … 24 more files in changeset.
Reverted: "Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)"

This reverts commit d1c037dca1ea14caf545c85c3741bb9af093f3c9.

  1. … 24 more files in changeset.
Improved: Update “web.xml” files version 3.0 → 4.0 (OFBIZ-6993)

  1. … 24 more files in changeset.
Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)

these declarations avoid SAXParseException traceback when parsing web.xml

the first time in WebappUtil.parseWebXmlFile

  1. … 24 more files in changeset.
Fixed: Add XML declaration in “web.xml” files (OFBIZ-6993)

These declarations avoid SAXParseException traceback when parsing web.xml

the first time in WebappUtil.parseWebXmlFile

  1. … 24 more files in changeset.
Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)

these declarations avoid SAXParseException traceback when parsing web.xml

the first time in WebappUtil.parseWebXmlFile

  1. … 24 more files in changeset.
Fixed: Add XML declaration in “web.xml” files (OFBIZ-6993)

These declarations avoid SAXParseException traceback when parsing web.xml

the first time in WebappUtil.parseWebXmlFile

  1. … 24 more files in changeset.
Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)

these declarations avoid SAXParseException traceback when parsing web.xml

the first time in WebappUtil.parseWebXmlFile

  1. … 24 more files in changeset.
Applied fix from trunk for revision: 1863838 ===

Fixed: Check embedded Javascript libs vulnerabilities using retire.js

(OFBIZ-10678)

1. For solving CVE-2019-11358, upgraded jQuery to 3.4.1

2. Replaced library Fancybox with Featherlight. Added custom css so that cursor for links becomes pointer

Thanks Jacques Le Roux for the reviews

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1863853 13f79535-47bb-0310-9956-ffa450edef68

  1. … 45 more files in changeset.
Applied fix from trunk for revision: 1863838 ===

Fixed: Check embedded Javascript libs vulnerabilities using retire.js

(OFBIZ-10678)

1. For solving CVE-2019-11358, upgraded jQuery to 3.4.1

2. Replaced library Fancybox with Featherlight. Added custom css so that cursor for links becomes pointer

Thanks Jacques Le Roux for the reviews

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1863843 13f79535-47bb-0310-9956-ffa450edef68

  1. … 44 more files in changeset.
Fixed: Check embedded Javascript libs vulnerabilities using retire.js (OFBIZ-10678) 1. For solving CVE-2019-11358, upgraded jQuery to 3.4.1 2. Replaced library Fancybox with Featherlight. Added custom css so that cursor for links becomes pointer Thanks Jacques Le Roux for the reviews

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863838 13f79535-47bb-0310-9956-ffa450edef68

  1. … 44 more files in changeset.
"Applied fix from trunk for revision: 1860526 " ------------------------------------------------------------------------ r1860526 | jleroux | 2019-06-02 15:10:36 +0200 (dim. 02 juin 2019) | 11 lignes

Fixed: Unknown request [images]; this request does not exist or cannot be

called directly.

(OFBIZ-10895)

I was wrong doing massive changes w/o close control.

I decided to revert the r1859576 and r1859807 commits and to backport the revert

The only safe way to go is to not only check the error log for

"Unknown request [...."

but also to look for 404 in access log, not all request show erroneously in

error log/

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1860528 13f79535-47bb-0310-9956-ffa450edef68

  1. … 7 more files in changeset.
"Applied fix from trunk for revision: 1860526 " ------------------------------------------------------------------------ r1860526 | jleroux | 2019-06-02 15:10:36 +0200 (dim. 02 juin 2019) | 11 lignes

Fixed: Unknown request [images]; this request does not exist or cannot be

called directly.

(OFBIZ-10895)

I was wrong doing massive changes w/o close control.

I decided to revert the r1859576 and r1859807 commits and to backport the revert

The only safe way to go is to not only check the error log for

"Unknown request [...."

but also to look for 404 in access log, not all request show erroneously in

error log/

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1860527 13f79535-47bb-0310-9956-ffa450edef68

  1. … 13 more files in changeset.
Fixed: Unknown request [images]; this request does not exist or cannot be called directly. (OFBIZ-10895)

I was wrong doing massive changes w/o close control.

I decided to revert the r1859576 and r1859807 commits and to backport the revert

The only safe way to go is to not only check the error log for

"Unknown request [...."

but also to look for 404 in access log, not all request show erroneously in

error log/

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1860526 13f79535-47bb-0310-9956-ffa450edef68

  1. … 13 more files in changeset.
"Applied fix from trunk for revision: 1859807" Some handled by hand ------------------------------------------------------------------------ r1859807 | jleroux | 2019-05-23 18:41:59 +0200 (jeu. 23 mai 2019) | 5 lignes

Fixed: Unknown request [images]; this request does not exist or cannot be called

directly.

(OFBIZ-10895)

This should be the last commit, but I can't be sure. So I'll continue to

monitor the demos logs...

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1859810 13f79535-47bb-0310-9956-ffa450edef68

  1. … 11 more files in changeset.
"Applied fix from trunk for revision: 1859807" ------------------------------------------------------------------------ r1859807 | jleroux | 2019-05-23 18:41:59 +0200 (jeu. 23 mai 2019) | 5 lignes

Fixed: Unknown request [images]; this request does not exist or cannot be called

directly.

(OFBIZ-10895)

This should be the last commit, but I can't be sure. So I'll continue to

monitor the demos logs...

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1859808 13f79535-47bb-0310-9956-ffa450edef68

  1. … 11 more files in changeset.
Fixed: Unknown request [images]; this request does not exist or cannot be called directly. (OFBIZ-10895)

This should be the last commit, but I can't be sure. So I'll continue to

monitor the demos logs...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859807 13f79535-47bb-0310-9956-ffa450edef68

  1. … 11 more files in changeset.
"Applied fix from trunk for revision: 1859576" ------------------------------------------------------------------------ r1859576 | jleroux | 2019-05-20 20:02:09 +0200 (lun. 20 mai 2019) | 15 lignes

Fixed: Unknown request [images]; this request does not exist or cannot be

called directly.

(OFBIZ-10895)

This error happens in many occasions.

It shows only in log and have no effect on UI.

It happens in all supported releases.

So it's not very bad since it's has no side effects.

As said Deepak Dixit:

I think we need to fix the image url in css file, it should start with /images,

else browser append this in request info. There is nothing related to java or

tomcat code.

I finally decided to do a whole change, here it is

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1859578 13f79535-47bb-0310-9956-ffa450edef68

  1. … 7 more files in changeset.
"Applied fix from trunk for revision: 1859576" ------------------------------------------------------------------------ r1859576 | jleroux | 2019-05-20 20:02:09 +0200 (lun. 20 mai 2019) | 15 lignes

Fixed: Unknown request [images]; this request does not exist or cannot be

called directly.

(OFBIZ-10895)

This error happens in many occasions.

It shows only in log and have no effect on UI.

It happens in all supported releases.

So it's not very bad since it's has no side effects.

As said Deepak Dixit:

I think we need to fix the image url in css file, it should start with /images,

else browser append this in request info. There is nothing related to java or

tomcat code.

I finally decided to do a whole change, here it is

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1859577 13f79535-47bb-0310-9956-ffa450edef68

  1. … 7 more files in changeset.
Fixed: Unknown request [images]; this request does not exist or cannot be called directly. (OFBIZ-10895)

This error happens in many occasions.

It shows only in log and have no effect on UI.

It happens in all supported releases.

So it's not very bad since it's has no side effects.

As said Deepak Dixit:

I think we need to fix the image url in css file, it should start with /images,

else browser append this in request info. There is nothing related to java or

tomcat code.

I finally decided to do a whole change, here it is

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859576 13f79535-47bb-0310-9956-ffa450edef68

  1. … 7 more files in changeset.
Applied fix from trunk for revision: 1851433 ===

Improved: Replace Inline js with External js in renderFieldGroupOpen macro

(OFBIZ-9853)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1851437 13f79535-47bb-0310-9956-ffa450edef68

  1. … 5 more files in changeset.
Improved: Replace Inline js with External js in renderFieldGroupOpen macro (OFBIZ-9853)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1851433 13f79535-47bb-0310-9956-ffa450edef68

  1. … 5 more files in changeset.
Improved: Replace Asm select plugin with Select2. (OFBIZ-10113)

Current Asm Select Plugin

http://www.ryancramer.com/journal/entries/asmselect_v104/

can be replaced with Select2 (https://select2.org/).

* Select2 has much better community support on GitHub with 386 contributors

while Asm Select Plugin is handled by Ryan Cramer on http://www.ryancramer.com/.

* Select2 has 37 releases while Asm select has very few releases yet.

* Both the plugin has MIT license.

Refer https://select2.org/ and

https://github.com/select2/select2 for more features and other information.

Added i18n support so added logic in JsLanguageFileMappingCreator and

JsLanguageFilesMapping accordingly.

Added some custom CSS as the Select2 seems to be too fancy in accordance

with the current OFBiz themes

Verify:

Multiple drop-downs field in FormWidgetExamples.

https://localhost:8443/example/control/FormWidgetExamples

Find Request page with StatusId , CustRequestId

https://localhost:8443/ordermgr/control/FindRequest

I have replaced the plugins though I feel the implementation of select multiple

js code is to be reviewed & refactored. I will pick when I am done with all my

current tasks if I get some consensus.

Thanks: Aditya

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821001 13f79535-47bb-0310-9956-ffa450edef68

  1. … 76 more files in changeset.