Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: multi-block attribute for html-template tag (OFBIZ-11686)

Fixes JavaDoc issues

  1. … 1 more file in changeset.
Improved: multi-block attribute for html-template tag (OFBIZ-11686)

Improved documentation. No code change.

Improved: Move page-specific script links to html template (OFBIZ-11799)

Moved select2 script and link tags to html template when multi-block=true.

select2 language js will be auto added by MultiBlockHtmlTemplateUtil#addLinksToLayoutSettings

Tested on

https://localhost:8443/example/control/FormWidgetExamples

https://localhost:8443/ordermgr/control/FindRequest

  1. … 4 more files in changeset.
Improved: Corrected all redundant modifiers occurences in framework component. Also, fixed some other checkstyle line formatting and spacing issues. (OFBIZ-11925)

  1. … 50 more files in changeset.
Fixed: Server-Side Template Injection using Static (OFBIZ-11871)

Thanks to Alvaro's explanations, the problem was in MacroFormRenderer where, for

lookups, we retrieve _LAST_VIEW_NAME_ as a parameter without encoding it.

Got hard conflicts, all done by hand.

Thanks: Alvaro for advice

Fixed: Server-Side Template Injection using Static (OFBIZ-11871)

Thanks to Alvaro's explanations, the problem was in MacroFormRenderer where, for

lookups, we retrieve _LAST_VIEW_NAME_ as a parameter without encoding it.

I have added getEncodedParameter method in UtilHttp and removed now useless

(after OFBIZ-11907) getEnvironment from MacroFormRenderer.java

Thanks: Alvaro for advice

  1. … 1 more file in changeset.
Fixed: Server-Side Template Injection using Static (OFBIZ-11871)

Thanks to Alvaro's explanations, the problem was in MacroFormRenderer where, for

lookups, we retrieve _LAST_VIEW_NAME_ as a parameter without encoding it.

Thanks: Alvaro for advice

Conflicts handled by hand in UtilHttp.java

  1. … 1 more file in changeset.
Improved: Corrected some line is longer than 150 characters checkstyle issues in framework component. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)

  1. … 112 more files in changeset.
Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907) (#221)

* Improved: WidgetWorker should not write generated html to Appendable

(OFBIZ-11907)

Refactoring of WidgetWorker so that it generates URI and JSoup Element

objects to represent created URLs, hidden forms and anchor tags. This

replaces the previous approach where WidgetWorker would write string

representations of the URLS, hidden forms and anchor tags directly to an

Appendable object passed to it.

Callers to WidgetWorker have been modified to render the new objects

created by WidgetWorker to their relevant I/O.

* Improved: Handle spaces in link targets when building URIs

(OFBIZ-11907)

Corrected handling of spaces in target values passed to WidgetWorker

when bulding URIs. Spaces are URL encoded as %20.

    • -0
    • +68
    ./src/test/java/org/apache/ofbiz/widget/WidgetWorkerTest.java
Merge remote-tracking branch 'upstream/trunk' into OFBIZ-11907-widget-worker-refactor

Improved: Update build.gradle to the latest dependencies (OFBIZ-11603)

Fixes some new warnings coming from JUnit 4.13, a step ahead to JUnit 5.

I left 2 complicated ExpectedException warnings. Change will be needed for JUnit 5.

https://www.luxoft-training.com/news/migrating-from-junit-4-to-junit-5-replacing-rules-with-the-extension-model-part-1/

  1. … 10 more files in changeset.
Improved: Corrected all incorrect indentation level issues in framework component, also fixed some case indentation checkstyle issues. (OFBIZ-11922)

  1. … 60 more files in changeset.
Improved: Updated case indentation to 0 for all switch statements in framework component. Also done formatting changes as per checkstyle best practices. (OFBIZ-11904)

  1. … 62 more files in changeset.
Improved: WidgetWorker should not write generated html to Appendable

(OFBIZ-11907)

Refactoring of WidgetWorker so that it generates URI and JSoup Element

objects to represent created URLs, hidden forms and anchor tags. This

replaces the previous approach where WidgetWorker would write string

representations of the URLS, hidden forms and anchor tags directly to an

Appendable object passed to it.

Callers to WidgetWorker have been modified to render the new objects

created by WidgetWorker to their relevant I/O.

Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in framework component. (OFBIZ-11886)

  1. … 164 more files in changeset.
Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in framework component. (OFBIZ-11887)

  1. … 73 more files in changeset.
Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in framework component. (OFBIZ-11880) Thanks Jacques for review.

  1. … 85 more files in changeset.
Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for framework component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace. '{' is not followed by whitespace. '}' is not followed by whitespace. '}' is not preceded with whitespace. 'typecast' is not followed by whitespace. 'try' is not followed by whitespace. ';' is preceded with whitespace.

  1. … 146 more files in changeset.
Improved: Corrected all checkstyle issues related to succeeding space for comma in framework directory. (OFBIZ-11805) Thanks Jacques and Ritesh Kumar for review.

  1. … 28 more files in changeset.
Improved: Corrected typo in license header text in ModelActionVisitor.java, ModelConditionVisitor.java and ModelFieldVisitor.java. While working on some checkstyle issues, I found this typo.

Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805) Thanks Jacques Le Roux and Ritesh Kumar for review.

  1. … 29 more files in changeset.
Improved: Added new MacroFormRenderer unit tests (OFBIZ-11456) (#213)

Improved: Suppress deprecation warning on test method used to ensure behaviour is preserved until the deprecated method is removed. (OFBIZ-11456)

* Improved: Unit Tests for MacroFormRenderer

As part of refactoring MacroFormRender, unit tests have been created for

the main render methods to help ensure consistent behaviour is

maintained when MacroFormRender is changed.

More in-depth unit testing may be added when the more complex parts of

MacroFormRenderer are modified in the future.

Improved: makes ScreenFopViewHandler::render debug area also usable on Windows

Improved: Replace explicit type argument with diamond operator(OFBIZ-11828)

Since Java 1.7, when defining generic types it is unnecessary to redefine those types in the constructor when it is already done in the declared type.

  1. … 19 more files in changeset.
Improved: Replace anonymous types with lambda expressions(OFBIZ-11833)

  1. … 5 more files in changeset.
Fixed: Apply multi-block attr to each application (OFBIZ-11706)

Rendering screen within freemarker template not done correctly when multi-block=true

Thanks: Jacques for reporting

Fixed: showHelp not working (OFBIZ-11803)

Cater for page that uses layoutSettings.VT_STYLESHEET

instead of layoutSettings.styleSheets

Improved: Allow definition of external style sheet in multi-block html template (OFBIZ-11819)

External style sheet in html template will be extracted to layoutSettings.styleSheets when multi-block=true.

Improved: multi-block attribute for html-template tag (OFBIZ-11686)

Add CSRF token support for 'getJs' request uri.

Improved: Headerize external script in multi-block html template (OFBIZ-11741)

Fix regression in scrumtests that resulted in NullPointerException.