Clone Tools
  • last updated 14 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Corrected all redundant modifiers occurences in framework component. Also, fixed some other checkstyle line formatting and spacing issues. (OFBIZ-11925)

  1. … 58 more files in changeset.
Improved: Corrected some line is longer than 150 characters checkstyle issues in framework component. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)

  1. … 115 more files in changeset.
Improved: Corrected all incorrect indentation level issues in framework component, also fixed some case indentation checkstyle issues. (OFBIZ-11922)

  1. … 74 more files in changeset.
Improved: Updated case indentation to 0 for all switch statements in framework component. Also done formatting changes as per checkstyle best practices. (OFBIZ-11904)

  1. … 64 more files in changeset.
Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in framework component. (OFBIZ-11886)

  1. … 166 more files in changeset.
Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in framework component. (OFBIZ-11887)

  1. … 83 more files in changeset.
Documented: Framework, delete all docbook files related to migration to asciidoc (OFBIZ-11587)

Add a link to developer-manual for webtools in old help system

    • -0
    • +24
    ./data/HELP_WEBTOOLS.xml
  1. … 1 more file in changeset.
Improved: Added getter for componentName.(OFBIZ-11751)

Thanks, Sebastian Berg for report and patch and Aditya Sharma for the review.

Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in framework component. (OFBIZ-11880) Thanks Jacques for review.

  1. … 94 more files in changeset.
Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for framework component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace. '{' is not followed by whitespace. '}' is not followed by whitespace. '}' is not preceded with whitespace. 'typecast' is not followed by whitespace. 'try' is not followed by whitespace. ';' is preceded with whitespace.

  1. … 155 more files in changeset.
Improved: Corrected remaining ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805)

  1. … 12 more files in changeset.
Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805) Thanks Jacques Le Roux and Ritesh Kumar for review.

  1. … 34 more files in changeset.
Improved: Cannot find the declaration of element 'web-app' in version 3.0 files. (OFBIZ-6993)

I missed to backport changes web.xml (was OK in plugins)

  1. … 24 more files in changeset.
Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files (OFBIZ-11779)

Co-authored-by: Priya Sharma <priya.sharma@hotwaxsystems.com>

    • -1
    • +1
    ./groovyScripts/entity/EntityPerformanceTest.groovy
    • -1
    • +1
    ./groovyScripts/entity/ViewGeneric.groovy
  1. … 7 more files in changeset.
Improved: Replace explicit type argument with diamond operator(OFBIZ-11828)

Since Java 1.7, when defining generic types it is unnecessary to redefine those types in the constructor when it is already done in the declared type.

  1. … 19 more files in changeset.
Improved: Merge identical catch blocks in single catch block(OFBIZ-11827)

In Java SE 7 and later, a single catch block can handle more than one type of exception. This feature can reduce code duplication and lessen the temptation to catch an overly broad exception.

Thanks: Jacques for the review.

  1. … 47 more files in changeset.
Improved: Replace try-finally with try with resources(OFBIZ-11826)

Set checkstyleMain.maxErrors to 26678 (-4)

Thanks: Jacques for the review.

  1. … 3 more files in changeset.
Fixed: getEntityRefData service has a weird issue (OFBIZ-11401)

It's reproductible on trunk demo though only visible in log, UI shows no issue

R17 and R18 are also affected, R16 is OK.

Ankush: This stacktrace should be coming for all entities where

default-resource-name is defined on entity definition but no property exist in

defined resource for key EntityDescription.entityname and FieldDescription.field.

As we want to have these entity labels as much as possible, we can simply print

warning about the missing entity descriptions and field descriptions for

readability purpose instead of printing huge exceptions stacktrace.

Thanks: Ankush Upadhyay and Pierre Smits for the help

Handled by hand (swallowing exceptions is lazy and bad :p)

Fixed: getEntityRefData service has a weird issue (OFBIZ-11401)

MODULE does not exist in R18 (I did by hand in R17 so did not miss it...)

Fixed: getEntityRefData service has a weird issue (OFBIZ-11401)

It's reproductible on trunk demo though only visible in log, UI shows no issue

R17 and R18 are also affected, R16 is OK.

Ankush: This stacktrace should be coming for all entities where

default-resource-name is defined on entity definition but no property exist in

defined resource for key EntityDescription.entityname and FieldDescription.field.

As we want to have these entity labels as much as possible, we can simply print

warning about the missing entity descriptions and field descriptions for

readability purpose instead of printing huge exceptions stacktrace.

Thanks: Ankush Upadhyay and Pierre Smits for the help

Fixed: getEntityRefData service has a weird issue (OFBIZ-11401)

It's reproductible on trunk demo though only visible in log, UI shows no issue

R17 and R18 are also affected, R16 is OK.

Ankush: This stacktrace should be coming for all entities where

default-resource-name is defined on entity definition but no property exist in

defined resource for key EntityDescription.entityname and FieldDescription.field.

As we want to have these entity labels as much as possible, we can simply print

warning about the missing entity descriptions and field descriptions for

readability purpose instead of printing huge exceptions stacktrace.

Thanks: Ankush Upadhyay and Pierre Smits for the help

Conflicts handled by hand (swallowing exceptions is lazy and bad :p)

Improved: Change resources with proper naming convention in framework(OFBIZ-11834)

Also, modified checkstyleMain.maxErrors to 26735(-24)

Thanks: Jacques and Suraj for review.

  1. … 21 more files in changeset.
WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762) (#185)

* [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug

- Replaced the debug.log methods with the respective groovy utility method

- Enhanced the GroovyBaseScript to entertain the fetch the current class name as the module name for logging

- Overloaded the logError method to entertain throwbale object for better logging

- Removed unused import statements and module variables.

(OFBIZ-11762)

* [Removed]: Extra line spaces. (OFBIZ-11762)

* [Revert]: Unwanted changes. (OFBIZ-11762)

* [Added] Same changes to these files. (OFBIZ-11762)

Co-authored-by: Priya Sharma <priya.sharma@example.com>

    • -1
    • +1
    ./groovyScripts/entity/XmlDsDump.groovy
    • -1
    • +1
    ./groovyScripts/stats/StatBinsHistory.groovy
  1. … 32 more files in changeset.
Improved: Made MODULE as private data member of class instead of public in all framework components. (OFBIZ-11739) This will reduce checkstlye issues. Thanks Jacques for review.

  1. … 386 more files in changeset.
Fixed: Apache OFBiz unsafe deserialization of XMLRPC arguments (CVE-2020-9496)

(OFBIZ-11716)

Because the 2 xmlrpc related requets in webtools (xmlrpc and ping) are not using

authentication they are vulnerable to unsafe deserialization.

thanks: Alvaro Munoz <pwntester@github.com> from the GitHub Security Lab team

    • -1
    • +2
    ./webapp/webtools/WEB-INF/controller.xml
  1. … 2 more files in changeset.
Fixed: Apache OFBiz unsafe deserialization of XMLRPC arguments (CVE-2020-9496)

(OFBIZ-11716)

Because the 2 xmlrpc related requets in webtools (xmlrpc and ping) are not using

authentication they are vulnerable to unsafe deserialization.

thanks: Alvaro Munoz <pwntester@github.com> from the GitHub Security Lab team

    • -1
    • +2
    ./webapp/webtools/WEB-INF/controller.xml
  1. … 2 more files in changeset.
Fixed: Apache OFBiz unsafe deserialization of XMLRPC arguments (CVE-2020-9496)

(OFBIZ-11716)

Because the 2 xmlrpc related requets in webtools (xmlrpc and ping) are not using

authentication they are vulnerable to unsafe deserialization.

thanks: Alvaro Munoz <pwntester@github.com> from the GitHub Security Lab team

    • -1
    • +2
    ./webapp/webtools/WEB-INF/controller.xml
  1. … 2 more files in changeset.
Improved: Apply multi-block attr to each application (OFBIZ-11706)

For Webtools, Themes.

  1. … 2 more files in changeset.
reverted: CLONE - Use only HTTPS in OFBiz

(OFBIZ-11643)

Reverted, this needs more work

    • -0
    • +2
    ./webapp/webtools/WEB-INF/controller.xml
  1. … 2 more files in changeset.
Fixed: CLONE - Use only HTTPS in OFBiz

(OFBIZ-11643)

When doing OFBIZ-6849 I forgot to take care of the https attribute of the

security element used in controllers.

It's not used anymore since we used HTTPS everywhere but in request listed in

http.request-map.list property of url.properties. It's even enforced by HSTS for

requests that are not listed in this property.

This removes the https attribute and removes its usage in in controllers.

    • -2
    • +0
    ./webapp/webtools/WEB-INF/controller.xml
  1. … 2 more files in changeset.