Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Removed unused imports from Java files for fixing checkstyle errors (OFBIZ-11930)

Fixes few javadoc issues

Since this has been ignored for few commits I need to increase

tasks.checkstyleMain.maxErrors from 12224 to 12247 (did not check the detail)

  1. … 4 more files in changeset.
Improved: Removed unused imports from Java files for fixinf checkstyle errors

(OFBIZ-11930)

Thanks: Priya Sharma

  1. … 5 more files in changeset.
Improved: Corrected some line is longer than 150 characters checkstyle issues in framework component. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)

  1. … 105 more files in changeset.
Improved: Update build.gradle to the latest dependencies (OFBIZ-11603)

Fixes some new warnings coming from JUnit 4.13, a step ahead to JUnit 5.

I left 2 complicated ExpectedException warnings. Change will be needed for JUnit 5.

https://www.luxoft-training.com/news/migrating-from-junit-4-to-junit-5-replacing-rules-with-the-extension-model-part-1/

  1. … 10 more files in changeset.
Improved: Corrected all incorrect indentation level issues in framework component, also fixed some case indentation checkstyle issues. (OFBIZ-11922)

  1. … 69 more files in changeset.
Improved: Updated case indentation to 0 for all switch statements in framework component. Also done formatting changes as per checkstyle best practices. (OFBIZ-11904)

  1. … 65 more files in changeset.
Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in framework component. (OFBIZ-11886)

  1. … 152 more files in changeset.
Improved: Use Error.ftl everywhere it's not yet used (OFBIZ-11890)

We no longer have "/error/error.jsp" file,

so always use "common/webcommon/error/Error.ftl" by default

Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in framework component. (OFBIZ-11887)

  1. … 78 more files in changeset.
Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in framework component. (OFBIZ-11880) Thanks Jacques for review.

  1. … 85 more files in changeset.
Fixed: MODULE is not module :/ (backporting is never easy!)

Fixed: MODULE is not module :/ (backporting is never easy!)

Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for framework component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace. '{' is not followed by whitespace. '}' is not followed by whitespace. '}' is not preceded with whitespace. 'typecast' is not followed by whitespace. 'try' is not followed by whitespace. ';' is preceded with whitespace.

  1. … 146 more files in changeset.
Improved: better message for host-headers-allowed

Adds an explanation about what to do when using own domain.

Some users don't look into the log so it's better to set also the exception

message in order for them to have it right at 1st glance.

Improved: better message for host-headers-allowed

Adds an explanation about what to do when using own domain.

Some users don't look into the log so it's better to set also the exception

message in order for them to have it right at 1st glance.

Conflicts handled in webapp/control/RequestHandler.java

  1. … 1 more file in changeset.
Improved: better message for host-headers-allowed

Adds an explanation about what to do when using own domain.

Some users don't look into the log so it's better to set also the exception

message in order for them to have it right at 1st glance.

  1. … 1 more file in changeset.
Improved: Corrected all checkstyle issues related to succeeding space for comma in framework directory. (OFBIZ-11805) Thanks Jacques and Ritesh Kumar for review.

  1. … 31 more files in changeset.
Documented: POC for CSRF Token (CVE-2019-0235) (OFBIZ-11306)

Clarifies the behaviour of csrf-token

Thanks: James Yong

Improved: Corrected remaining ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805)

  1. … 12 more files in changeset.
Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805) Thanks Jacques Le Roux and Ritesh Kumar for review.

  1. … 29 more files in changeset.
Improved: Merge identical catch blocks in single catch block(OFBIZ-11827)

In Java SE 7 and later, a single catch block can handle more than one type of exception. This feature can reduce code duplication and lessen the temptation to catch an overly broad exception.

Thanks: Jacques for the review.

  1. … 50 more files in changeset.
Improved: Replace Map.get() with Map.getOrDefault() method.(OFBIZ-11832)

Set checkstyleMain.maxErrors to 26682 (-2)

  1. … 3 more files in changeset.
Improved: Install a Checkstyle pre-push (on every committer machine?) (OFBIZ-11304)

Updates tasks.checkstyleMain.maxErrors to 26842

Remove a trailing space in RequestHandler I used to test the pre-push hook.

In the previous commit (c4b5f5e) I have pushed a pre-push hook rather than a

pre-commit hook. I think it makes sense. I noticed that this does not clear the

existing pre-commit hook in .git\hooks. You have to clear it by hand.

But anyway I believe we should rather use a webhook as Suggested by Samuel and

proposed by Infra. This for at least 3 reasons:

Handles PRs and not only local commits

Minimise the CPU usage locally

Simplify usage for custom projects

I think it's the best solution but I'll continue the discussion on dev ML about

  1. … 1 more file in changeset.
Test locally <<hooks = ['pre-push': 'checkstyleMain']>>

  1. … 1 more file in changeset.
Improved: Enforce noninstantiability to LoginWorker class. (#175)

(OFBIZ-11747)

Made class as final, added private constructor and made static variables as private.

Improved: Enforce noninstantiability to ConfigXMLReader Class (#178)

(OFBIZ-11746)

Made class as final, added private constructor and corrected private data members as per naming convention.

Improved: Headerize external script in multi-block html template (OFBIZ-11741)

Cleanup script cache when session ended

  1. … 1 more file in changeset.
Improved: Headerize external script in multi-block html template (OFBIZ-11741)

Allow external scripts within the multi-block html template, to be rendered

within the html head tag, when a new attribute data-import is set to “head”

Thanks: Jacques for review

  1. … 19 more files in changeset.
Improved: Made MODULE as private data member of class instead of public in all framework components. (OFBIZ-11739) This will reduce checkstlye issues. Thanks Jacques for review.

  1. … 386 more files in changeset.
Improved: Clean how HTTP vs HTTPS is handled

(OFBIZ-11717)

No functional changes, just better comments