Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Removed unused imports from Java files for fixing checkstyle errors (OFBIZ-11930)

Fixes few javadoc issues

Since this has been ignored for few commits I need to increase

tasks.checkstyleMain.maxErrors from 12224 to 12247 (did not check the detail)

  1. … 4 more files in changeset.
Improved: Removed unused imports from Java files for fixinf checkstyle errors

(OFBIZ-11930)

Thanks: Priya Sharma

  1. … 4 more files in changeset.
Improved: Remove unused imports from Java files (OFBIZ-11930) (#222)

Improved: Remove unused imports from Java files

(OFBIZ-11930)

Thanks: Priya Sharma

  1. … 17 more files in changeset.
Improved: Corrected all redundant modifiers occurences in framework component. Also, fixed some other checkstyle line formatting and spacing issues. (OFBIZ-11925)

  1. … 54 more files in changeset.
Improved: Corrected some line is longer than 150 characters checkstyle issues in framework component. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)

  1. … 104 more files in changeset.
Improved: Corrected all incorrect indentation level issues in framework component, also fixed some case indentation checkstyle issues. (OFBIZ-11922)

  1. … 68 more files in changeset.
Improved: Updated case indentation to 0 for all switch statements in framework component. Also done formatting changes as per checkstyle best practices. (OFBIZ-11904)

  1. … 61 more files in changeset.
Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in framework component. (OFBIZ-11886)

  1. … 152 more files in changeset.
Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in framework component. (OFBIZ-11887)

  1. … 76 more files in changeset.
Implemented: New service definition attribute "verb" to denote the corresponding HTTP method (OFBIZ-11328) (#214)

* Added verb as an attribute to specify the REST method OFBiz service is going to serve on

* Added methods to get service IN and OUT parameters as MAP

* Added TODO for supporing nested parameters

* Improvement : Added Restrictions for verb attribute and documentation for the same

* Fixed checkstyle issues

* Changed attribute name from verb to action for better clarity

  1. … 1 more file in changeset.
Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in framework component. (OFBIZ-11880) Thanks Jacques for review.

  1. … 90 more files in changeset.
Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for framework component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace. '{' is not followed by whitespace. '}' is not followed by whitespace. '}' is not preceded with whitespace. 'typecast' is not followed by whitespace. 'try' is not followed by whitespace. ';' is preceded with whitespace.

  1. … 146 more files in changeset.
Improved: Corrected all checkstyle issues related to succeeding space for comma in framework directory. (OFBIZ-11805) Thanks Jacques and Ritesh Kumar for review.

  1. … 32 more files in changeset.
Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805) Thanks Jacques Le Roux and Ritesh Kumar for review.

  1. … 34 more files in changeset.
Improved: Replace Collection.sort() with List.sort().(OFBIZ-11830)

  1. … 12 more files in changeset.
Improved: Convert InvoicePerShipmentTests.xml tests to groovy (OFBIZ-11553) (#208)

* Improved: Convert InvoicePerShipmentTests.xml tests to groovy (OFBIZ-11553)

Done following:

- converted all xml test implementation to groovy

- used MockHttpServletRequest MockHttpServletResponse objects for triggering the events

- removed the xml version of the test implementations

- updated the test service mapping in the invoicetests.xml

(OFBIZ-11553)

* Improved: Moved the common code into a method so as to avoid duplication of code.

- passed in two parameters i.e. product id and the invoicePerShipment flag, to be used as per the need of the testcase.

(OFBIz-11553)

* Improved: Added support to get access to the Debug log methods in the groovy tests. (OFBIZ-11553)

- Also updated the references in the InvoicePerShipment tests.

Co-authored-by: Priya Sharma <priya.sharma@hotwaxsystems.com>

  1. … 3 more files in changeset.
Improved: Merge identical catch blocks in single catch block(OFBIZ-11827)

In Java SE 7 and later, a single catch block can handle more than one type of exception. This feature can reduce code duplication and lessen the temptation to catch an overly broad exception.

Thanks: Jacques for the review.

  1. … 48 more files in changeset.
Improved: Change resources with proper naming convention in framework(OFBIZ-11834)

Also, modified checkstyleMain.maxErrors to 26735(-24)

Thanks: Jacques and Suraj for review.

  1. … 17 more files in changeset.
[Improved]: Overloaded groovy utility method to handle error logging with only throwable object as parameter. (OFBIZ-11762) (#194)

Co-authored-by: Priya Sharma <priya.sharma@example.com>

WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762) (#185)

* [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug

- Replaced the debug.log methods with the respective groovy utility method

- Enhanced the GroovyBaseScript to entertain the fetch the current class name as the module name for logging

- Overloaded the logError method to entertain throwbale object for better logging

- Removed unused import statements and module variables.

(OFBIZ-11762)

* [Removed]: Extra line spaces. (OFBIZ-11762)

* [Revert]: Unwanted changes. (OFBIZ-11762)

* [Added] Same changes to these files. (OFBIZ-11762)

Co-authored-by: Priya Sharma <priya.sharma@example.com>

  1. … 35 more files in changeset.
Improved: Enforce noninstantiability to ServiceGroupReader Class. (#177)

(OFBIZ-11750)

Made class as final, added private constructor and corrected private data member name as per naming convention.

Improved: Enforce noninstantiability to JobUtil Class. (#176)

(OFBIZ-11749)

Made class as final and added private constructor.

Improved: Enforce noninstantiability to ExpressionUiHelper Class. (#173)

(OFBIZ-11748)

Made class as final, added private constructor and corrected private data member naming convention.

Fixed: startup-service does not work without runtime-data-id(OFBIZ-11668)

Fixed: startup-service does not work without runtime-data-id(OFBIZ-11668)

Fixed: startup-service does not work without runtime-data-id(OFBIZ-11668)

Fixed: Remove unnecessary semi-column

Improved: Made MODULE as private data member of class instead of public in all framework components. (OFBIZ-11739) This will reduce checkstlye issues. Thanks Jacques for review.

  1. … 386 more files in changeset.
Fixed: Apache OFBiz unsafe deserialization of XMLRPC arguments (CVE-2020-9496)

(OFBIZ-11716)

Because the 2 xmlrpc related requets in webtools (xmlrpc and ping) are not using

authentication they are vulnerable to unsafe deserialization.

thanks: Alvaro Munoz <pwntester@github.com> from the GitHub Security Lab team

  1. … 1 more file in changeset.
Fixed: Apache OFBiz unsafe deserialization of XMLRPC arguments (CVE-2020-9496)

(OFBIZ-11716)

Because the 2 xmlrpc related requets in webtools (xmlrpc and ping) are not using

authentication they are vulnerable to unsafe deserialization.

thanks: Alvaro Munoz <pwntester@github.com> from the GitHub Security Lab team

  1. … 1 more file in changeset.