Clone Tools
  • last updated 19 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed: Updates checkstyleMain.maxErrors to fits with Buildbot report

Never ever install Eclipse Checkstyle plugin. It does not use the same version

than Gradle, it's then a mess (Eclipse's is newer).

Fixes issues in CsrfUtilTests.java

Improved: follow checkstyle conventions in files committed for CSRF token defense

Mostly manually-automated, so some changes are not perfect. I have manually

changed back excessive ones

Comments out ArrayTypeStyle checkstyle

Updates checkstyleMain.maxErrors

  1. … 15 more files in changeset.
Revert "Merge branch 'JacquesLeRoux-POC-for-CSRF-Token-OFBIZ-11306' into trunk"

This reverts commit 27e57522b15d71352c61919befc6eb451ed4e864.

  1. … 27 more files in changeset.
Revert "Merge branch 'JacquesLeRoux-POC-for-CSRF-Token-OFBIZ-11306' into trunk"

This reverts commit 0add8bedbca231ffd839eb733f1041ce5487e9d6.

  1. … 37 more files in changeset.
Merge branch 'JacquesLeRoux-POC-for-CSRF-Token-OFBIZ-11306' into trunk Because of GitHub message on PR56: This branch cannot be rebased due to conflicts

Much Conflicts, but that should be OK

    • -0
    • +264
    ./security/CsrfUtilTests.java
  1. … 27 more files in changeset.
Merge branch 'JacquesLeRoux-POC-for-CSRF-Token-OFBIZ-11306' into trunk Because of GitHub message on PR56: This branch cannot be rebased due to conflicts

Conflicts handled by hand

RequestHandler.java

    • -0
    • +264
    ./security/CsrfUtilTests.java
  1. … 37 more files in changeset.
Improved: Implemented: Documented: Completed: Reverted: Fixed: Improved: no functional change (OFBIZ-) Explanation Thanks:

    • -0
    • +264
    ./security/CsrfUtilTests.java
  1. … 40 more files in changeset.
Creates new POC-for-CSRF-Token-OFBIZ-11306 branch

To share with James and others and later when OK to create a PR

    • -0
    • +264
    ./security/CsrfUtilTests.java
  1. … 40 more files in changeset.
Improved: Error in user impersonation with sub permission (OFBIZ-11342)

Improved javadoc

Set 'checkMultiLevelAdminPermissionValidity' visibility to default

Add another test verifying that hierarchy in permission is respected

Thanks Mathieu for your review

  1. … 1 more file in changeset.
Improved: Error in user impersonation with sub permission (OFBIZ-11342)

Improved javadoc

Set 'checkMultiLevelAdminPermissionValidity' visibility to default

Add another test verifying that hierarchy in permission is respected

Thanks Mathieu for your review

  1. … 1 more file in changeset.
Revert "Fixed: Error in user impersonation with sub permission (OFBIZ-11342)"

This reverts commit 73b7abbd

  1. … 1 more file in changeset.
Fixed: Error in user impersonation with sub permission (OFBIZ-11342)

Add unit tests for permission control feature.

Add new method to manage multilevel permission control.

This allowing an user with PARTYMGR_ADMIN permission to impersonate

another user with PARTYMGR_PCM_CREATE permission.

    • -0
    • +47
    ./security/SecurityUtilTest.java
  1. … 1 more file in changeset.
Fixed: Error in user impersonation with sub permission (OFBIZ-11342)

Add unit tests for permission control feature.

Add new method to manage multilevel permission control.

This allowing an user with PARTYMGR_ADMIN permission to impersonate

another user with PARTYMGR_PCM_CREATE permission.

    • -0
    • +47
    ./security/SecurityUtilTest.java
  1. … 1 more file in changeset.
Fixed: Error in user impersonation with sub permission (OFBIZ-11342)

Add unit tests for permission control feature.

Add new method to manage multilevel permission control.

This allowing an user with PARTYMGR_ADMIN permission to impersonate

another user with PARTYMGR_PCM_CREATE permission.

    • -0
    • +47
    ./security/SecurityUtilTest.java
  1. … 1 more file in changeset.