Clone Tools
  • last updated 28 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Corrected some line is longer than 150 characters checkstyle issues in framework component. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)

  1. … 118 more files in changeset.
Improved: Corrected all incorrect indentation level issues in framework component, also fixed some case indentation checkstyle issues. (OFBIZ-11922)

  1. … 71 more files in changeset.
Improved: Updated case indentation to 0 for all switch statements in framework component. Also done formatting changes as per checkstyle best practices. (OFBIZ-11904)

  1. … 64 more files in changeset.
Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for framework component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace. '{' is not followed by whitespace. '}' is not followed by whitespace. '}' is not preceded with whitespace. 'typecast' is not followed by whitespace. 'try' is not followed by whitespace. ';' is preceded with whitespace.

  1. … 160 more files in changeset.
Improved: Made MODULE as private data member of class instead of public in all framework components. (OFBIZ-11739) This will reduce checkstlye issues. Thanks Jacques for review.

  1. … 397 more files in changeset.
Documented: Framework, migration all docbook files to asciidoc (OFBIZ-11587)

- common-sending-email: include in email

- datafile: move as a include at the end of entity-engine section

- entity-engine: list of link to OFBiz wiki about entity configuration

- service-engine: a link to OFBiz wiki Service Engine Guide

- webtools: help for main screen

- mini-lang: include a link to OFBiz wiki mini-lang-reference at the

beginning of minilang-to-groovy-manual

move minilang-to-groovy-manual to Development environment

section

- unit-test: include as Junit test, and use README to list gradle

command available (so add a tag in REAME.adoc)

- base: add a link to OFBiz wiki Configuration Guide, in deployment

section

- SingleSignOn with LDAP: move to plugin LDAP and include in deployment

section

developer-manual is updated with some include lines or with directly a

sentence.

    • -0
    • +111
    ./src/docs/asciidoc/datafiles.adoc
  1. … 10 more files in changeset.
Improved: replaces module by MODULE everywhere

  1. … 681 more files in changeset.
Reverted: "Improved: Use ‘depends-on’ attribute instead of “component-load.xml”" (OFBIZ-11296)

This reverts commit eeabe69813a1d9f42911dec70a912574046ef49b.

  1. … 24 more files in changeset.
Improved: Use ‘depends-on’ attribute instead of “component-load.xml” (OFBIZ-11296)

We currently have two ways to define component loading order. Either

by using ‘depends-on’ attribute in “component-config.xml” or by adding

a “component-load.xml” file at the root of a component directory.

“depends-on” is more flexible because it handles partial ordering when

“component-load.xml” defines a total order which is not necessarily

meaningful, so it is better to rely only “depends-on”.

This removes the usage of “component-load.xml” to use ‘depends-on’

instead. The dependency declarations correspond to the total ordering

previously defined but will need to be refined in the future to relax

unnecessary dependency declarations.

Only “framework/base/config/component-load.xml” which defines the

top-level directories order (framework, applications, themes and

plugins) is kept.

  1. … 24 more files in changeset.
Fixed: Remove unneeded space after parenthesis

Improved: Add enconding type attribute for import data file tools (OFBIZ-10234) During the import of file via datafile import you may want to set encoding type. Actually only the type UTF-8 is supported. This commit allows to add a new "encoding-type" attribute into data-file to indicate the type of encoding of the imported file.

Thanks to Pierre Gaudin for this improvement.

Improved: Remove redundant "dtd" directory from classpath (OFBIZ-11161)

the "dtd" directories are already present as resources distributed

inside OFBiz jar, so there is no need to augment the classpath to find

the XML schema inside those directories.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1865796 13f79535-47bb-0310-9956-ffa450edef68

  1. … 10 more files in changeset.
Improved: Remove useless imports (OFBIZ-11142)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863507 13f79535-47bb-0310-9956-ffa450edef68

  1. … 16 more files in changeset.
Improved: Use ‘StandardCharsets.UTF_8’ (OFBIZ-11142)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863505 13f79535-47bb-0310-9956-ffa450edef68

  1. … 24 more files in changeset.
Improved: Add missing ‘static’ modifier for safe public methods (OFBIZ-11098)

In order to make it clear when a method is not depending on the

internal state of an object, it is a good practice to declare it as

static.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1860946 13f79535-47bb-0310-9956-ffa450edef68

  1. … 2 more files in changeset.
Improved: Add missing ‘static’ modifier for private methods (OFBIZ-11098)

In order to make it clear when a method is not depending on the

internal state of an object, it is a good practice to declare it as

static.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1860937 13f79535-47bb-0310-9956-ffa450edef68

  1. … 41 more files in changeset.
Improved: Remove redundant specification of type arguments (OFBIZ-10937)

Since Java 1.7, when defining generic types it is unnecessary to

redefine those types in the constructor when it is done in the

declared type.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1857906 13f79535-47bb-0310-9956-ffa450edef68

  1. … 239 more files in changeset.
Improved: Remove redundant null checks (OFBIZ-10911)

Redundant null checks detected by Eclipse has been removed.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1857896 13f79535-47bb-0310-9956-ffa450edef68

  1. … 29 more files in changeset.
Reverted: Changes done at r#1857089 and r#1857090 (OFBIZ-10911)(OFBIZ-10912)

The Cleanups introduced by those revisions has introduced some

unexpected regressions making the Gradle ‘loadAll’ task fail.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1857091 13f79535-47bb-0310-9956-ffa450edef68

  1. … 29 more files in changeset.
Improved: Remove redundant null checks (OFBIZ-10911)

Redundant null checks detected by Eclipse has been removed.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1857089 13f79535-47bb-0310-9956-ffa450edef68

  1. … 29 more files in changeset.
Improved: XML schemas should use predefined boolean type (OFBIZ-10411)

To define boolean values, some ad-hoc enumeration of "true" and "false" are

repeatedly used. Since XML Schema defines a standard boolean datatype it's

better to use it.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846727 13f79535-47bb-0310-9956-ffa450edef68

  1. … 16 more files in changeset.
Improved : Remove all unnecessary boxing and unboxing in Java classes (OFBIZ-10504)

Thanks Taher, Jacques, Mathieu and Rishi for the review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1837577 13f79535-47bb-0310-9956-ffa450edef68

  1. … 175 more files in changeset.
Improved: In CSV export file from data-file add a new attribute to select the EOL type (OFBIZ-9536)

During the file CSV generation by data-file engine, it is not possible to choose the end of line char. It is always "CR".

With this improvement it's now possible to define a eol-type attribute on data-file element with value CR or CRLF to use in the csv file result.

Example:

<data-file name="MyCsvTest" separator-style="delimited" type-code="text" delimiter=";" eol-type="CRLF">

<record name="Test">...

</data-file>

Thanks Pierre Gaudin for this proposal.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819151 13f79535-47bb-0310-9956-ffa450edef68

Improved: Import file with data-file, add start-line to escape the header column line (OFBIZ-10108)

When you load a CSV file some time with a data-file definition, if it contains some header column you can use the format attribute of you column.

Example:

ref;date

100;2017-10-10

200;2017-12-11

This definition failed :

<data-file name="MyCsvTest" separator-style="delimited" type-code="text" delimiter=";">

<record name="Test">

<field name="ref" type="String" position="1"/>

<field name="date" type="CustomTimestamp" format="yyyyy-MM-dd" position="2"/>

</record>

</data-file>

You need to read the date as string and after convert it on your code to escape the first line.

To solve it I added a new attribute start-line on data-file element :

<data-file name="MyCsvTest" separator-style="delimited" type-code="text" *start-line="1"* delimiter=";">

<record name="Test">

<field name="ref" type="String" position="1"/>

<field name="date" type="CustomTimestamp" format="yyyyy-MM-dd" position="2"/>

</record>

</data-file>

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819147 13f79535-47bb-0310-9956-ffa450edef68

Improved: General refactoring and code improvements, package org.apache.ofbiz.datafile. (OFBIZ-9963)

Thanks Dennis Balkir for reporting and providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818434 13f79535-47bb-0310-9956-ffa450edef68

    • -50
    • +65
    ./src/main/java/org/apache/ofbiz/datafile/Record.java
Improved: Always check if debug verbose is on when using Debug.logVerbose() (OFBIZ-10052)

This completes r1818010, there were much more cases.

Also few tabs automatically replaced by spaces

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818020 13f79535-47bb-0310-9956-ffa450edef68

  1. … 43 more files in changeset.
Improved: Always check if debug verbose is on when using Debug.logVerbose() (OFBIZ-10052)

We discussed on this point: http://markmail.org/message/mplvusuqn7oshl4v

and we agreed about better doing a check when using Debug.logVerbose().

I checked there are 300+ cases like that. Since it's an easy S/R

This implements it

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818005 13f79535-47bb-0310-9956-ffa450edef68

  1. … 95 more files in changeset.
Improved: Fixing defects reported by FindBugs, package org.apache.ofbiz.datafile. (OFBIZ-9715)

I modified the patch slightly and did some additional code cleanup by

removing commented out code and some formatting.

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1813637 13f79535-47bb-0310-9956-ffa450edef68

    • -374
    • +354
    ./src/main/java/org/apache/ofbiz/datafile/Record.java
Fixes "Remove warnings regarding missing component lib folders" - https://issues.apache.org/jira/browse/OFBIZ-7776 - by cleaning/clearing the references to non existent/empty dirs.

Notes:

* Also removes empty framework/base/lib/scripting and useless applications\content\lib\uno\README (miss doc in wiki)

* When jpim-0.1.jar will be (hopefully) replaced we can drop lib ref in framework/base/ofbiz-component.xml

* I wonder if we should let the geronimo component alone with only 2 classes, could we not put that in entity or entityext?

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1755306 13f79535-47bb-0310-9956-ffa450edef68

  1. … 45 more files in changeset.
(OFBIZ-6274) Renamed OFBiz artefacts from org.ofbiz.* to org.apache.ofbiz.*.Thanks to Taher for working on it.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1752920 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +241
    ./src/main/java/org/apache/ofbiz/datafile/DataFile.java
    • -0
    • +40
    ./src/main/java/org/apache/ofbiz/datafile/DataFileException.java
    • -0
    • +147
    ./src/main/java/org/apache/ofbiz/datafile/ModelDataFile.java
    • -0
    • +71
    ./src/main/java/org/apache/ofbiz/datafile/ModelField.java
    • -0
    • +115
    ./src/main/java/org/apache/ofbiz/datafile/ModelRecord.java
    • -0
    • +606
    ./src/main/java/org/apache/ofbiz/datafile/Record.java
    • -0
    • +264
    ./src/main/java/org/apache/ofbiz/datafile/RecordIterator.java
  1. … 3596 more files in changeset.