Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed: correct check style issue on ComponentContainerTest.java

No functionnal change

Fixed: Cannot run ComponentContainerTest on windows (OFBIZ-11331)

Running ComponentContainerTest on windows fails due to parsing of paths of the

form '/c:/dev/....'

org.apache.ofbiz.base.container.ComponentContainerTest >

testCheckDependencyForComponent FAILED

java.nio.file.InvalidPathException at ComponentContainerTest.java:44

Line 44:

private Path ofbizHome = Paths.get(ComponentContainerTest.class.getResource

("testsdata").getFile()).toAbsolutePath().normalize();

PR created: #8

Thanks: Daniel WatfordNina Simone - My Baby Just Cares For Me.mp3

Removed unused test imports.

Get Path from URI than a string representation of a file path when building Path to test resources.

Improved: Move ‘ComponentContainerTest’ data to src/test/resources/ (OFBIZ-11275)

Remove unnecessary webapp declaration inside the test component

configurations.

  1. … 4 more files in changeset.
Fixed: Remove dependency management from ‘ComponentContainer’ (OFBIZ-11275)

This fixes a bug identified by ‘testCheckDependencyForComponent’ where

the dependencies declared inside component configurations were not

impacting the component retrieval order.

Component configurations stored in the cache can now be properly

sorted based on their <depends-on> declaration. The new

‘ComponentConfig#sortDependencies’ method returns a collection of

component configuration following a topological ordering.

In case of dependency cycle we throw an error.

  1. … 4 more files in changeset.
Reverted: "Fixed: Remove dependency management from ‘ComponentContainer’" (OFBIZ-11275)

This reverts commit 3d3533cf5e04b303e5d7a4b0f178c54f10ddf620.

‘./gradlew cleanAll loadAll’ do not work anymore.

  1. … 4 more files in changeset.
Improved: Do not add classpath info to the classloader classpath (OFBIZ-11161)

Those directories are already added in the classpath by the build

system. The classpath info defined in “ofbiz-component.xml” files are

now only used to retrieve label files.

  1. … 2 more files in changeset.
Fixed: Remove dependency management from ‘ComponentContainer’ (OFBIZ-11275)

This fixes a bug identified by ‘testCheckDependencyForComponent’ where

the dependencies declared inside component configurations were not

impacting the component retrieval order.

Component configurations stored in the cache can now be properly

sorted based on their <depends-on> declaration. The new

‘ComponentConfig#sortDependencies’ method returns a collection of

component configuration following a topological ordering.

In case of dependency cycle we throw an error.

  1. … 3 more files in changeset.
Implemented: Show dependency resolution algorithm problem (OFBIZ-11275)

This adds a test demonstrating a bug in the dependency resolution

algorithm done in ‘ComponentContainer’.

When relying on <depends-on> declaration in “ofbiz-component.xml”

files we should expect to retrieve components (and their associated

containers) in a topological ordering meaning a linear ordering where

each component configuration element is placed after its dependencies

configuration elements. Currently this is not the case and the

dependency declarations only impact the construction of the dynamic

classpath.

    • -0
    • +84
    ./ComponentContainerTest.java
  1. … 3 more files in changeset.