Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Update build.gradle to the latest dependencies (OFBIZ-11603)

Fixes some new warnings coming from JUnit 4.13, a step ahead to JUnit 5.

I left 2 complicated ExpectedException warnings. Change will be needed for JUnit 5.

https://www.luxoft-training.com/news/migrating-from-junit-4-to-junit-5-replacing-rules-with-the-extension-model-part-1/

    • -1
    • +1
    ./ofbiz/base/util/UtilObjectTests.java
  1. … 7 more files in changeset.
Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for framework component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace. '{' is not followed by whitespace. '}' is not followed by whitespace. '}' is not preceded with whitespace. 'typecast' is not followed by whitespace. 'try' is not followed by whitespace. ';' is preceded with whitespace.

  1. … 160 more files in changeset.
Fixed: correct check style issue on ComponentContainerTest.java

No functionnal change

Fixed: Cannot run ComponentContainerTest on windows (OFBIZ-11331)

Running ComponentContainerTest on windows fails due to parsing of paths of the

form '/c:/dev/....'

org.apache.ofbiz.base.container.ComponentContainerTest >

testCheckDependencyForComponent FAILED

java.nio.file.InvalidPathException at ComponentContainerTest.java:44

Line 44:

private Path ofbizHome = Paths.get(ComponentContainerTest.class.getResource

("testsdata").getFile()).toAbsolutePath().normalize();

PR created: #8

Thanks: Daniel WatfordNina Simone - My Baby Just Cares For Me.mp3

Removed unused test imports.

Get Path from URI than a string representation of a file path when building Path to test resources.

Improved: Move ‘ComponentContainerTest’ data to src/test/resources/ (OFBIZ-11275)

Remove unnecessary webapp declaration inside the test component

configurations.

  1. … 4 more files in changeset.
Fixed: Remove dependency management from ‘ComponentContainer’ (OFBIZ-11275)

This fixes a bug identified by ‘testCheckDependencyForComponent’ where

the dependencies declared inside component configurations were not

impacting the component retrieval order.

Component configurations stored in the cache can now be properly

sorted based on their <depends-on> declaration. The new

‘ComponentConfig#sortDependencies’ method returns a collection of

component configuration following a topological ordering.

In case of dependency cycle we throw an error.

  1. … 4 more files in changeset.
Fixed: Possible NPE in StringUtil#strToMap (OFBIZ-11281)

StringUtil#strToMap(String, String, boolean, String) throws Nullpointer for StringUtil.strToMap("", false).

Thanks to Ulrich Heidfeld for this fix

    • -0
    • +1
    ./ofbiz/base/util/StringUtilTests.java
  1. … 1 more file in changeset.
Reverted: "Fixed: Remove dependency management from ‘ComponentContainer’" (OFBIZ-11275)

This reverts commit 3d3533cf5e04b303e5d7a4b0f178c54f10ddf620.

‘./gradlew cleanAll loadAll’ do not work anymore.

  1. … 4 more files in changeset.
Improved: Do not add classpath info to the classloader classpath (OFBIZ-11161)

Those directories are already added in the classpath by the build

system. The classpath info defined in “ofbiz-component.xml” files are

now only used to retrieve label files.

  1. … 2 more files in changeset.
Fixed: Fix linting issues (OFBIZ-11265)

  1. … 2 more files in changeset.
Fixed: Getting policy error while editing html text data using cms (OFBIZ-11265)

Service parameter with allow-html="safe" does not check the OWASP sanitizer flag

ie. enabled or not and perform sanitization which causing policy error while

editing text data

getting following exception error:

"In field [textData] by our input policy, your input has not been accepted for

security reason. Please check and modify accordingly, thanks."

Thanks: Pradeep Choudhary for report and suggestion

  1. … 3 more files in changeset.
Fixed: Getting policy error while editing html text data using cms (OFBIZ-11265)

Service parameter with allow-html="safe" does not check the OWASP sanitizer flag

ie. enabled or not and perform sanitization which causing policy error while

editing text data

getting following exception error:

"In field [textData] by our input policy, your input has not been accepted for

security reason. Please check and modify accordingly, thanks."

Thanks: Pradeep Choudhary for report and suggestion

(cherry picked from commit 8aea160e04c5d53bebd0371df044af5886f97c8e)

  1. … 3 more files in changeset.
Fixed: Getting policy error while editing html text data using cms (OFBIZ-11265)

Service parameter with allow-html="safe" does not check the OWASP sanitizer flag

ie. enabled or not and perform sanitization which causing policy error while

editing text data

getting following exception error:

"In field [textData] by our input policy, your input has not been accepted for

security reason. Please check and modify accordingly, thanks."

Thanks: Pradeep Choudhary for report and suggestion

(cherry picked from commit 8aea160e04c5d53bebd0371df044af5886f97c8e)

  1. … 3 more files in changeset.
Fixed: Remove dependency management from ‘ComponentContainer’ (OFBIZ-11275)

This fixes a bug identified by ‘testCheckDependencyForComponent’ where

the dependencies declared inside component configurations were not

impacting the component retrieval order.

Component configurations stored in the cache can now be properly

sorted based on their <depends-on> declaration. The new

‘ComponentConfig#sortDependencies’ method returns a collection of

component configuration following a topological ordering.

In case of dependency cycle we throw an error.

  1. … 3 more files in changeset.
Implemented: Add a generic directed graph utilitary class (OFBIZ-11275)

    • -0
    • +93
    ./ofbiz/base/util/DiGraphTest.java
  1. … 3 more files in changeset.
Improved: Lint unit tests

This makes no behavioral changes, only coding style fixes.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869037 13f79535-47bb-0310-9956-ffa450edef68

    • -7
    • +10
    ./ofbiz/base/conversion/DateTimeTests.java
    • -5
    • +3
    ./ofbiz/base/conversion/MiscTests.java
    • -3
    • +4
    ./ofbiz/base/lang/ComparableRangeTests.java
    • -27
    • +27
    ./ofbiz/base/util/AssertTests.java
    • -1
    • +0
    ./ofbiz/base/util/IndentingWriterTests.java
    • -61
    • +54
    ./ofbiz/base/util/ObjectTypeTests.java
    • -1
    • +0
    ./ofbiz/base/util/ReferenceCleanerTests.java
    • -4
    • +4
    ./ofbiz/base/util/StringUtilTests.java
    • -70
    • +91
    ./ofbiz/base/util/TimeDurationTests.java
    • -21
    • +30
    ./ofbiz/base/util/UtilCodecTests.java
    • -26
    • +33
    ./ofbiz/base/util/UtilIOTests.java
  1. … 12 more files in changeset.
Improved: Merge ‘UtilObjectUnitTest’ into ‘UtilObjectTests’ (OFBIZ-11067)

Those classes were testing the same class.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869023 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +51
    ./ofbiz/base/util/UtilObjectTests.java
    • -79
    • +0
    ./ofbiz/base/util/UtilObjectUnitTest.java
Improved: Turn ‘UtilObjectTests’ into a unit test class (OFBIZ-11067)

Adapt ‘UtilObjectUnitTest’ test class to avoid side effects when

testing allowed serialization classes.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869022 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +308
    ./ofbiz/base/util/UtilObjectTests.java
    • -0
    • +7
    ./ofbiz/base/util/UtilObjectUnitTest.java
  1. … 4 more files in changeset.
Fixed: Handle whitelist of serializable classes from properties (OFBIZ-11261)

There was a bug regarding the way the ‘ListOfSafeObjectsForInputStream’ value

defined in the “SafeObjectInputStream.properties” file was handled. Mistakenly

only one class identifier was allowed.

Some unit tests have been added to check that the identified bug is fixed.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869001 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +72
    ./ofbiz/base/util/UtilObjectUnitTest.java
  1. … 1 more file in changeset.
Implemented: Show dependency resolution algorithm problem (OFBIZ-11275)

This adds a test demonstrating a bug in the dependency resolution

algorithm done in ‘ComponentContainer’.

When relying on <depends-on> declaration in “ofbiz-component.xml”

files we should expect to retrieve components (and their associated

containers) in a topological ordering meaning a linear ordering where

each component configuration element is placed after its dependencies

configuration elements. Currently this is not the case and the

dependency declarations only impact the construction of the dynamic

classpath.

    • -0
    • +84
    ./ofbiz/base/container/ComponentContainerTest.java
  1. … 3 more files in changeset.
Fixed: Fix Default or Empty Catch block in Java and Groovy files (OFBIZ-8341)

In many Java and Groovy files we have auto generated catch blocks or empty catch

blocks.

To avoid such exception swallowing this should be improved to at least log the

error and also return error in case of service.

Last ones :)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1866958 13f79535-47bb-0310-9956-ffa450edef68

    • -12
    • +45
    ./ofbiz/base/util/AssertTests.java
  1. … 2 more files in changeset.
Improved: Use ‘StandardCharsets.UTF_8’ (OFBIZ-11142)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863505 13f79535-47bb-0310-9956-ffa450edef68

  1. … 26 more files in changeset.
Improved: Inline ‘UtilGenerics#toList’ (OFBIZ-11141)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863498 13f79535-47bb-0310-9956-ffa450edef68

  1. … 8 more files in changeset.
Improved: Inline ‘UtilGenerics#toMap’ (OFBIZ-11141)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863497 13f79535-47bb-0310-9956-ffa450edef68

  1. … 9 more files in changeset.
Improved: Make ‘UtilGenerics#checkCollection(Object, Class)’ more generic (OFBIZ-11141)

Remove ‘checkList’, ‘checkSet’ and ‘checkStack’ by using

‘checkCollection’ instead.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863489 13f79535-47bb-0310-9956-ffa450edef68

    • -4
    • +5
    ./ofbiz/base/util/UtilGenericsTest.java
  1. … 9 more files in changeset.
Implememented: Add unit tests for ‘UtilGenerics#checkCollectionCast’ (OFBIZ-11141)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863487 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +48
    ./ofbiz/base/util/UtilGenericsTest.java
Improved: Remove useless ‘UtilObject#equalsHelper’ (OFBIZ-11140)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863443 13f79535-47bb-0310-9956-ffa450edef68

    • -4
    • +5
    ./ofbiz/base/util/cache/UtilCacheTests.java
  1. … 10 more files in changeset.
Implemented: Add unit tests for ‘UtilHttp#makeParamListWithSuffix’ (OFBIZ-11138)

Adapt implementation to facilitate mocking.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863440 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +26
    ./ofbiz/base/util/UtilHttpTest.java
  1. … 1 more file in changeset.