Clone Tools
  • last updated 27 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Corrected some line is longer than 150 characters checkstyle issues in framework component. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)

  1. … 118 more files in changeset.
Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in framework component. (OFBIZ-11886)

  1. … 164 more files in changeset.
Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in framework component. (OFBIZ-11887)

  1. … 87 more files in changeset.
Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for framework component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace. '{' is not followed by whitespace. '}' is not followed by whitespace. '}' is not preceded with whitespace. 'typecast' is not followed by whitespace. 'try' is not followed by whitespace. ';' is preceded with whitespace.

  1. … 160 more files in changeset.
Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805) Thanks Jacques Le Roux and Ritesh Kumar for review.

  1. … 34 more files in changeset.
Improved: Replace single method call lambda with method reference(OFBIZ-11835)

Thanks: Jacques for the review.

  1. … 5 more files in changeset.
Improved: Made MODULE as private data member of class instead of public in all framework components. (OFBIZ-11739) This will reduce checkstlye issues. Thanks Jacques for review.

  1. … 398 more files in changeset.
Improved: replaces module by MODULE everywhere

  1. … 682 more files in changeset.
Improved: Remove unused ‘ComponentContainer#retrieveComponentConfig’ argument

No functional change.

Fixed: Remove dependency management from ‘ComponentContainer’ (OFBIZ-11275)

This fixes a bug identified by ‘testCheckDependencyForComponent’ where

the dependencies declared inside component configurations were not

impacting the component retrieval order.

Component configurations stored in the cache can now be properly

sorted based on their <depends-on> declaration. The new

‘ComponentConfig#sortDependencies’ method returns a collection of

component configuration following a topological ordering.

In case of dependency cycle we throw an error.

  1. … 4 more files in changeset.
Reverted: "Fixed: Remove dependency management from ‘ComponentContainer’" (OFBIZ-11275)

This reverts commit 3d3533cf5e04b303e5d7a4b0f178c54f10ddf620.

‘./gradlew cleanAll loadAll’ do not work anymore.

  1. … 4 more files in changeset.
Improved: Do not add classpath info to the classloader classpath (OFBIZ-11161)

Those directories are already added in the classpath by the build

system. The classpath info defined in “ofbiz-component.xml” files are

now only used to retrieve label files.

  1. … 1 more file in changeset.
Fixed: Remove dependency management from ‘ComponentContainer’ (OFBIZ-11275)

This fixes a bug identified by ‘testCheckDependencyForComponent’ where

the dependencies declared inside component configurations were not

impacting the component retrieval order.

Component configurations stored in the cache can now be properly

sorted based on their <depends-on> declaration. The new

‘ComponentConfig#sortDependencies’ method returns a collection of

component configuration following a topological ordering.

In case of dependency cycle we throw an error.

  1. … 3 more files in changeset.
Improved: Turn ‘DependsOnInfo’ into a String (OFBIZ-11264)

`depends-on` XML tag doesn't have any `loader` or `location` attribute so

DependsOnInfo does not need to extend ResourceInfo.

When removing the class derivation, DependsOnInfo now becomes a simple box

containing a String attribute. In order to make the manipulation of dependency

information simpler, the attribute is now inlined as a simple String value.

Thanks: Samuel Trégouët for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869185 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Improved: Rewrite ‘ComponentContainer#loadComponentsInDirectory’ (OFBIZ-11264)

Use a more declarative style with the stream API.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869183 13f79535-47bb-0310-9956-ffa450edef68

Improved: Delay the construction of component classpaths (OFBIZ-11264)

The list of component classpath elements was constructed iteratively

while loading components. This list was additionally used to check if

a component was actually loaded. This implementation was leading to

hard to understand code that has been replaced by a more appropriate

‘LinkedHashSet’ object.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869182 13f79535-47bb-0310-9956-ffa450edef68

Improved: Remove unnecessary ‘throws’ declarations (OFBIZ-11264)

Some declared and/or documented exceptions that were not actually

thrown.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869181 13f79535-47bb-0310-9956-ffa450edef68

Improved: Import ‘ComponentDef’ and ‘DependsOnInfo’ inner-classes (OFBIZ-11264)

This allows to use shorter name when using an variable or parameter of

those types.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1869180 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Use ‘ConcurrentHashMap’ to avoid ‘ConcurrentModificationException’ (OFBIZ-11258)

When trying to load components in their dependency order the

‘toBeLoadedComponents’ map is modified while being iterated over which

is not safe for non-concurrent maps.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1868666 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Use ‘ConcurrentHashMap’ to avoid ‘ConcurrentModificationException’ (OFBIZ-11258)

When trying to load components in their dependency order the

‘toBeLoadedComponents’ map is modified while being iterated over which

is not safe for non-concurrent maps.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868665 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Fix regression introduced in revision 1867409 (OFBIZ-11192)

‘null’ was an unspecified valid value for the second argument of the

‘ComponentContainer#retrieveComponentConfig’ method.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868657 13f79535-47bb-0310-9956-ffa450edef68

Implemented: Show dependency resolution algorithm problem (OFBIZ-11275)

This adds a test demonstrating a bug in the dependency resolution

algorithm done in ‘ComponentContainer’.

When relying on <depends-on> declaration in “ofbiz-component.xml”

files we should expect to retrieve components (and their associated

containers) in a topological ordering meaning a linear ordering where

each component configuration element is placed after its dependencies

configuration elements. Currently this is not the case and the

dependency declarations only impact the construction of the dynamic

classpath.

  1. … 3 more files in changeset.
Improved: Adapt ‘ContainerConfig#getConfigurations’ (OFBIZ-11256)

Remove unused declared ‘ContainerException’ in signature and fix the

javadoc to match the actual specification.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868630 13f79535-47bb-0310-9956-ffa450edef68

  1. … 2 more files in changeset.
Improved: Mark ‘ContainerConfig#configurations’ as final (OFBIZ-11256)

Use uppercase to match coding standards.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868629 13f79535-47bb-0310-9956-ffa450edef68

Improved: Avoid unecessary breakage in ‘ContainerConfig’ (OFBIZ-11256)

This restores ‘public’ modifiers on fields and move the ‘Property’

inner class back to ‘Configuration’ to avoid breakage of client code

extending the ‘Container’ interface.

In order to smooth the transition towards using getters instead of

direct field accesss, the public modifiers on fields are now marked as

deprecated.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868628 13f79535-47bb-0310-9956-ffa450edef68

  1. … 5 more files in changeset.
Improved: Add ‘PropertyChildren’ interface (OFBIZ-11256)

This allows removing some duplicated method overloads.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868626 13f79535-47bb-0310-9956-ffa450edef68

Improved: Refactor ‘ContainerConfig’ class (OFBIZ-11256)

This removes some code duplication, make things immutable and add some javadoc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868601 13f79535-47bb-0310-9956-ffa450edef68

  1. … 7 more files in changeset.
Improved: Refactor ‘ComponentConfig.ClasspathInfo’ (OFBIZ-11192)(OFBIZ-11238)

The validity checks have been moved at construction time instead of

relying on client code to ensure that the class path information are

sound.

A new ‘ComponentConfig.ClasspathInfo.Type’ enum has been defined to

improve type safety.

The location of the class path information is now using a

‘java.nio.file.Path’ class instance.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868030 13f79535-47bb-0310-9956-ffa450edef68

  1. … 2 more files in changeset.
Improved: Use ‘Path’ for component config ‘rootLocation’ attribute (OFBIZ-11192)

The method ‘ComponentConfig#getRootLocation’ has been removed

and replaced by ‘ComponentConfig#rootLocation’.

The callers have been adapted.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868028 13f79535-47bb-0310-9956-ffa450edef68

  1. … 8 more files in changeset.
Improved: Rewrite ‘Classpath’ class (OFBIZ-11237)

This class has been moved to ‘org.apache.ofbiz.base.container’ to be

able to reduce its visibility to the “package” level.

The API has been change to avoid unnecessary checks and simpler dataflow.

There was no need to provide thread safety so the ‘synchronized’

blocks have been removed.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868027 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.