Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Make shipment services loosely coupled with work-effort generation. (#132)

* Improved: Make shipment services loosely coupled with work-effort generation.

(OFBIZ-11678)

Removed workeffort generation related code in separate service, in createShipment and updateShipment service. In this effort, createShipment has been successfully changed to entity-auto as well.

Thanks: Pierre Smits and Arun Patidar for discussion and review.

  1. … 5 more files in changeset.
Improved: Make shipment services loosely coupled with work-effort generation. (#132)

* Improved: Make shipment services loosely coupled with work-effort generation.

(OFBIZ-11678)

Removed workeffort generation related code in separate service, in createShipment and updateShipment service. In this effort, createShipment has been successfully changed to entity-auto as well.

Thanks: Pierre Smits and Arun Patidar for discussion and review.

  1. … 5 more files in changeset.
Improved: Converted WorkEffort related services from simple to entity-auto. (#135)

(OFBIZ-11690)

  1. … 1 more file in changeset.
Applied fix from trunk for revision: 1859931 ===

Fixed: Error on deleting the survey associated with the task

(OFBIZ-7594)

The following error is generated on deleting the survey associated with the task.

Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: Problems getting the service model (Cannot locate service by name (deleteWorkEffortSurveyAppl))

On exploration I found, In the refactoring work done under OFBIZ-8408, the deleteWorkEffortSurveyAppl service was removed.

Added the deleteWorkEffortSurveyAppl service, previously it was in written in the simple engine, converted it to entity-auto.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1859935 13f79535-47bb-0310-9956-ffa450edef68

Applied fix from trunk for revision: 1859931 ===

Fixed: Error on deleting the survey associated with the task

(OFBIZ-7594)

The following error is generated on deleting the survey associated with the task.

Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: Problems getting the service model (Cannot locate service by name (deleteWorkEffortSurveyAppl))

On exploration I found, In the refactoring work done under OFBIZ-8408, the deleteWorkEffortSurveyAppl service was removed.

Added the deleteWorkEffortSurveyAppl service, previously it was in written in the simple engine, converted it to entity-auto.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1859933 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Error on deleting the survey associated with the task (OFBIZ-7594)

The following error is generated on deleting the survey associated with the task.

Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: Problems getting the service model (Cannot locate service by name (deleteWorkEffortSurveyAppl))

On exploration I found, In the refactoring work done under OFBIZ-8408, the deleteWorkEffortSurveyAppl service was removed.

Added the deleteWorkEffortSurveyAppl service, previously it was in written in the simple engine, converted it to entity-auto.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859931 13f79535-47bb-0310-9956-ffa450edef68

"Applied fix from trunk for revision: 1859877" ------------------------------------------------------------------------ r1859877 | jleroux | 2019-05-24 15:47:08 +0200 (ven. 24 mai 2019) | 10 lignes

Fixed: Services allow arbitrary HTML for parameters with allow-html set to "safe"

(OFBIZ-5254)

This was reopened after discussion at

https://markmail.org/message/jnaitmwahjcjmdn5

This is a new solution which follows the work done with OFBIZ-6669 and OFBIZ-10187

Roughly said, it uses org.owasp.html.PolicyFactory and org.owasp.html.Sanitizers

Thanks: Christoph Neuroth for report

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1859879 13f79535-47bb-0310-9956-ffa450edef68

  1. … 21 more files in changeset.
"Applied fix from trunk for revision: 1859877" ------------------------------------------------------------------------ r1859877 | jleroux | 2019-05-24 15:47:08 +0200 (ven. 24 mai 2019) | 10 lignes

Fixed: Services allow arbitrary HTML for parameters with allow-html set to "safe"

(OFBIZ-5254)

This was reopened after discussion at

https://markmail.org/message/jnaitmwahjcjmdn5

This is a new solution which follows the work done with OFBIZ-6669 and OFBIZ-10187

Roughly said, it uses org.owasp.html.PolicyFactory and org.owasp.html.Sanitizers

Thanks: Christoph Neuroth for report

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1859878 13f79535-47bb-0310-9956-ffa450edef68

  1. … 21 more files in changeset.
Fixed: Services allow arbitrary HTML for parameters with allow-html set to "safe" (OFBIZ-5254)

This was reopened after discussion at

https://markmail.org/message/jnaitmwahjcjmdn5

This is a new solution which follows the work done with OFBIZ-6669 and OFBIZ-10187

Roughly said, it uses org.owasp.html.PolicyFactory and org.owasp.html.Sanitizers

Thanks: Christoph Neuroth for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859877 13f79535-47bb-0310-9956-ffa450edef68

  1. … 21 more files in changeset.
Improved: Correected the sequence of service attribute tag to fix Invalid content was found warning

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1829699 13f79535-47bb-0310-9956-ffa450edef68

"Applied fix from trunk for revision: 1828255" ------------------------------------------------------------------------ r1828255 | jleroux | 2018-04-03 18:37:09 +0200 (mar., 03 avr. 2018) | 7 lines

Fixed: Required parameters are optional for createWorkRequirementFulfillment service

(OFBIZ-8622)

As per entity def, required parameter should be requirementId instead of

requirementTypeId.

Thanks: Suraj for the last patch

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1828306 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Fixed: Required parameters are optional for createWorkRequirementFulfillment service (OFBIZ-8622)

As per entity def, required parameter should be requirementId instead of

requirementTypeId.

Thanks: Suraj for the last patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1828255 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Fixed: Removed mode=INOUT from override attribute of service definetion that was added mistakenly in previous patch. (OFBIZ-7738) Thanks Dennis Balkir for reporting issue and Dhaval Wagela for providing patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825537 13f79535-47bb-0310-9956-ffa450edef68

Applied fix from trunk for revision: 1825450 ===

Fixed: Error in service definition for deleteOrderHeaderWorkEffort

(OFBIZ-10243)

Thanks Pierre Gaudin for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1825451 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Error in service definition for deleteOrderHeaderWorkEffort (OFBIZ-10243)

Thanks Pierre Gaudin for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825450 13f79535-47bb-0310-9956-ffa450edef68

Improved: all the service level error messages for missing required field for workeffort component (OFBIZ-7738) Thanks Ratnesh Upadhyay and Dhaval Wagela for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825209 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Improved: Create missing services definitions in WorkEffortSimpleServices.xml (OFBIZ-9708)

In WorkEffortSimpleServices.xml the service implementations from

updateWorkEffortContactMech to updateWorkEffortEmailAddress are missing service

definitions.

This was discussed at http://markmail.org/message/kgbpolz2daxfa5zx.

Thanks to Pawan Verma for reporting and patching, everyone for the discussion

and Scott for the detailed argumentation which makes totally sense.

jleroux:I wanted to provide proper tests, but this has already stayed too long

in my working copy

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821114 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Reverts from r1821001 (for OFBIZ-10113) I thought about keeping it but it's better to commit it apart

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821032 13f79535-47bb-0310-9956-ffa450edef68

Improved: Replace Asm select plugin with Select2. (OFBIZ-10113)

Current Asm Select Plugin

http://www.ryancramer.com/journal/entries/asmselect_v104/

can be replaced with Select2 (https://select2.org/).

* Select2 has much better community support on GitHub with 386 contributors

while Asm Select Plugin is handled by Ryan Cramer on http://www.ryancramer.com/.

* Select2 has 37 releases while Asm select has very few releases yet.

* Both the plugin has MIT license.

Refer https://select2.org/ and

https://github.com/select2/select2 for more features and other information.

Added i18n support so added logic in JsLanguageFileMappingCreator and

JsLanguageFilesMapping accordingly.

Added some custom CSS as the Select2 seems to be too fancy in accordance

with the current OFBiz themes

Verify:

Multiple drop-downs field in FormWidgetExamples.

https://localhost:8443/example/control/FormWidgetExamples

Find Request page with StatusId , CustRequestId

https://localhost:8443/ordermgr/control/FindRequest

I have replaced the plugins though I feel the implementation of select multiple

js code is to be reviewed & refactored. I will pick when I am done with all my

current tasks if I get some consensus.

Thanks: Aditya

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821001 13f79535-47bb-0310-9956-ffa450edef68

  1. … 76 more files in changeset.
Fixed: Corrected engine name for updateWorkEffortFixedAssetStd service, Thanks Suraj Khurana for reporting.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818101 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Error displayed while adding WorkEffort Contact Mechs.(OFBIZ-9316) Applied slightly modified patch. Thanks Jagpreet for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801349 13f79535-47bb-0310-9956-ffa450edef68

  1. … 3 more files in changeset.
Fixed: Remove duplicate service entry for deleteWorkEffortInventoryProduced.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1782662 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Fixed console warning introduced in revision#1768253 (OFBIZ-8358)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768288 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Set required parameter as option false at service definition level. (OFBIZ-8358)

Thanks Avnindra Sharma and Pawan Verma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768253 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Fixed: Incorrect required parameters set on following services, mark required parameters as option false as service in parameter. - createWorkEffortKeywords - createWorkEffortQuote - createWorkEffortRequest - createWorkEffortRequestItem - createWorkEffortRequestItemAndRequestItem - createWorkEffortReview - createWorkRequirementFulfillment (OFBIZ-8602)(OFBIZ-8603)(OFBIZ-8604)(OFBIZ-8605)(OFBIZ-8620)(OFBIZ-8621)(OFBIZ-8622)

Thanks Pawan Verma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768252 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Fixed: Update Services that sets non-pk fields to null if not passed, if non-pks not passed than it should remain unupaded.

(OFBIZ-8722)

Thanks Pawan Verma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768239 13f79535-47bb-0310-9956-ffa450edef68

  1. … 50 more files in changeset.
Improved: Added generic permission service for following - facility - marketting - return - entitysync Also moved the permission check from implementation level to service defination level

(OFBIZ-8673)(OFBIZ-8673)(OFBIZ-8674)(OFBIZ-8739)(OFBIZ-8823)(OFBIZ-8825)(OFBIZ-8827)(OFBIZ-8850)(OFBIZ-8876)(OFBIZ-8875)(OFBIZ-8824)(OFBIZ-8826)(OFBIZ-8851)

Thanks Nameet Jain for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768188 13f79535-47bb-0310-9956-ffa450edef68

  1. … 32 more files in changeset.
Improved: Convert WorkEffortContent entity CRUD service to entity-auto (OFBIZ-8666)

Adds a DELETE permission to deleteWorkEffortContent service implementation to be

consistent with create and update.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767792 13f79535-47bb-0310-9956-ffa450edef68

Improved: Converted following WorkEffort related services to entity-auto - CustRequestItemWorkEffort - CustRequestWorkEffort - OrderHeaderWorkEffort - WorkEffortContactMech - QuoteWorkEffort - ShoppingListWorkEffort - WorkEffortContent - WorkEffortGoodStandard - WorkRequirementFulfillment (OFBIZ-8658)(OFBIZ-8659)(OFBIZ-8660)(OFBIZ-8661)(OFBIZ-8663)(OFBIZ-8665)(OFBIZ-8666)(OFBIZ-8667)(OFBIZ-8668)

Thanks Pawan Verma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767549 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Fixed: Console Warning : No parameter found for override parameter named (OFBIZ-7814)

Thanks Nameet Jain for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1766860 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.