Clone Tools
  • last updated 28 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed: error log of a fresh trunk installation (OFBIZ-11953)

Typo: missing quotes

Thanks: Alex Bodnaru for report

Improved: small typo in trunk (OFBIZ-11952)

I also replaced tabs by spaces in applications/product/servicedef/services.xml

Thanks: Alex Bodnaru

  1. … 1 more file in changeset.
Improved: Remove unused imports from Java files (OFBIZ-11930) (#222)

Improved: Remove unused imports from Java files

(OFBIZ-11930)

Thanks: Priya Sharma

  1. … 15 more files in changeset.
Improved: Corrected all redundant modifiers occurences in framework component. Also, fixed some other checkstyle line formatting and spacing issues. (OFBIZ-11925)

  1. … 59 more files in changeset.
Improved: Corrected all redundant modifiers occurences from applications component. Also, fixed some other checkstyle line formatting and spacing issues. (OFBIZ-11925)

  1. … 6 more files in changeset.
Improved: Convert ProductTest.xml to Groovy (OFBIZ-11852)

    • -331
    • +0
    ./minilang/product/test/ProductTest.xml
    • -0
    • +363
    ./src/main/groovy/org/apache/ofbiz/product/ProductTest.groovy
Improved: Status ID checkbox for FindWorkEffort, FindProductionRun and FindShipment forms (OFBIZ-11939)

  1. … 4 more files in changeset.
Improved: Corrected some line is longer than 150 characters checkstyle issues in applications component. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)

  1. … 77 more files in changeset.
Improved: Inconsistent String Comparisons(OFBIZ-9254)

There are some inconsistencies in the code for string comparison statusId.equals(PRUN_COMPLETED) whereas it should be written as PRUN_COMPLETED.equals(statusId) cause the former can throw NullPointerException if the variable found to be NULL.

Thanks: Devanshu for your contribution.

  1. … 4 more files in changeset.
Improved: Convert ProductTagTest.xml to Groovy (OFBIZ-11857)

This can be tested using

./gradlew "ofbiz --test component=product --test suitename=producttagtests"

Thanks: Akash Jain for report, Anushi Gupta for the patch

    • -165
    • +0
    ./minilang/product/test/ProductTagTest.xml
    • -0
    • +120
    ./src/main/groovy/org/apache/ofbiz/product/ProductTagTest.groovy
Improved: Corrected all incorrect indentation level issues in application component, also fixed some case indentation checkstyle issues. (OFBIZ-11922)

  1. … 83 more files in changeset.
In previous commit 2b041186909982f37b6a32688fe910d65b6d0fad for

Revert "Improved: Convert voidPayment service from mini-lang to groovy DSL (OFBIZ-11487)"

This reverts commit faa59b325fc50fc58b578c2b5d9b6d50d21b2478.

I wrongly put back 2 files not part of faa59b325 commit

CostTests.xml

ProductPriceTests.xml

This removes them

    • -90
    • +0
    ./minilang/product/test/CostTests.xml
    • -66
    • +0
    ./minilang/product/test/ProductPriceTests.xml
Revert "Improved: Convert voidPayment service from mini-lang to groovy DSL (OFBIZ-11487)"

This reverts commit faa59b325fc50fc58b578c2b5d9b6d50d21b2478.

It introduced 3 errors in testIntegration, in:

testGlPostingOnCancelCheckRun

testGlPostingsOnVoidPayment

testVoidPayment

    • -0
    • +90
    ./minilang/product/test/CostTests.xml
    • -0
    • +66
    ./minilang/product/test/ProductPriceTests.xml
  1. … 3 more files in changeset.
Improved: Convert CostTests.xml to Groovy(OFBIZ-11859)

Thanks, Akash for report and Anushi for the Patch.

    • -90
    • +0
    ./minilang/product/test/CostTests.xml
    • -0
    • +73
    ./src/main/groovy/org/apache/ofbiz/product/CostTests.groovy
Improved: Updated case indentation to 0 for all switch statements in applications component. Also done formatting changes as per checkstyle best practices. (OFBIZ-11904)

  1. … 46 more files in changeset.
Fixed: Error in Quick Receive Purchase Order process. (OFBIZ-11911) (#219)

Corrected typo

Fixed: Converted GString to String while setting success message in receiveInventoryProduct service to avoid the ClassCastException. Also corrected loop condition while creating inventory information during PO receiving to fix the issue where each product is getting received two times (doubled the qty) instead of single time.(OFBIZ-11909) (#218)

    • -2
    • +2
    ./groovyScripts/shipment/ShipmentReceiptServices.groovy
Improved: Convert ProductPriceTests.xml to Groovy(OFBIZ-11856)

Thanks, Akash for report and Anushi for patch.

    • -66
    • +0
    ./minilang/product/test/ProductPriceTests.xml
Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-framework into trunk

Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in applications component. (OFBIZ-11886)

  1. … 56 more files in changeset.
Improved: Use Error.ftl everywhere it's not yet used (OFBIZ-11890)

Removes all error*.jsp reference, no longer used

    • -27
    • +0
    ./webapp/facility/error/error403.jsp
    • -27
    • +0
    ./webapp/facility/error/error404.jsp
  1. … 20 more files in changeset.
Improved: fixes an API typo

Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in applications component. (OFBIZ-11887)

  1. … 96 more files in changeset.
Implemented: New service definition attribute "verb" to denote the corresponding HTTP method (OFBIZ-11328) (#214)

* Added verb as an attribute to specify the REST method OFBiz service is going to serve on

* Added methods to get service IN and OUT parameters as MAP

* Added TODO for supporing nested parameters

* Improvement : Added Restrictions for verb attribute and documentation for the same

* Fixed checkstyle issues

* Changed attribute name from verb to action for better clarity

  1. … 3 more files in changeset.
Documented: migrate help link to asciidoc user manual for Product (OFBIZ-11587)

All files have been migrated to asciidoc format and help link now point

to the html file generated from the asciidoc files

In the global Help Docbook index tree, remove all points about

Product & Facility and add a short page with a link to the new help

Remove docbook help files for Product & Facility

    • -0
    • +30
    ./data/HELP_PRODUCT.xml
    • -211
    • +0
    ./data/helpdata/HELP_IMAGEMANAGEMENT.xml
    • -66
    • +0
    ./data/helpdata/HELP_PRODCATALOG_main.xml
    • -93
    • +0
    ./data/helpdata/HELP_PRODUCT_Features.xml
    • -129
    • +0
    ./data/helpdata/HELP_PRODUCT_Product_Stores.xml
    • -111
    • +0
    ./data/helpdata/HELP_PRODUCT_WorkingwithCatalogs.xml
Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in applications component. (OFBIZ-11880) Thanks Jacques for review.

  1. … 93 more files in changeset.
Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for applications component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace. '{' is not followed by whitespace. '}' is not followed by whitespace. '}' is not preceded with whitespace. 'typecast' is not followed by whitespace. 'try' is not followed by whitespace. ';' is preceded with whitespace.

  1. … 91 more files in changeset.
Print pick sheet has distorted currency symbol(OFBIZ-11781)

    • -0
    • +1
    ./template/facility/PrintPickSheets.fo.ftl
Improved: Corrected all checkstyle issues related to succeeding space for comma in applications directory. (OFBIZ-11805) Thanks Jacques and Ritesh Kumar for review.

  1. … 42 more files in changeset.
Improved: Convert InventoryTests.xml to Groovy (OFBIZ-11851)

    • -53
    • +0
    ./minilang/product/test/InventoryTests.xml
    • -0
    • +53
    ./src/main/groovy/org/apache/ofbiz/product/InventoryTests.groovy