Clone Tools
  • last updated 16 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Changed resources with proper naming convention in all application components. (OFBIZ-11739) Also, made MODULE as private data member of class instead of public. This will reduce checkstlye issues. Thanks Jacques for review.

    • -40
    • +40
    ./party/contact/ContactMechServices.java
    • -1
    • +1
    ./party/contact/ContactMechWorker.java
    • -1
    • +1
    ./party/content/PartyContentWrapper.java
    • -1
    • +1
    ./party/party/PartyRelationshipHelper.java
    • -8
    • +8
    ./party/party/PartyRelationshipServices.java
    • -66
    • +66
    ./party/party/PartyServices.java
  1. … 211 more files in changeset.
Removed: Unnecessay code added to fix the middle name issue on List party screen (OFBIZ-11681)

Fixed: ListParty doesn't show middleName

(OFBIZ-11681)

Fixes a logic error

Fixed: ListParty doesn't show middleName

(OFBIZ-11681)

Fixes a logic error

Fixed: ListParty doesn't show middleName

(OFBIZ-11681)

Fixes a logic error

Fixed: ListParty doesn't show middleName

(OFBIZ-11681)

added: funtion to retrieve middleName from Person record and append it to the result

Improved: replaces module by MODULE everywhere

    • -24
    • +24
    ./party/contact/ContactMechServices.java
    • -38
    • +38
    ./party/contact/ContactMechWorker.java
    • -7
    • +7
    ./party/content/PartyContentWrapper.java
    • -2
    • +2
    ./party/party/PartyRelationshipHelper.java
    • -5
    • +5
    ./party/party/PartyRelationshipServices.java
    • -70
    • +70
    ./party/party/PartyServices.java
  1. … 673 more files in changeset.
Revert "Improved: Remove unused services from party/services_view.xml and PartyServices.java/.xml. (OFBIZ-9988)"

This reverts commit 00a5d3413a238e0d2b18f2e076cd90670a2e5f71.

    • -0
    • +270
    ./party/party/PartyServices.java
  1. … 2 more files in changeset.
Revert "Improved: Remove unused services from party/services_view.xml and PartyServices.java/.xml. (OFBIZ-9988)"

This reverts commit 00a5d3413a238e0d2b18f2e076cd90670a2e5f71.

    • -0
    • +270
    ./party/party/PartyServices.java
  1. … 2 more files in changeset.
Revert "Improved: Remove unused services from party/services_view.xml and PartyServices.java/.xml. (OFBIZ-9988)"

This reverts commit 00a5d3413a238e0d2b18f2e076cd90670a2e5f71.

    • -0
    • +270
    ./party/party/PartyServices.java
  1. … 2 more files in changeset.
Revert "Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail for CommunicationEvent.subject field" (OFBIZ-10879)

This reverts commit 9706acf064e26c291c0bd10081df8286ae6b359b.

Revert "Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail for CommunicationEvent.subject field" (OFBIZ-10879)

This reverts commit bbcc4692dccdf573aa0205f927b56bc271719031.

Revert "Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail for CommunicationEvent.subject field" (OFBIZ-10879)

This reverts commit 832076ce91dbca182ffab38d27ea72ca5e2cb0be.

Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail for CommunicationEvent.subject field (OFBIZ-10879)

CommunicationEventServices#updateCommEventAfterEmail could generate wrong result. If general.properties value 'mail.notifications.redirectTo' is used, it is possible that the subject string has more than 255 character.

Thanks, Ulrich Heidfeld for your contribution.

Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail for CommunicationEvent.subject field (OFBIZ-10879)

CommunicationEventServices#updateCommEventAfterEmail could generate wrong result. If general.properties value 'mail.notifications.redirectTo' is used, it is possible that the subject string has more than 255 character.

Thanks, Ulrich Heidfeld for your contribution.

Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail for CommunicationEvent.subject field (OFBIZ-10879)

CommunicationEventServices#updateCommEventAfterEmail could generate wrong result. If general.properties value 'mail.notifications.redirectTo' is used, it is possible that the subject string has more than 255 character.

Thanks, Ulrich Heidfeld for your contribution.

Implemented: Provide a service for moving data for marital status field (from boolean to enum) (OFBIZ-10977) Migrate Person's marital status from indicator to enumeration Since revision 1858261(27 April 2019) field oldMaritalStatus of Person has been deprecated. This service can be used to upgrade existing data of oldMaritalStatus field to the new maritalStatusEnumId field of Person Entity. Thanks: Suraj Khurana for your contribution and Jacques Le Roux for the review.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1864215 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +55
    ./party/party/UpgradeServices.java
  1. … 1 more file in changeset.
Improved: Remove useless imports (OFBIZ-11142)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863507 13f79535-47bb-0310-9956-ffa450edef68

    • -1
    • +0
    ./party/contact/ContactMechServices.java
  1. … 18 more files in changeset.
Improved: Use ‘StandardCharsets.UTF_8’ (OFBIZ-11142)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863505 13f79535-47bb-0310-9956-ffa450edef68

    • -1
    • +2
    ./party/contact/ContactMechServices.java
  1. … 26 more files in changeset.
Improved: Inline ‘UtilGenerics#checkList’ (OFBIZ-11141)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863501 13f79535-47bb-0310-9956-ffa450edef68

    • -1
    • +1
    ./party/contact/ContactMechServices.java
  1. … 84 more files in changeset.
Improved: Inline ‘UtilGenerics#checkMap’ (OFBIZ-11141)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863500 13f79535-47bb-0310-9956-ffa450edef68

    • -1
    • +1
    ./party/contact/ContactMechWorker.java
  1. … 78 more files in changeset.
Improved: Remove ‘UtilMisc#toList’ (OFBIZ-11140)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863442 13f79535-47bb-0310-9956-ffa450edef68

  1. … 2 more files in changeset.
Improved: Use the ‘@Override’ annotation (OFBIZ-10939)

The ‘@Override’ annotation helps readers understand that the method at

hand is overriding a super class or implementing an interface.

Additionally it allows the compiler to check if the methods annotated

with ‘@Override’ are actually implementing an abstract method.

Using that annotation makes ‘@see foo.bar.ParentClass#myMethod’

comments useless, so those they have been removed for the newly

annotated methods.

Thanks Jacques Le Roux and Swapnil M Mane for acknowledging the commit.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1858295 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +1
    ./party/content/PartyContentWrapper.java
  1. … 168 more files in changeset.
Improved: Remove redundant specification of type arguments (OFBIZ-10937)

Since Java 1.7, when defining generic types it is unnecessary to

redefine those types in the constructor when it is done in the

declared type.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1857906 13f79535-47bb-0310-9956-ffa450edef68

    • -3
    • +3
    ./party/content/PartyContentWrapper.java
  1. … 239 more files in changeset.
Improved: Remove redundant null checks (OFBIZ-10911)

Redundant null checks detected by Eclipse has been removed.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1857896 13f79535-47bb-0310-9956-ffa450edef68

    • -8
    • +5
    ./party/contact/ContactMechServices.java
  1. … 29 more files in changeset.
"Applied fix from trunk for revision: 1857099" ------------------------------------------------------------------------ r1857099 | jleroux | 2019-04-08 11:17:55 +0200 (lun. 08 avr. 2019) | 12 lignes

Improved: Using try-with-resources with File IO Objects.

(OFBIZ-9855)

Uses try with resources for File IO objects like ObjectInputStream and other

objects. File classes have the AutoCloseable interface.

jleroux: this is only a part of the 2nd patch. The 1st patch will be committed

soon too...

All tests pass

Thanks: Pradhan Yash Sharma

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1857487 13f79535-47bb-0310-9956-ffa450edef68

  1. … 16 more files in changeset.
"Applied fix from trunk for revision: 1857099" ------------------------------------------------------------------------ r1857099 | jleroux | 2019-04-08 11:17:55 +0200 (lun. 08 avr. 2019) | 12 lignes

Improved: Using try-with-resources with File IO Objects.

(OFBIZ-9855)

Uses try with resources for File IO objects like ObjectInputStream and other

objects. File classes have the AutoCloseable interface.

jleroux: this is only a part of the 2nd patch. The 1st patch will be committed

soon too...

All tests pass

Thanks: Pradhan Yash Sharma

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1857486 13f79535-47bb-0310-9956-ffa450edef68

  1. … 16 more files in changeset.
Improved: Using try-with-resources with File IO Objects. (OFBIZ-9855)

Uses try with resources for File IO objects like ObjectInputStream and other

objects. File classes have the AutoCloseable interface.

jleroux: this is only a part of the 2nd patch. The 1st patch will be committed

soon too...

All tests pass

Thanks: Pradhan Yash Sharma

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1857099 13f79535-47bb-0310-9956-ffa450edef68

  1. … 16 more files in changeset.
Reverted: Changes done at r#1857089 and r#1857090 (OFBIZ-10911)(OFBIZ-10912)

The Cleanups introduced by those revisions has introduced some

unexpected regressions making the Gradle ‘loadAll’ task fail.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1857091 13f79535-47bb-0310-9956-ffa450edef68

    • -5
    • +8
    ./party/contact/ContactMechServices.java
  1. … 29 more files in changeset.
Improved: Remove redundant null checks (OFBIZ-10911)

Redundant null checks detected by Eclipse has been removed.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1857089 13f79535-47bb-0310-9956-ffa450edef68

    • -8
    • +5
    ./party/contact/ContactMechServices.java
  1. … 29 more files in changeset.