Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: All the service level error messages for missing required field for order component (#86)

* Improved: All the service level error messages for missing required field for order component

(OFBIZ-7736)

Thanks Ratnesh Upadhyay for reporting and Ankush Upadhyay for providing the updated patch

  1. … 2 more files in changeset.
"Applied fix from trunk for revision: 1859877" ------------------------------------------------------------------------ r1859877 | jleroux | 2019-05-24 15:47:08 +0200 (ven. 24 mai 2019) | 10 lignes

Fixed: Services allow arbitrary HTML for parameters with allow-html set to "safe"

(OFBIZ-5254)

This was reopened after discussion at

https://markmail.org/message/jnaitmwahjcjmdn5

This is a new solution which follows the work done with OFBIZ-6669 and OFBIZ-10187

Roughly said, it uses org.owasp.html.PolicyFactory and org.owasp.html.Sanitizers

Thanks: Christoph Neuroth for report

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1859879 13f79535-47bb-0310-9956-ffa450edef68

  1. … 21 more files in changeset.
"Applied fix from trunk for revision: 1859877" ------------------------------------------------------------------------ r1859877 | jleroux | 2019-05-24 15:47:08 +0200 (ven. 24 mai 2019) | 10 lignes

Fixed: Services allow arbitrary HTML for parameters with allow-html set to "safe"

(OFBIZ-5254)

This was reopened after discussion at

https://markmail.org/message/jnaitmwahjcjmdn5

This is a new solution which follows the work done with OFBIZ-6669 and OFBIZ-10187

Roughly said, it uses org.owasp.html.PolicyFactory and org.owasp.html.Sanitizers

Thanks: Christoph Neuroth for report

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1859878 13f79535-47bb-0310-9956-ffa450edef68

  1. … 21 more files in changeset.
Fixed: Services allow arbitrary HTML for parameters with allow-html set to "safe" (OFBIZ-5254)

This was reopened after discussion at

https://markmail.org/message/jnaitmwahjcjmdn5

This is a new solution which follows the work done with OFBIZ-6669 and OFBIZ-10187

Roughly said, it uses org.owasp.html.PolicyFactory and org.owasp.html.Sanitizers

Thanks: Christoph Neuroth for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859877 13f79535-47bb-0310-9956-ffa450edef68

  1. … 21 more files in changeset.
Fixed: Update and clean deprecated code after release 18.12 creation (OFBIZ-10761) et all deprecated since='Upcoming Release' to since='Release 18.12'

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1850177 13f79535-47bb-0310-9956-ffa450edef68

  1. … 2 more files in changeset.
Improved: Convert QuoteServices.xml mini lang to groovy - Deprecate Mini Lang (OFBIZ-10553) (OFBIZ-9350) Convert all QuoteServices.xml and their xml test Thanks to Antoine Ouvrard, Leila Mekika, Gil Portenseigne and Mathieu Lirzin for this team work to convert all function and tests case

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1849800 13f79535-47bb-0310-9956-ffa450edef68

  1. … 11 more files in changeset.
Improved: Migrate from minilang to entity-auto createQuoteWorkEffort et deleteQuoteWorkEffort. (OFBIZ-10553) But createQuoteWorkEffort is not a crud service on entity QuoteWorkEffort because it is linked to a seca to call createWorkeffort before if a workEffortId is not present in context.

<eca service="createQuoteWorkEffort" event="in-validate">

<condition field-name="workEffortId" operator="is-empty"/>

<action service="createWorkEffort" mode="sync"/>

</eca>

I converted this service createQuoteWorkEffort has a real Crud service and create an other ensureWorkEffortAndCreateQuoteWorkEffort to simulate the attendee process. Now we have a coherent service naming and not surprise for developer .

To manage the service createQuoteWorkEffort as deprecated, I define it twice

<service name="createQuoteWorkEffort" default-entity-name="QuoteWorkEffort" engine="entity-auto" invoke="create" auth="true">

<deprecated use-instead="ensureWorkEffortAndCreateQuoteWorkEffort" since="Upcoming Release">

use createQuoteWorkEffort to create a workeffort has been deprecated for best pratice naming reason, use ensureWorkEffortAndCreateQuoteWorkEffort instead.

Now createQuoteWorkEffort work as a crud service on QuoteWorkEffort

</deprecated>

</service>

<service name="createQuoteWorkEffort" default-entity-name="QuoteWorkEffort" engine="entity-auto" invoke="create" auth="true">

<description>Create a new QuoteWorkEffort</description>

<required-permissions join-type="AND">

<check-permission permission="ORDERMGR" action="_CREATE"/>

</required-permissions>

<auto-attributes mode="IN" include="pk"/>

</service>

First to alert on deprecation and second ensure that the definition work fine.

In log we will have an alert on the deprecation and an alert on the duplicated definition during the deprecation time.

Thanks to Antoine Ouvrard, Gil Portenseigne, Leila Mekika and Mathieu Lirzin for their review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1847056 13f79535-47bb-0310-9956-ffa450edef68

  1. … 5 more files in changeset.
Fixed: Fixed c/p error.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1792271 13f79535-47bb-0310-9956-ffa450edef68

Improved: Converted create and remove QuoteRole service to entity-auto also added update and expire QuoteRole service.(OFBIZ-9331)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1792270 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Implemented: Added CRUD services for QuoteTypeAttr, RejectionReason, ReorderGuideline, RequirementAttribute, RequirementBudgetAllocation, RequirementType, RequirementTypeAttr, RespondingParty, ReturnAdjustmentType and ReturnHeaderType entities.

(OFBIZ-8306) (OFBIZ-8308) (OFBIZ-8309) (OFBIZ-8310) (OFBIZ-8311) (OFBIZ-8314) (OFBIZ-8325) (OFBIZ-8326) (OFBIZ-8327) (OFBIZ-8328)

Thanks: Amit Gadaley for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763306 13f79535-47bb-0310-9956-ffa450edef68

  1. … 6 more files in changeset.
Implemented: Added CRUD services for InvoiceTypeAttr, MrpEventType, OrderAdjustmentAttribute, OrderAdjustmentType, OrderAttribute, OrderBlacklist, OrderBlacklistType, QuantityBreakType, QuoteTermAttribute and QuoteType entities.

(OFBIZ-8271) (OFBIZ-8277) (OFBIZ-8281) (OFBIZ-8283) (OFBIZ-8285) (OFBIZ-8286) (OFBIZ-8287) (OFBIZ-8303) (OFBIZ-8304) (OFBIZ-8305)

Thanks: Amit Gadaley for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763298 13f79535-47bb-0310-9956-ffa450edef68

  1. … 6 more files in changeset.
(OFBIZ-6274) Renamed OFBiz artefacts from org.ofbiz.* to org.apache.ofbiz.*.Thanks to Taher for working on it.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1752920 13f79535-47bb-0310-9956-ffa450edef68

  1. … 3610 more files in changeset.
A big but straightforward commit for "Move minilang scripts from component://componentname/script/org/ofbiz to component://componentname/minilang" - https://issues.apache.org/jira/browse/OFBIZ-7267

I removed duplicate paths were componentname was uselessly repeated after component://componentname/script/org/ofbiz (projectmngr was the only one using there project instead)

I had few typos, easily fixed thanks to the tests. There could be still typos but they are unexpected and anyway no-brainer to fix

I'm still wondering about specialpurpose/example/minilang/README.txt.

I changed its content to

"The minilang directory is for static resources that are interpreted at run time rather than being compiled. This goes on the classpath, but does not get built or put into a JAR file."

not sure it makes any sense, I don't see how this relates to the classpath.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747712 13f79535-47bb-0310-9956-ffa450edef68

  1. … 567 more files in changeset.
Fixes <<Services allow arbitrary HTML for parameters with allow-html set to "safe">> https://issues.apache.org/jira/browse/OFBIZ-5254

After r751990, <<allow-html="any">> and <<allow-html="safe">> are the same: they do nothing! The only difference is the warning message from the OWASP Antisamy IntrusionDetector, which is both, as Christoph noted "giving you a false sense of security" or as I wrote "disturbing, wrong and useless". So there are no longer any reasons for differencing "safe" and "any".

This

* Deprecates "safe" (making it clear in the XSD documentation), keeping only "none" and "any". This is for backward compatibility, else we could completely remove the misleading "safe". Note that "none" is the default.

* Replaces in services definition all allow-html="safe" by allow-html="any"

* Remove from ModelService.java (near line 587) the code which throws the OWASP Antisamy IntrusionDetector message in log

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1536324 13f79535-47bb-0310-9956-ffa450edef68

  1. … 17 more files in changeset.
A patch from Chatree Srichart for "services_quote.xml#quoteSequence-enforced method is not facet-valid with respect to pattern" https://issues.apache.org/jira/browse/OFBIZ-5135

I got an error message:

Error message: cvc-attribute.3: The value 'quoteSequence-enforced' of attribute 'method-name' on element 'simple-method' is not valid with respect to its type, 'javaClassName'.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1446575 13f79535-47bb-0310-9956-ffa450edef68

  1. … 2 more files in changeset.
Added notes to quotes. Patch contributed by Anne Jessel (https://issues.apache.org/jira/browse/OFBIZ-4370) with some changes by me.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1160402 13f79535-47bb-0310-9956-ffa450edef68

  1. … 8 more files in changeset.
A slightly modified patch from Leon - CopyQuote service return new quote id https://issues.apache.org/jira/browse/OFBIZ-4357

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1152729 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
add quoteterm fields to be the same as ordeterm fields, add maintenance screens to the quote, copy quoteterms to orderterms when creating order from quote

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1067840 13f79535-47bb-0310-9956-ffa450edef68

  1. … 14 more files in changeset.
Bug fix. My recent commit r1064953 was creating problem while running test case. Thanks Divesh for providing the fix.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1064993 13f79535-47bb-0310-9956-ffa450edef68

  1. … 3 more files in changeset.
Fix a bunch of no final newline issues.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@965918 13f79535-47bb-0310-9956-ffa450edef68

  1. … 218 more files in changeset.
OFBIZ-3765 - Use CustomMethod for select order, quote and invoice hook to resolve id (https://issues.apache.org/jira/browse/OFBIZ-3765)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@954388 13f79535-47bb-0310-9956-ffa450edef68

  1. … 10 more files in changeset.
sendQuoteReportMail service was giving console error for missing subject & messagewrapper. Fixed the same issue.

Here is the console log for reference:

2010-03-24 10:01:18,146 (http-0.0.0.0-8443-4) [ ServiceDispatcher.java:601:INFO ] Sync service [order/sendMailMultiPart] finished in [8814] milliseconds

2010-03-24 10:01:18,146 (http-0.0.0.0-8443-4) [ ServiceDispatcher.java:601:INFO ] Sync service [order/sendMailFromScreen] finished in [9236] milliseconds

2010-03-24 10:01:18,146 (http-0.0.0.0-8443-4) [ ModelService.java:564:ERROR] [ModelService.validate] : {sendQuoteReportMail} : (OUT) Required test error: org.ofbiz.service.ServiceValidationException: Unknown parameter found: [sendQuoteReportMail.messageWrapper]Unknown parameter found: [sendQuoteReportMail.subject]

2010-03-24 10:01:18,147 (http-0.0.0.0-8443-4) [ ServiceDispatcher.java:495:ERROR]

---- exception report ----------------------------------------------------------

Outgoing result (in runSync : sendQuoteReportMail) does not match expected requirements

Exception: org.ofbiz.service.ServiceValidationException

Message: Unknown parameter found: [sendQuoteReportMail.messageWrapper]Unknown parameter found: [sendQuoteReportMail.subject]

---- stack trace ---------------------------------------------------------------

org.ofbiz.service.ServiceValidationException: Unknown parameter found: [sendQuoteReportMail.messageWrapper]Unknown parameter found: [sendQuoteReportMail.subject]

org.ofbiz.service.ModelService.validate(ModelService.java:648)

org.ofbiz.service.ModelService.validate(ModelService.java:562)

org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:493)

org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:226)

org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:160)

org.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:336)

org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:637)

org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:383)

org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:224)

org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)

javax.servlet.http.HttpServlet.service(HttpServlet.java:710)

javax.servlet.http.HttpServlet.service(HttpServlet.java:803)

org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)

org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)

org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:266)

org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)

org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)

org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)

org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)

org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)

org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)

org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)

org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:568)

org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)

org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)

org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)

org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)

java.lang.Thread.run(Thread.java:619)

--------------------------------------------------------------------------------

2010-03-24 10:01:18,148 (http-0.0.0.0-8443-4) [ ServiceDispatcher.java:516:INFO ] [[Sync service failed...- total:0.0,since last(Begin):0.0]] - 'order / sendQuoteReportMail'

2010-03-24 10:01:18,148 (http-0.0.0.0-8443-4) [ ServiceDispatcher.java:519:ERROR]

---- exception report ----------------------------------------------------------

Service [sendQuoteReportMail] threw an unexpected exception/error

Exception: org.ofbiz.service.ServiceValidationException

Message: Unknown parameter found: [sendQuoteReportMail.messageWrapper]Unknown parameter found: [sendQuoteReportMail.subject]

---- stack trace ---------------------------------------------------------------

org.ofbiz.service.ServiceValidationException: Unknown parameter found: [sendQuoteReportMail.messageWrapper]Unknown parameter found: [sendQuoteReportMail.subject]

org.ofbiz.service.ModelService.validate(ModelService.java:648)

org.ofbiz.service.ModelService.validate(ModelService.java:562)

org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:493)

org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:226)

org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:160)

org.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:336)

org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:637)

org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:383)

org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:224)

org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)

javax.servlet.http.HttpServlet.service(HttpServlet.java:710)

javax.servlet.http.HttpServlet.service(HttpServlet.java:803)

org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)

org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)

org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:266)

org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)

org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)

org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)

org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)

org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)

org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)

org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)

org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:568)

org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)

org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)

org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)

org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)

java.lang.Thread.run(Thread.java:619)

--------------------------------------------------------------------------------

2010-03-24 10:01:18,148 (http-0.0.0.0-8443-4) [ TransactionUtil.java:329:ERROR]

---- exception report ----------------------------------------------------------

[TransactionUtil.rollback]

Exception: java.lang.Exception

Message: Stack Trace

---- stack trace ---------------------------------------------------------------

java.lang.Exception: Stack Trace

org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:328)

org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:310)

org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:526)

org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:226)

org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:160)

org.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:336)

org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:637)

org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:383)

org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:224)

org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)

javax.servlet.http.HttpServlet.service(HttpServlet.java:710)

javax.servlet.http.HttpServlet.service(HttpServlet.java:803)

org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)

org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)

org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:266)

org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)

org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)

org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)

org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)

org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)

org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)

org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)

org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:568)

org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)

org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)

org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)

org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)

java.lang.Thread.run(Thread.java:619)

--------------------------------------------------------------------------------

2010-03-24 10:01:18,153 (http-0.0.0.0-8443-4) [ TransactionUtil.java:339:INFO ] [TransactionUtil.rollback] transaction rolled back

2010-03-24 10:01:18,153 (http-0.0.0.0-8443-4) [ TransactionUtil.java:269:WARN ] [TransactionUtil.commit] Not committing transaction, status is No Transaction (6)

2010-03-24 10:01:18,153 (http-0.0.0.0-8443-4) [ RequestHandler.java:638:INFO ] Ran Event [service:#sendQuoteReportMail] from [request], result is [error]

2010-03-24 10:01:18,169 (http-0.0.0.0-8443-4) [ SequenceUtil.java:336:INFO ] Got bank of sequenced IDs for [ServerHitBin]; curSeqId=10320, maxSeqId=10330, bankSize=10

2010-03-24 10:01:18,259 (http-0.0.0.0-8443-4) [ RequestHandler.java:424:ERROR] Request sendQuoteReportMail caused an error with the following message: {Unknown parameter found: [sendQuoteReportMail.messageWrapper], Unknown parameter found: [sendQuoteReportMail.subject]}

2010-03-24 10:01:18,259 (http-0.0.0.0-8443-4) [ RequestHandler.java:742:INFO ] Rendering View [EditQuoteReportMail],

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@926936 13f79535-47bb-0310-9956-ffa450edef68

Changed the createQuoteWorkEffort seca that triggers createWorkEffort from invoke to in-validate and made workEffortId a required parameter for createQuoteWorkEffort as it should be

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@889921 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
2d part and end of an effort to remove trailing spaces [ \t]+$ => "" (empty) Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135

In the meantime I did some refactoring also in *.java and *.groovy files :

){ => ) {

if( => if (

while( => while (

}else => } else

else{ => else {

switch( => switch (

try{ => try {

}catch => } catch

catch( => catch (

}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68

  1. … 2212 more files in changeset.
order component Following best practice. Changed location="org/ofbiz/......... to location="component:// in the service location attribute.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@755936 13f79535-47bb-0310-9956-ffa450edef68

  1. … 7 more files in changeset.
Manual merge of typecheckcleanup200810 branch as of rev 731346 in that branch, resolved all conflicts; with this BigDecimal is not the native type for many entity fields and is used for many calculations; some work is still needed in certain areas of the project but this covers the most critical ones; thanks especially to Scott for his work on this

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@731851 13f79535-47bb-0310-9956-ffa450edef68

  1. … 234 more files in changeset.
Cleaned up the services and secas around quote report emails: instead of using the QuoteAttribute entity and seca to trigger the email, it is better to just call the sendQuoteReportMail service. Part of OFBIZ-1658

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@653327 13f79535-47bb-0310-9956-ffa450edef68

  1. … 2 more files in changeset.
Create a new service to storeQuote in a single transaction like storeOrder (Issue OFBIZ-1657). New parameters to permit to store also the others Quote entities, and passed the selectAmount field to the calculateProductPrice.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@630472 13f79535-47bb-0310-9956-ffa450edef68

  1. … 2 more files in changeset.
Create a new product store email notification execute on quoteStore event for quote creation status (Part of issue OFBIZ-1658).

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@629220 13f79535-47bb-0310-9956-ffa450edef68

  1. … 3 more files in changeset.
Create a new service to storeQuote in a single transaction like storeOrder (Part of issue OFBIZ-1657)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@628882 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.