Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Migrate checkCreateOrderRequirement service to groovy (OFBIZ-9984)

This commit migrate also dependent method and remove createRequirementFromItemATP service

  1. … 4 more files in changeset.
Improved: Added UI labels for success/error messages for humanres, marketing, order component. (OFBIZ-7696) Thanks Deepak Nigam for reporting and Sourabh Punyani for the patch.

  1. … 5 more files in changeset.
Improved: Added UI labels for success/error messages for humanres, marketing, order component. (OFBIZ-7696) Thanks Deepak Nigam for reporting and Sourabh Punyani for the patch.

  1. … 5 more files in changeset.
Improved: Refactor simple methods names as per naming convention best practices. (#137)

(OFBIZ-11700)

  1. … 7 more files in changeset.
Improved: Refactor simple methods names as per naming convention best practices. (#137)

(OFBIZ-11700)

  1. … 7 more files in changeset.
Fixed: Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity (OFBIZ-10538)

Thanks: Deepak, Taher, Ravi, Amit, Suraj for the contribution.

Fixed: Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity (OFBIZ-10538)

Thanks: Deepak, Taher, Ravi, Amit, Suraj for the contribution.

Fixed: Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity (OFBIZ-10538)

Thanks: Deepak, Taher, Ravi, Amit, Suraj for the contribution.

Improved: Convert OrderServices.xml mini-lang to groovyDSL : getOrderedSummaryInformation

(OFBIZ-9984)

Thanks Julien for your contribution

  1. … 2 more files in changeset.
Improved: Convert OrderServices.xml mini-lang to groovyDSL : getOrderedSummaryInformation

(OFBIZ-9984)

Thanks Julien for your contribution

  1. … 2 more files in changeset.
Improved: Convert OrderServices.xml mini-lang to groovyDSL : getNextOrderId

(OFBIZ-9984)

Thanks Julien for your old patch, it has been improved.

Add a new integration test for the service 'getNextOrderId'

  1. … 4 more files in changeset.
Improved: Convert OrderServices.xml mini-lang to groovyDSL : getNextOrderId

(OFBIZ-9984)

Thanks Julien for your old patch, it has been improved.

Add a new integration test for the service 'getNextOrderId'

  1. … 4 more files in changeset.
Fixed: Unable to continue to Step 3 in One Page Checkout (OFBIZ-11318)

The following error is returned when trying to continue to Step3 when checking

out using One Page Checkout.

Could not create new purpose, a purpose with that type already exists.:

[GenericEntity:PartyContactWithPurpose][contactFromDate,2020-01-05 19:48:18.29

(java.sql.Timestamp)][contactMechId,10020(java.lang.String)]

[contactMechPurposeTypeId,SHIPPING_LOCATION(java.lang.String)]

[partyId,admin(java.lang.String)][purposeFromDate,2020-01-05 19:48:18.332

(java.sql.Timestamp)

It does not happen with DemoCustomer but at least with admin user

It was caused by OFBIZ-10588. I checked for similar issues and found that, in

unlike in createUpdateBillingAddress, in createUpdateShippingAddress and

createUpdateCreditCard partyId was used without a prior setting from

parameters.partyId

Thanks: James Young for proposing a solution. I rather fixed otherwise this and

another similar case in createUpdateCreditCard

Fixed: Unable to continue to Step 3 in One Page Checkout (OFBIZ-11318)

The following error is returned when trying to continue to Step3 when checking

out using One Page Checkout.

Could not create new purpose, a purpose with that type already exists.:

[GenericEntity:PartyContactWithPurpose][contactFromDate,2020-01-05 19:48:18.29

(java.sql.Timestamp)][contactMechId,10020(java.lang.String)]

[contactMechPurposeTypeId,SHIPPING_LOCATION(java.lang.String)]

[partyId,admin(java.lang.String)][purposeFromDate,2020-01-05 19:48:18.332

(java.sql.Timestamp)

It does not happen with DemoCustomer but at least with admin user

It was caused by OFBIZ-10588. I checked for similar issues and found that, in

unlike in createUpdateBillingAddress, in createUpdateShippingAddress and

createUpdateCreditCard partyId was used without a prior setting from

parameters.partyId

Thanks: James Young for proposing a solution. I rather fixed otherwise this and

another similar case in createUpdateCreditCard

Fixed: Unable to continue to Step 3 in One Page Checkout (OFBIZ-11318)

The following error is returned when trying to continue to Step3 when checking

out using One Page Checkout.

Could not create new purpose, a purpose with that type already exists.:

[GenericEntity:PartyContactWithPurpose][contactFromDate,2020-01-05 19:48:18.29

(java.sql.Timestamp)][contactMechId,10020(java.lang.String)]

[contactMechPurposeTypeId,SHIPPING_LOCATION(java.lang.String)]

[partyId,admin(java.lang.String)][purposeFromDate,2020-01-05 19:48:18.332

(java.sql.Timestamp)

It does not happen with DemoCustomer but at least with admin user

It was caused by OFBIZ-10588. I checked for similar issues and found that, in

unlike in createUpdateBillingAddress, in createUpdateShippingAddress and

createUpdateCreditCard partyId was used without a prior setting from

parameters.partyId

Thanks: James Young for proposing a solution. I rather fixed otherwise this and

another similar case in createUpdateCreditCard

"Applied fix from trunk for revision: 1835871" ------------------------------------------------------------------------ r1835871 | surajk | 2018-07-14 07:35:44 +0200 (sam. 14 juil. 2018) | 10 lignes

Improved: All existing party contact mechs should be deleted before creating new one.

(OFBIZ-10396)

Currently, everywhere in code base, before creating new party contact mech record, we use

deletePartyContactMechPurposeIfExists service to delete old records. But, problem is

<first-from-list is used everywhere which only deletes first fetched record.

All previous records should also gets deleted before creating new party contact mech purpose for a specific purpose type.

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1863473 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Fixed: Incorrect PartyContactMechPurpose created while calling createUpdateBillingAddress service. (OFBIZ-10588)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1849515 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Incorrect PartyContactMechPurpose created while calling createUpdateBillingAddress service. (OFBIZ-10588)

createUpdateBillingAddress and createUpdateShippingAddress services create incorrect

PartyContactMechPurpose records with userLogin.partyId.

These services works well in case of when e-commerce logged-in user perform these operation.

But in-correct data is created by these services if called from admin or any other user.

I called createUpdateBillingAddress service from webtools and and didn't get desired results.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1849514 13f79535-47bb-0310-9956-ffa450edef68

Improved: Rename deletePartyContactMechPurpose* services with proper names. Thanks everyone for discussions. (OFBIZ-10398)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1836874 13f79535-47bb-0310-9956-ffa450edef68

  1. … 8 more files in changeset.
Improved: All existing party contact mechs should be deleted before creating new one. (OFBIZ-10396)

Currently, everywhere in code base, before creating new party contact mech record, we use

deletePartyContactMechPurposeIfExists service to delete old records. But, problem is

<first-from-list is used everywhere which only deletes first fetched record.

All previous records should also gets deleted before creating new party contact mech purpose for a specific purpose type.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835871 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Fixed: Existing BILLING_LOCATION record of party should expire while creating a new one. Now service will first expires all the billing location against party and create new one. Applied fix from trunk revision 1831183. (OFBIZ-10374) Thank you Suraj Khuran for reporting the issue and providing patch for the same.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1831185 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Existing BILLING_LOCATION record of party should expire while creating a new one. Now service will first expires all the billing location against party and create new one. (OFBIZ-10374) Thank you Suraj Khuran for reporting the issue and providing patch for the same.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831183 13f79535-47bb-0310-9956-ffa450edef68

Implemented: Use agreement on drop shipment process (OFBIZ-10227)

Extend the drop shipment process to manage an agreement for the supplier related to the order context.

For a supplier we have different agreements with same products but on different prices

Agreement A

GIZMO-1 100€

GIZMO-1 110$

Agreement B

GIZMO-1 90€

Agreement C

GIZMO-1 600¥

During sales order process we resolve the purchase agreement that match the case and put on OrderItemShipGroup related to the supplier. Like that when the drop shipment process run it to resolve the product price for the agreement present on the OrderItemShipGroup. With this implementation we have an adaptable system to manage complex case.

Properly this patch implemented :

an attribute on entity OrderItemShipGroup.supplierAgreementId

an attribute on entity OrderHeader.agreementId (necessary when you update the order to keep the price)

update the service caculatePurchasePrice for resolve the price from a agreement if it's present

update the shoppingCart to insert a purchase agreement

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825002 13f79535-47bb-0310-9956-ffa450edef68

  1. … 18 more files in changeset.
Fixed: In 'updateOrderContactMech' service, A check should be added to call 'removeOrderContactMech'. (OFBIZ-9967)

In case, user don't create orderContactMech while creating an order and wish to

create orderContactMech after the creation then, 'updateOrderContactMech'

throws error of 'oldContactMechId' parameter missing in 'removeOrderContactMech'

service.

Adds a 'if-not-empty' check for 'oldContactMechId' field i.e, if

'oldContactMechId' is available then only 'removeOrderContactMech' service

should be called in 'updateOrderContactMech' service.

Thanks: Sonal Patwari

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816795 13f79535-47bb-0310-9956-ffa450edef68

Fixed: Consistency and Readability improvements for make-value tag (OFBIZ-8986) Consistency on the attribute order for make-value element as : entity-name, value-field Thanks to Ankush Upadhyay and Devanshu Vyas for the issue and the corrective patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1805956 13f79535-47bb-0310-9956-ffa450edef68

  1. … 52 more files in changeset.
No functional change,

While checking there were no other cases like in OFBIZ-9432

(missing path to class), to be consistent I removed the trailing semicolons in

groovy scripts and made few formatting

I did not changes tests code

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1799867 13f79535-47bb-0310-9956-ffa450edef68

  1. … 7 more files in changeset.
Reverted: Minilang code readability and consistency improvements done at r#1768222, this commit reversed key and description of drop-down in the code. (OFBIZ-9114)

Thanks Wei Zhang for reporting the issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772880 13f79535-47bb-0310-9956-ffa450edef68

  1. … 158 more files in changeset.
Reverted: Partially reverted 1768239, and completely reverts 1768257 and 1762999. (OFBIZ-8722)(OFBIZ-8339)(OFBIZ-8723)

As setting set-if-null to false fix one issue and introduced another one, reverting commit for now will debug it in more detail and will commit proper fix if found.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1769057 13f79535-47bb-0310-9956-ffa450edef68

  1. … 44 more files in changeset.
Fixed: Fixed typo introduced in r1768219

Thanks Suraj Khurana for reporting the issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768662 13f79535-47bb-0310-9956-ffa450edef68

  1. … 30 more files in changeset.
Fixed: Update Services that sets non-pk fields to null if not passed, if non-pks not passed than it should remain unupaded.

(OFBIZ-8722)

Thanks Pawan Verma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768239 13f79535-47bb-0310-9956-ffa450edef68

  1. … 50 more files in changeset.