Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Remove unused imports from Java files (OFBIZ-11930) (#222)

Improved: Remove unused imports from Java files

(OFBIZ-11930)

Thanks: Priya Sharma

  1. … 16 more files in changeset.
Improved: Status ID checkbox for FindWorkEffort, FindProductionRun and FindShipment forms (OFBIZ-11939)

    • -0
    • +9
    ./widget/manufacturing/JobshopScreens.xml
  1. … 4 more files in changeset.
Improved: Corrected some line is longer than 150 characters checkstyle issues in applications component. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)

  1. … 88 more files in changeset.
Improved: Corrected all incorrect indentation level issues in application component, also fixed some case indentation checkstyle issues. (OFBIZ-11922)

  1. … 88 more files in changeset.
Improved: Updated case indentation to 0 for all switch statements in applications component. Also done formatting changes as per checkstyle best practices. (OFBIZ-11904)

  1. … 55 more files in changeset.
Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in applications component. (OFBIZ-11886)

  1. … 68 more files in changeset.
Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in applications component. (OFBIZ-11887)

  1. … 101 more files in changeset.
Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in applications component. (OFBIZ-11880) Thanks Jacques for review.

  1. … 96 more files in changeset.
Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for applications component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace. '{' is not followed by whitespace. '}' is not followed by whitespace. '}' is not preceded with whitespace. 'typecast' is not followed by whitespace. 'try' is not followed by whitespace. ';' is preceded with whitespace.

  1. … 102 more files in changeset.
Improved: Corrected all checkstyle issues related to succeeding space for comma in applications directory. (OFBIZ-11805) Thanks Jacques and Ritesh Kumar for review.

  1. … 47 more files in changeset.
Improved: Corrected remaining ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805)

  1. … 33 more files in changeset.
Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors in applications component. (OFBIZ-11805) Thanks Jacques Le Roux and Ritesh Kumar for review.

  1. … 43 more files in changeset.
Improved: Cannot find the declaration of element 'web-app' in version 3.0 files. (OFBIZ-6993)

I missed to backport changes web.xml (was OK in plugins)

    • -1
    • +1
    ./webapp/manufacturing/WEB-INF/web.xml
  1. … 24 more files in changeset.
Improved: Replace explicit type argument with diamond operator(OFBIZ-11828)

Since Java 1.7, when defining generic types it is unnecessary to redefine those types in the constructor when it is already done in the declared type.

  1. … 19 more files in changeset.
Improved: Merge identical catch blocks in single catch block(OFBIZ-11827)

In Java SE 7 and later, a single catch block can handle more than one type of exception. This feature can reduce code duplication and lessen the temptation to catch an overly broad exception.

Thanks: Jacques for the review.

  1. … 47 more files in changeset.
Improved: Replace for-loop with forEach loop(OFBIZ-11829)

Also modified some checkstyle issues.

Set checkstyleMain.maxErrors to 26684 (-61)

Thanks: Jacques for the review.

  1. … 11 more files in changeset.
Documented: remove docbook help files for manufacturing (OFBIZ-11587)

All files have been migrated to asciidoc format.

    • -281
    • +0
    ./data/ManufacturingHelpData_NL.xml
    • -43
    • +0
    ./data/helpdata/Help_MFG_BomSimulation.xml
    • -36
    • +0
    ./data/helpdata/Help_MFG_CreateProductionRun_NL.xml
    • -30
    • +0
    ./data/helpdata/Help_MFG_EditCalendar.xml
    • -36
    • +0
    ./data/helpdata/Help_MFG_EditCalendarExceptionDay.xml
    • -31
    • +0
    ./data/helpdata/Help_MFG_EditCalendarExceptionDay_NL.xml
    • -36
    • +0
    ./data/helpdata/Help_MFG_EditCalendarExceptionWeek.xml
    • -31
    • +0
    ./data/helpdata/Help_MFG_EditCalendarExceptionWeek_NL.xml
    • -45
    • +0
    ./data/helpdata/Help_MFG_EditCostCalcs.xml
  1. … 59 more files in changeset.
Documented: migrate help link to asciidoc user manual for manufacturing (OFBIZ-11416)

All files have been migrated to asciidoc format and help link now point

to the html file generated from the asciidoc files

In the global Help Docbook index tree, remove all points about

manufacturing and add a short page with a link to the new help

    • -254
    • +3
    ./data/ManufacturingHelpData_EN.xml
    • -0
    • +6
    ./widget/manufacturing/CalendarScreens.xml
    • -0
    • +1
    ./widget/manufacturing/CommonScreens.xml
    • -0
    • +1
    ./widget/manufacturing/CostScreens.xml
    • -1
    • +11
    ./widget/manufacturing/JobshopScreens.xml
    • -0
    • +1
    ./widget/manufacturing/ReportScreens.xml
    • -1
    • +11
    ./widget/manufacturing/RoutingScreens.xml
Improved: Changed decimals, rounding, zero static variables names as per best practices in manufacturing component. (#200)

(OFBIZ-11804)

Also make them private data members of the class.

WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762) (#185)

* [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug

- Replaced the debug.log methods with the respective groovy utility method

- Enhanced the GroovyBaseScript to entertain the fetch the current class name as the module name for logging

- Overloaded the logError method to entertain throwbale object for better logging

- Removed unused import statements and module variables.

(OFBIZ-11762)

* [Removed]: Extra line spaces. (OFBIZ-11762)

* [Revert]: Unwanted changes. (OFBIZ-11762)

* [Added] Same changes to these files. (OFBIZ-11762)

Co-authored-by: Priya Sharma <priya.sharma@example.com>

    • -2
    • +1
    ./groovyScripts/bom/BomSimulation.groovy
  1. … 35 more files in changeset.
Improved: Changed resources with proper naming convention in all application components. (OFBIZ-11739) Also, made MODULE as private data member of class instead of public. This will reduce checkstlye issues. Thanks Jacques for review.

  1. … 211 more files in changeset.
Improved: Convert ProductionRunServices.xml file from mini-lang to groovy DSL (OFBIZ-11395)

Thanks to Yashwant Dhakad for this patch

    • -0
    • +397
    ./groovyScripts/jobshopmgt/ProductionRunServices.groovy
    • -10
    • +10
    ./servicedef/services_production_run.xml
Improved: No need to specify externalKeyParam in ofbizUrl calls (OFBIZ-11711)

Let ofbizUrl macro generates externalLoginKey when needed.

Thanks: Jacques for review

  1. … 26 more files in changeset.
Improved: Apply multi-block attr to each application (OFBIZ-11706)

For Accounting, Content, HR, Manufacturing.

    • -4
    • +0
    ./template/mrp/FindInventoryEventPlan.ftl
    • -2
    • +2
    ./widget/manufacturing/RoutingScreens.xml
  1. … 14 more files in changeset.
Improved: Converted all TechDataCalendar related CRUD services from simple to entity-auto (#112)

(OFBIZ-11632)

Improved: Converted all TechDataCalendarWeek related CRUD services from simple to entity-auto (#109)

(OFBIZ-11644)

Improved: Converted all TechDataCalendarExcWeek related CRUD services from simple to entity-auto (#104)

(OFBIZ-11636)

Improved: Converted all TechDataCalendarExcDay related CRUD services from simple to entity-auto (#96)

Improved: Converted all TechDataCalendarExcDay related CRUD services from simple to entity-auto

(OFBIZ-11622)

Also, added a permission service for MANUFACTURING related base permission.

Documented: Check all docbook file in each applications-component documents directory (OFBIZ-11587)

remove all files

  1. … 8 more files in changeset.
Improved: replaces module by MODULE everywhere

  1. … 673 more files in changeset.