Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Removed: Deprecated entity captureBillingAccountPayments since release 17.12. (#131)

(OFBIZ-11435)

Also, added deprecated since tag in some old entities and fields. This is done as per current policy to deprecate entities/services.

Thanks Pierre for reporting and Jacques for review.

  1. … 4 more files in changeset.
Fixed: DataModel - correct foreign key (#51)

(OFBIZ-11474)

Renaming foreign key to PROD_PRCDE_OPCD

Fixed: DataModel - correct foreign key (#51)

(OFBIZ-11474)

Renaming foreign key to PROD_PRCDE_OPCD

Fixed: Specified key was too long; max key length is 767 bytes for ProductPromoCodeEmail entity.(OFBIZ-5426) (#44)

* Fixed: Specified key was too long; max key length is 767 bytes for ProductPromoCodeEmail entity.

(OFBIZ-5426)

The problem is in the entity model. An email address should not be used in the primary key - mainly because an email address is case-insensitive. A better design would be to use the email address contact mechanism ID in the primary key.

Done Following:

1. Changed Entity Name from ProductPromoCodeEmail to ProductPromoCodeContMech

2. Related Changes for the entity name change

3. Migration service to migrate old data

Thanks, Leon for the report and Adrian Crum, Jacques Le Roux, Ingo Wolfmayr, Deepak Dixit, Pierre Smits and Gil Portenseigne for the discussion and review.

* Improved: Added new line in service definition file and lincence in MigrationServices file.

(OFBIZ-5426)

Thanks, Jacopo for the review.

  1. … 9 more files in changeset.
Fixed: Specified key was too long; max key length is 767 bytes for ProductPromoCodeEmail entity.(OFBIZ-5426) (#44)

* Fixed: Specified key was too long; max key length is 767 bytes for ProductPromoCodeEmail entity.

(OFBIZ-5426)

The problem is in the entity model. An email address should not be used in the primary key - mainly because an email address is case-insensitive. A better design would be to use the email address contact mechanism ID in the primary key.

Done Following:

1. Changed Entity Name from ProductPromoCodeEmail to ProductPromoCodeContMech

2. Related Changes for the entity name change

3. Migration service to migrate old data

Thanks, Leon for the report and Adrian Crum, Jacques Le Roux, Ingo Wolfmayr, Deepak Dixit, Pierre Smits and Gil Portenseigne for the discussion and review.

* Improved: Added new line in service definition file and lincence in MigrationServices file.

(OFBIZ-5426)

Thanks, Jacopo for the review.

  1. … 9 more files in changeset.
"Applied fix from trunk for revision: 1862271" ------------------------------------------------------------------------ r1862271 | jleroux | 2019-06-28 11:39:44 +0200 (ven. 28 juin 2019) | 11 lignes

fixed: supplierProductId Should Have Consistent Types Across Entities.

(OFBIZ-10150)

During some data migration I hit an issue where my data for supplierProductId

was too long. So I looked up the fields and noticed that the order item entity

had a different type for the field than the supplier product entity.

jleroux: we should do it for all cases

Thanks: jesse thomas for report and Rohit Hukkeri for the fix

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1862273 13f79535-47bb-0310-9956-ffa450edef68

"Applied fix from trunk for revision: 1862271" ------------------------------------------------------------------------ r1862271 | jleroux | 2019-06-28 11:39:44 +0200 (ven. 28 juin 2019) | 11 lignes

fixed: supplierProductId Should Have Consistent Types Across Entities.

(OFBIZ-10150)

During some data migration I hit an issue where my data for supplierProductId

was too long. So I looked up the fields and noticed that the order item entity

had a different type for the field than the supplier product entity.

jleroux: we should do it for all cases

Thanks: jesse thomas for report and Rohit Hukkeri for the fix

------------------------------------------------------------------------

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1862272 13f79535-47bb-0310-9956-ffa450edef68

fixed: supplierProductId Should Have Consistent Types Across Entities. (OFBIZ-10150)

During some data migration I hit an issue where my data for supplierProductId

was too long. So I looked up the fields and noticed that the order item entity

had a different type for the field than the supplier product entity.

jleroux: we should do it for all cases

Thanks: jesse thomas for report and Rohit Hukkeri for the fix

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1862271 13f79535-47bb-0310-9956-ffa450edef68

Improved: Having ability to make Configurable options date controlled (OFBiz-10950)

Thanks: Pritam Kute for reporting and Mohammed Rehan Khan for providing patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1858305 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Improved: Added support for Inventory (Supply) Allocation Planning. (OFBIZ-10518) Thanks Deepak Nigam for initiating this feature and providng the patches, Arun Patidar for review and Swapnil Shah for design discussions.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1858270 13f79535-47bb-0310-9956-ffa450edef68

  1. … 22 more files in changeset.
Implemented: Short Messaging Service(SMS) Gateway Integration. Added data model, configuration settings, data and services to support the sms services. For the specific service provider user of this implementaion needs to go for custom implementation. That means ticket contains the example of the integration how to use with sample plugin for message91 services. (OFBIZ-10457) Thanks to Pritam Kute for your contribution. Thanks to Pierre Smits and Michael Brohi for your review and inputs.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1855389 13f79535-47bb-0310-9956-ffa450edef68

  1. … 7 more files in changeset.
Fixed: Update and clean deprecated code after release 18.12 creation (OFBIZ-10761) Remove deprecated entity fields deprecated for more 10 years and without impact with source code Add since deprecate release on comment for PartyAcctgPreference definition and demo data to help the next analyse

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1850182 13f79535-47bb-0310-9956-ffa450edef68

  1. … 3 more files in changeset.
Fixed: Demo Data based on the proposed design to support replenishment planning through any inter-company facility. (OFBIZ-7357)

Fix double fk-name in ProductFacility entity relations, leading to a double index error.

Improve overall formatting of the entity declaration

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1849853 13f79535-47bb-0310-9956-ffa450edef68

Added: Demo Data based on the proposed design to support replenishment planning through any inter-company facility. (OFBIZ-7357) For high level design and requirement details, please refer ticket (OFBIZ-6964) Thanks Swapnil and Yashwant for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1849547 13f79535-47bb-0310-9956-ffa450edef68

  1. … 7 more files in changeset.
Fixed: Warning in console logs related to entity definitions (OFBIZ-10540) I introduced two waring on log with the commit OFBIZ-10514 (Refactoring ContactMechWorker.get[Entity]ContactMechValueMap) Thanks to Deepak Nigam to raise and correct it

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1839965 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Improved: Refactoring ContactMechWorker.get[Entity]ContactMechValueMaps function to improve processing speed (OFBIZ-10514) ContactMechWorker.get[Entity]ContactMechValueMaps are old historic functions that resolve all contact mech context related to an Entity (Party, Facility, Order, WorkEffort). The problem that they create too many db call during their execution that decrease OFBiz performance when the contactMech history grow.

A solution use to improve the process speed was replace all db call through *GenericValue.getRelated* function by *Delegator.makeValidValue* to instanciate each GenericValue needed after an unique search call on a viewEntity. For the four entities : Party, Facility, Order and WorkEffort, I use the same view structure with a sub view entity on ContactMechDetail. This offer more genericity and permit to slim code.

This commit introduce a regression on genericValue resolved for ContactMechType and ContactMechPurposeType that currently lost their description, it's actually not awkward because theses genericValue use the function .get("description", locale) to resolve the description so call directly the label system.

For Order and WorkEffort, I merged the resolving process in one function, that can be extend later easily for some other entity like Invoice or Quote.

The new FtpAddress wasn't managed by this worker so I introduce it to keep the coherence.

Last improvement, I use

getPartyContactMechValueMaps(Delegator delegator, String partyId, Timestamp date, String contactMechTypeId)

instead of

getPartyContactMechValueMaps(Delegator delegator, String partyId, boolean showOld, String contactMechTypeId)

to offert also more possibility to resolve at date instead just use now or all.

icing on the cake, I added groovy test to control this worker

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1838349 13f79535-47bb-0310-9956-ffa450edef68

  1. … 7 more files in changeset.
Improved: Enable drop-ship PO feature at product store and product facility level as well, applied patch from jira issue with slightly changes. (OFBIZ-9987)

Thanks, Ankit Joshi for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1834190 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Improved: Remove Entity suffix from title of all entities. In all EntityModel.xml files, title should not contain Entity as suffix. (OFBIZ-10408) Thanks to Suraj Khurana for reporting the improvement and providing fix for that.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832235 13f79535-47bb-0310-9956-ffa450edef68

  1. … 16 more files in changeset.
Improved: Migrate product promotion condition and action rule on SOA (OFBIZ-10370)

Currently promotion rule engine works with :

entities ProductPromoCond et ProductPromoAction

java linear function ProductPromoWorker.checkCondition() (ProductPromoWorker:910) and ProductPromoWorker.performAction (ProductPromoWorker:1423)

Enumeration list to indicate on java function what piece of code to activate the control or action

The problem with this structure is when you want to create a new case of condition or action, you need to modify the framework code base.

We convert the 2 big java leaner function to service representation with one service by case. To realize it we introduce a relation with CustomMethod :

ProductPromoRule --> ProductPromoCond -> CustomMethod

-> ProductPromoAction -> CustomMethod

Each functions's case are converted to service with a related CustomMethod.

With this pattern now you can write your own condition rule and action rule on your plugin and link it on the promo engine

For backward compatibility purpose, current "PPIP" enumeration entries receive in enumCode data the new corresponding customMethodId reference, to ensure that old data works fine with the new engine

on EntityData

<CustomMethod customMethodId="PPC_PRODUCT_AMOUNT" customMethodTypeId="PRODUCT_PROMO_COND" customMethodName="productPromoCondProductAmount" description="Product amount"/>

<Enumeration enumId="PPIP_PRODUCT_AMOUNT" enumCode="PPC_PRODUCT_AMOUNT"/><!--link enumeration with customMethod for backward compatibility-->

on Java

//for backward compatibility resolve customMethodId from enumCode

GenericValue condEnum = EntityQuery.use(delegator).from("Enumeration").where("enumId", inputParamEnumId).cache().queryOne();

if (condEnum != null) {

customMethod = EntityQuery.use(delegator).from("CustomMethod").where("customMethodId", condEnum.get("enumCode")).cache().queryOne();

if (customMethod == null) {

Debug.logWarning("The oldest enumeration " + inputParamEnumId + " for promo " + productPromoCond.getPkShortValueString() + " haven't the new customMethod to use, please check your data or load seed data", module);

return false;

}

serviceName = customMethod.getString("customMethodName");

}

Many thanks to Ziri Khalifa and Leila Mekika for their helping work

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831783 13f79535-47bb-0310-9956-ffa450edef68

  1. … 14 more files in changeset.
Fxied: Corrected fk-name warning for newly added entities, fk-name was greater than 18 character.(OFBIZ-10040)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818243 13f79535-47bb-0310-9956-ffa450edef68

Implemented: Create a new entity FacilityCalendar (OFBIZ-10040)

Creates a new entity facilityCalendar which will create the one-to-many

relationship between facility and calendar. Here are the entity attributes:

*FacilityCalendar*

* facilityId*

* calendarId*

* facilityCalendarTypeId*

* fromDate*

* thruDate

*FacilityCalendarType*

* facilityCalendarTypeId*

* parentTypeId

* description

A calendar will be used to store opening time, closing time, working weekdays

and all this type of stuff.

For further information please refer

http://ofbiz.markmail.org/message/nectwaze6ina7y6z

Thanks: Vaibhav Jain for the initial proposition and all people who participated

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817347 13f79535-47bb-0310-9956-ffa450edef68

Improved: Merge extended entity definition in data model component into the existing entity definition (OFBIZ-9581)

Thanks Aditya Sharma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809376 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Improved: OEM Party Id field should have lookup on Edit Product page (OFBIZ-9368)

As suggested by Jacques and Pierre, the patch includes removing all the traces

of OEMPartyId (manufacturerPartyId) as it was some old approach.

Changes in Patch:

1. Removed manufacturerPartyId from Product entity

2. Removed its relations from view entities namely GoodIdentificationAndProduct

3. Removed it from forms EditProduct (Product),

SearchInventoryItemsParams (EditFacilityInventoryItems screen in Facility) and

SearchInventoryItemsDetailsParams (ViewFacilityInventoryItemsDetails screen in

Facility)

Thanks: Aditya Sharma

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804408 13f79535-47bb-0310-9956-ffa450edef68

  1. … 3 more files in changeset.
Improved: Replace fields with id-ne, id-long-ne and id-vlong-ne by id, id-long and id-vlong respectively which are not primary keys (OFBIZ-9355) Thanks Aditya Sharma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1804026 13f79535-47bb-0310-9956-ffa450edef68

  1. … 15 more files in changeset.
Improved: Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne" with "id", "id-long" and "id-vlong" respectively which are primary keys (OFBIZ-9351) Thanks Aditya Sharma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1796379 13f79535-47bb-0310-9956-ffa450edef68

  1. … 15 more files in changeset.
Implemented: Multisite support in specialpurpose/cmssite (OFBIZ-7120)

This is the first patch from the ticket and is for the implementation done to support the multisite feature in specialpurpose/cmssite component.

Thanks Mohammed Rehan Khan for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761150 13f79535-47bb-0310-9956-ffa450edef68

  1. … 4 more files in changeset.
(OFBIZ-7986) Fixed console warning related to duplicate field alias.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1759002 13f79535-47bb-0310-9956-ffa450edef68

A patch from Deepak Nigam for "Warning related to 'InventoryItemAndLocation' entity on server start " https://issues.apache.org/jira/browse/OFBIZ-7986

On starting ofbiz server following error is coming at console :

2016-08-27 11:53:54,084 |delegator-startup-1 |ModelViewEntity |I| [InventoryItemAndLocation]: Throwing out field alias in view entity because one already exists with the alias name [inventoryItemTypeId] and field name [PR(Product).inventoryItemTypeId], existing field name is [II.inventoryItemTypeId] 2016-08-27 11:53:54,088 |delegator-startup-1 |ModelViewEntity |I| [ProductInventoryItem]: Throwing out field alias in view entity because one already exists with the alias name [inventoryItemTypeId] and field name [II(InventoryItem).inventoryItemTypeId], existing field name is [PR.inventoryItemTypeId]

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1757968 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-7624) Applied patch from jira issue =================================== Add "changeByUserLoginId" field for InventoryItemStatus =================================== Thanks Nameet and Renuka for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1757956 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
(OFBIZ-6274) Renamed OFBiz artefacts from org.ofbiz.* to org.apache.ofbiz.*.Thanks to Taher for working on it.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1752920 13f79535-47bb-0310-9956-ffa450edef68

  1. … 3610 more files in changeset.