Clone Tools
  • last updated 25 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Remove unused imports from Java files (OFBIZ-11930) (#222)

Improved: Remove unused imports from Java files

(OFBIZ-11930)

Thanks: Priya Sharma

  1. … 17 more files in changeset.
Improved: Corrected all redundant modifiers occurences from applications component. Also, fixed some other checkstyle line formatting and spacing issues. (OFBIZ-11925)

  1. … 8 more files in changeset.
Improved: Unit test case for some content services (OFBIZ-8420)

Covered following tickets/services,

OFBIZ-8420 --> createDataCategory

OFBIZ-8421 --> updateDataCategory

OFBIZ-8422 --> removeDataCategory

OFBIZ-8424 --> createDataResourceRole

OFBIZ-8425 --> updateDataResourceRole

OFBIZ-8426 --> removeDataResourceRole

Thanks, Tanmay Muley for reporting the issue.

Improved: Status ID checkbox for FindDataResource and FindContent forms (OFBIZ-11934)

    • -3
    • +3
    ./widget/content/DataResourceForms.xml
    • -0
    • +9
    ./widget/content/DataResourceScreens.xml
Improved: Corrected some line is longer than 150 characters checkstyle issues in applications component. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)

  1. … 77 more files in changeset.
Fixed: Inconsistent String Comparisons (OFBIZ-9254) & Uploading image to data resource (OFBIZ-10834)

Changes made in startsWith and indexOf methods in ContentManagementServices

for OFBIZ-9254 where wrong (reversed). Fortunately only place where this happened.

I added a comment to make clear why we have 2 empty else if

I'll backport later, conflicts to handle by hand...

Thanks: Ankush Upadhyay for spotting the bug

Conflicts handled by hand

Fixed: Inconsistent String Comparisons (OFBIZ-9254) & Uploading image to data resource (OFBIZ-10834)

Changes made in startsWith and indexOf methods in ContentManagementServices

for OFBIZ-9254 where wrong (reversed). Fortunately only place where this happened.

I added a comment to make clear why we have 2 empty else if

I'll backport later, conflicts to handle by hand...

Thanks: Ankush Upadhyay for spotting the bug

Conflicts handled by hand

Fixed: Inconsistent String Comparisons (OFBIZ-9254) & Uploading image to data resource (OFBIZ-10834)

Changes made in startsWith and indexOf methods in ContentManagementServices

for OFBIZ-9254 where wrong (reversed). Fortunately only place where this happened.

I added a comment to make clear why we have 2 empty else if

I'll backport later, conflicts to handle by hand...

Thanks: Ankush Upadhyay for spotting the bug

Improved: Corrected all incorrect indentation level issues in application component, also fixed some case indentation checkstyle issues. (OFBIZ-11922)

  1. … 83 more files in changeset.
Improved: Updated case indentation to 0 for all switch statements in applications component. Also done formatting changes as per checkstyle best practices. (OFBIZ-11904)

  1. … 51 more files in changeset.
Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in applications component. (OFBIZ-11886)

  1. … 56 more files in changeset.
Improved: Use Error.ftl everywhere it's not yet used (OFBIZ-11890)

Removes all error*.jsp reference, no longer used

    • -26
    • +0
    ./webapp/content/error/error403.jsp
    • -26
    • +0
    ./webapp/content/error/error404.jsp
  1. … 20 more files in changeset.
Improved: Convert createEmailContent service from mini-lang to groovy DSL(OFBIZ-11370)

Thanks, Devanshu for the report and Rohit for initial patch and Nicolas for updated patch and review.

    • -39
    • +0
    ./minilang/content/ContentServices.xml
Improved: Convert indexContentKeywords and forceIndexContentKeywords services from miniland to groovy(OFBIZ-11390)(OFBIZ-11392)

Thanks, Devanshu for report and Sourabh and Aishwary for the patch.

    • -21
    • +0
    ./minilang/content/ContentServices.xml
Improved: Reflected XSS in content component (OFBIZ-11840)

Fixes a Reflected XSS vulnerability in content component

Harshit Shukla reported it to the OFBiz security team:

https://demo-stable.ofbiz.apache.org/content/control/stream?contentId="><svg/onload=alert(0)>

It's a post-auth vulnerability so we did not ask for a CVE.

Thanks: Harshit Shukla harshit.shukz@gmail.com

Improved: Reflected XSS in content component (OFBIZ-11840)

Fixes a Reflected XSS vulnerability in content component

Harshit Shukla reported it to the OFBiz security team:

https://demo-stable.ofbiz.apache.org/content/control/stream?contentId="><svg/onload=alert(0)>

It's a post-auth vulnerability so we did not ask for a CVE.

Thanks: Harshit Shukla harshit.shukz@gmail.com

Improved: Reflected XSS in content component (OFBIZ-11840)

Fixes a Reflected XSS vulnerability in content component

Harshit Shukla reported it to the OFBiz security team:

https://demo-stable.ofbiz.apache.org/content/control/stream?contentId="><svg/onload=alert(0)>

It's a post-auth vulnerability so we did not ask for a CVE.

Thanks: Harshit Shukla harshit.shukz@gmail.com

Improved: Convert updateCommContentDataResource service from mini-lang to groovy DSL(OFBIZ-11379)

Thanks, Devanshu for the report, Sourabh for the initial patch and Nicolas for the updated patch.

    • -36
    • +0
    ./minilang/content/ContentServices.xml
Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in applications component. (OFBIZ-11887)

  1. … 96 more files in changeset.
Documented: Framework, delete all docbook files related to migration to asciidoc (OFBIZ-11587)

Add a link to developer-manual for webtools in old help system

  1. … 1 more file in changeset.
Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in applications component. (OFBIZ-11880) Thanks Jacques for review.

  1. … 93 more files in changeset.
Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for applications component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace. '{' is not followed by whitespace. '}' is not followed by whitespace. '}' is not preceded with whitespace. 'typecast' is not followed by whitespace. 'try' is not followed by whitespace. ';' is preceded with whitespace.

  1. … 91 more files in changeset.
Improved: Corrected all checkstyle issues related to succeeding space for comma in applications directory. (OFBIZ-11805) Thanks Jacques and Ritesh Kumar for review.

  1. … 42 more files in changeset.
Improved: Corrected remaining ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805)

  1. … 32 more files in changeset.
Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors in applications component. (OFBIZ-11805) Thanks Jacques Le Roux and Ritesh Kumar for review.

  1. … 40 more files in changeset.
Improved: Converted deleteContentKeywords service from mini-lang to groovy DSL. (OFBIZ-11391) Thanks Devanshu Vyas for reporting and Yogesh Naroliya for the patch.

    • -4
    • +0
    ./minilang/content/ContentServices.xml
Improved: Converted createContentFromDataResource service from mini-lang to groovy DSL. (OFBIZ-11377) Thanks Devanshu Vyas for reporting and Anushi Gupta for the patch.

    • -37
    • +0
    ./minilang/content/ContentServices.xml
Improved: Converted getContentAndDataResource service from mini-lang to groovy DSL. (OFBIZ-11382) Thanks Devanshu Vyas for reporting and Ravi Lodhi for the patch.

    • -21
    • +2
    ./minilang/content/ContentServices.xml
Improved: Cannot find the declaration of element 'web-app' in version 3.0 files. (OFBIZ-6993)

I missed to backport changes web.xml (was OK in plugins)

    • -1
    • +1
    ./webapp/contentimages/WEB-INF/web.xml
  1. … 23 more files in changeset.
Documented: migrate help link to asciidoc user manual for Party (OFBIZ-11581)

All files have been migrated to asciidoc format and help link now point

to the html file generated from the asciidoc files

In the global Help Docbook index tree, remove all points about

Party and add a short page with a link to the new help

Remove docbook help files for Party

  1. … 5 more files in changeset.