Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Convert getInvoicePaymentInfoListByDueDateOffset service from mini-lang to groovy DSL (OFBIZ-11486)

Thanks: Devanshu Vyas for report, Nitish Mishra for the patch

    • -39
    • +0
    ./minilang/payment/PaymentServices.xml
Improved: Convert cancelCheckRunPayments service from mini-lang to groovy DSL (OFBIZ-11494)

Thanks: Devanshu Vyas for report, Yogesh Naroliya for the patch

    • -26
    • +0
    ./minilang/payment/PaymentServices.xml
Improved: Remove unused imports from Java files (OFBIZ-11930) (#222)

Improved: Remove unused imports from Java files

(OFBIZ-11930)

Thanks: Priya Sharma

  1. … 17 more files in changeset.
Improved: Corrected all redundant modifiers occurences from applications component. Also, fixed some other checkstyle line formatting and spacing issues. (OFBIZ-11925)

  1. … 7 more files in changeset.
Improved: Status ID checkbox for FindPayments and FindPurchaseInvoices forms (OFBIZ-11938)

Improved: Improvements in Find Invoice screen (OFBIZ-9643)

Thanks, Renuka Srishti for reporting the issue.

Improved: Corrected some line is longer than 150 characters checkstyle issues in applications component. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)

  1. … 77 more files in changeset.
Improved: Inconsistent String Comparisons(OFBIZ-9254)

There are some inconsistencies in the code for string comparison statusId.equals(PRUN_COMPLETED) whereas it should be written as PRUN_COMPLETED.equals(statusId) cause the former can throw NullPointerException if the variable found to be NULL.

Thanks: Devanshu for your contribution.

  1. … 9 more files in changeset.
Improved: Corrected all incorrect indentation level issues in application component, also fixed some case indentation checkstyle issues. (OFBIZ-11922)

  1. … 83 more files in changeset.
Revert "Improved: Convert voidPayment service from mini-lang to groovy DSL (OFBIZ-11487)"

This reverts commit faa59b325fc50fc58b578c2b5d9b6d50d21b2478.

It introduced 3 errors in testIntegration, in:

testGlPostingOnCancelCheckRun

testGlPostingsOnVoidPayment

testVoidPayment

    • -0
    • +47
    ./minilang/payment/PaymentServices.xml
  1. … 2 more files in changeset.
Improved: Convert voidPayment service from mini-lang to groovy DSL (OFBIZ-11487)

Thanks: Sourabh Punyani

    • -47
    • +0
    ./minilang/payment/PaymentServices.xml
Improved: Updated case indentation to 0 for all switch statements in applications component. Also done formatting changes as per checkstyle best practices. (OFBIZ-11904)

  1. … 48 more files in changeset.
Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in applications component. (OFBIZ-11886)

  1. … 64 more files in changeset.
Improved: Use Error.ftl everywhere it's not yet used (OFBIZ-11890)

Removes all error*.jsp reference, no longer used

    • -26
    • +0
    ./webapp/accounting/error/error403.jsp
    • -26
    • +0
    ./webapp/accounting/error/error404.jsp
  1. … 16 more files in changeset.
Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in applications component. (OFBIZ-11887)

  1. … 97 more files in changeset.
Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in applications component. (OFBIZ-11880) Thanks Jacques for review.

  1. … 93 more files in changeset.
Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for applications component. (OFBIZ-11874) This fixes following checkstyle issues: '{' is not preceded with whitespace. '{' is not followed by whitespace. '}' is not followed by whitespace. '}' is not preceded with whitespace. 'typecast' is not followed by whitespace. 'try' is not followed by whitespace. ';' is preceded with whitespace.

  1. … 91 more files in changeset.
Improved: UI/UX issues found with Find Agreements screen(OFBIZ-10373)

Thanks, Aayush for the report and Pritam for the patch and Pierre for the review.

Improved: Convert getPaymentGroupReconciliationId service from mini-lang to groovy DSL (OFBIZ-11496) Thanks: Devanshu Vyas for report and Rohit Koushal for the patch

Improved: Convert createPaymentAndApplication service from mini-lang to groovy DSL (OFBIZ-11484)

Thanks: Devanshu Vyas for report and Anushi Gupta for the patch

Sorry due to a bad handling there are 2 commits in one (squashed)

    • -34
    • +0
    ./minilang/payment/PaymentServices.xml
Improved: Corrected all checkstyle issues related to succeeding space for comma in applications directory. (OFBIZ-11805) Thanks Jacques and Ritesh Kumar for review.

  1. … 41 more files in changeset.
Improved: Corrected remaining ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805)

  1. … 32 more files in changeset.
Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors in applications component. (OFBIZ-11805) Thanks Jacques Le Roux and Ritesh Kumar for review.

  1. … 40 more files in changeset.
Improved: Convert AutoPaymentTests.xml to Groovy (OFBIZ-11535)

Thanks, Rohit Hukkeri for report and Pawan Verma for review.

    • -560
    • +0
    ./minilang/test/AutoPaymentTests.xml
[Improved] Convert getInvoicePaymentInfoList service from mini-lang to groovy DSL (#148)

(OFBIZ-11485)

Done following:

- removed the mini-lang implementation of the service

- updated the service definition to point the groovy service

- added the groovy implementation of the service

    • -106
    • +0
    ./minilang/payment/PaymentServices.xml
Improved: Cannot find the declaration of element 'web-app' in version 3.0 files. (OFBIZ-6993)

I missed to backport changes web.xml (was OK in plugins)

  1. … 22 more files in changeset.
Improved: Convert AutoInvoiceTests.xml to Groovy (OFBIZ-11531)

Thanks, Rohit Hukkeri for the report.

    • -248
    • +0
    ./minilang/test/AutoInvoiceTests.xml
Improved: Convert getPayments service from mini-lang to groovy DSL(OFBIZ-11495)

Thanks: Devanshu for the report and Yogesh for the patch.

    • -20
    • +0
    ./minilang/payment/PaymentServices.xml
Improved: Convert cancelPaymentBatch service from mini-lang to groovy DSL(OFBIZ-11489)

Thanks: Devanshu for report, Kirti for patch and Jacques for the review.

    • -27
    • +0
    ./minilang/payment/PaymentServices.xml
Implemented: Convert voidPayment service from mini-lang to groovy DSL (OFBIZ-11487)

Thanks: Devanshu Vyas for report and Sourabh Punyani for implementation

    • -7
    • +0
    ./minilang/payment/PaymentServices.xml
Improved: Convert AutoAcctgTransTestsSales.xml to Groovy (OFBIZ-11526)

Thanks, Rohit Hukkeri for the report.

    • -52
    • +0
    ./minilang/test/AutoAcctgTransTestsPurchase.xml
    • -247
    • +0
    ./minilang/test/AutoAcctgTransTestsSales.xml