ofbiz-framework

Clone Tools
  • last updated 22 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved: Converted all TrackingCodeOrder related CRUD services from simple to entity-auto (#92)

* Improved: Converted all TrackingCodeOrder related CRUD services from simple to entity-auto

(OFBIZ-11625)

Improved: Converted all CustRequestParty related CRUD services from simple to entity-auto (#95)

* Improved: Converted all CustRequestParty related CRUD services from simple to entity-auto

(OFBIZ-11621)

    • -0
    • +27
    /applications/order/servicedef/secas.xml
Fixed: PartyProfileContent.js does not work

(OFBIZ-11633)

When you upload a content from the party profile page you don't see a progress

bar. The PartyProfileContent.js is loaded but for some reason is unused or wrong

Mohammad Kathawala mentionned that it was removed with OFBIZ-9299

It was also broken with OFBIZ-11402

Thanks: Mohammad for the track

Conflicts

removed framework/common/groovyScripts/CommonServices.groovy

Fixed: PartyProfileContent.js does not work

(OFBIZ-11633)

When you upload a content from the party profile page you don't see a progress

bar. The PartyProfileContent.js is loaded but for some reason is unused or wrong

Mohammad Kathawala mentionned that it was removed with OFBIZ-9299

It was also broken with OFBIZ-11402

Thanks: Mohammad for the track

Conflicts handled by hand

applications/party/template/party/profileblocks/Content.ftl

framework/common/groovyScripts/CommonServices.groovy

    • -0
    • +36
    /framework/common/groovyScripts/CommonServices.groovy
Fixed: PartyProfileContent.js does not work

(OFBIZ-11633)

When you upload a content from the party profile page you don't see a progress

bar. The PartyProfileContent.js is loaded but for some reason is unused or wrong

Mohammad Kathawala mentionned that it was removed with OFBIZ-9299

It was also broken with OFBIZ-11402

Thanks: Mohammad for the track

Improved: Converted all TimesheetRole related CRUD services from simple to entity-auto (#90)

* Improved: Converted all TimesheetRole related CRUD services from simple to entity-auto

(OFBIZ-11617)

Improved: All the service level error messages for missing required field for order component (#86)

* Improved: All the service level error messages for missing required field for order component

(OFBIZ-7736)

Thanks Ratnesh Upadhyay for reporting and Ankush Upadhyay for providing the updated patch

Improved: Converted all TrackingCodeOrderReturn related CRUD services from simple to entity-auto (#89)

* Improved: Converted all TrackingCodeOrderReturn related CRUD services from simple to entity-auto

(OFBIZ-11623)

Improved: Converted all FixedAssetMeter services from simple to entity-auto. (#82)

* Improved: Converted all FixedAssetMeter services from simple to entity-auto.

* Improved: Added seca rule for creating maints from meter reading, earlier it was called inline while creating or updating FixedAssetMeter record.

(OFBIZ-11611)

Improved: Converted all TrackingCodeType entities from simple to entity-auto (#87)

* Improved: Converted all TrackingCodeType entities from simple to entity-auto

(OFBIZ-11615)

Improved: Added missing attribute default-entity-name for ShipmentReceiptRole entity auto services. (OFBIZ-11614) Thanks Pawan for reporting.

Improved: Used utility provided by OFBizTestCase class for userLogin instead of fetching from DB test cases also removed unused fetching of userLogin in some cases (OFBIZ-11618)

Improved: Converted all ShipmentReceiptRole service from crud to entity-auto (#85)

* Improved: Converted all ShipmentReceiptRole service from crud to entity-auto

(OFBIZ-11614)

Fixed: Incorrect value in entity-auto invoke for removeProductFeatureDataResource. (OFBIZ-11614)

It was may be a typo introduced in rev 1728261, fifty months ago.

Fixed: Incorrect value in entity-auto invoke for removeProductFeatureDataResource. (OFBIZ-11614)

It was may be a typo introduced in rev 1728261, fifty months ago.

Improved: Currency Data for China

(OFBIZ-11629)

improved description

    • -1
    • +1
    /framework/common/data/CurrencyData.xml
Improved: Tax Authority Data for China

(OFBIZ-11628)

added party and tax authority data for China

Improved: Converted all EntitySyncInclude services from simple to entity-auto (#84)

* Improved: Converted all EntitySyncInclude services from simple to entity-auto

(OFBIZ-11613)

Improved: Converted cancelFixedAssetStdCost service from simple to entity-auto. (#80)

* Improved: Converted cancelFixedAssetStdCost service from simple to entity-auto.

(OFBIZ-11612)

Improved: Sales Invoice creation should be limited for customer parties only. (OFBIZ-11023) Thanks Pierre Smits for reporting and Rohit Hukkeri for the patch

    • -1
    • +1
    /applications/accounting/widget/InvoiceForms.xml
Improved: Use userLogin available in context instead of fetching from DB in Groovy test cases (OFBIZ-11618)

Thanks: Jacques for the review.

Improved: Updated hard coded values of location types and used all available location enums instead. (OFBIZ-6042) Thanks Pierre for reporting and Jacques Le Roux for review.

Improved: Added support for EntityQuery methods in OFBiz integration tests. (OFBIZ-11247)

Thanks: Jacques for the review.

Fixed: The producttests test suite is brooken (OFBIZ-11620)

Corrected Class name and ProductAssoc entity name.

Thanks: Jacques for the partial fix.

Fixed: The producttests test suite is brooken

(OFBIZ-11620)

It was initially broken by OFBIZ-9905 so only trunk was concerned.

The fix is simple: there should be no space at the beginning of the file.

But then, when running the test suite, other issues raise.

I guess they were hidden because of the initial issue.

OFBIZ-10231 introduced 2 issues

A syntax error:

product.removeRelated("ProductKeyword", product)

instead of

product.removeRelated("ProductKeyword")

A wrong usage of storeByCondition

This fixes the 3 issues, to test:

gradlew "ofbiz --test component=product --test suitename=producttests"

Thanks: Pawan for initial report

Fixed: "entity/list" request is not handled well

(OFBIZ-11593)

The "entity/list" request has been put in with OFBIZ-11007. It's used to call

the entitymaint view and so is a demo/didactic duplicate of entitymaint request.

It's only used in FindGeneric screen (look for WebtoolsBackToEntityList label).

It's problematic because since the CSRF token defense was put in you can no

longer filter the entities from the entities list screen, even when the default

NoCsrfDefenseStrategy is used. It works if you use the entitymaint request

instead.

2020-01-19 I proposed in OFBIZ-11306 a solution for such cases.

It was not used because 2020-02-14 I thought it was no longer needed.

It was necessary for this case and implemented with commit e487122.

But as, Rohit Koushal reported, it breaks some functionalities like adding

address/update address during Quick Finalize Order. The issue can also be

reproduced in ecommerce when trying the same while checking out, or quick

checking out, an order.

More generally the error is of this kind:

|27.0.0.1-8009-exec-3 |ControlServlet |E| Error in request handler:

java.lang.IndexOutOfBoundsException: Index: 1, Size: 1

at java.util.LinkedList.checkElementIndex(LinkedList.java:555) ~[?:1.8.0_252]

at java.util.LinkedList.get(LinkedList.java:476) ~[?:1.8.0_252]

at org.apache.ofbiz.webapp.control.RequestHandler.getRequestUri(RequestHandler.java:837) ~[main/:?]

and happens with URLs like

updateCheckoutOptions/editcontactmech?DONE_PAGE=checkoutoptions&contactMechId=9015

or

updateCheckoutOptions/editcontactmech?preContactMechTypeId=POSTAL_ADDRESS&

contactMechPurposeTypeId=SHIPPING_LOCATION&DONE_PAGE=checkoutoptions

So I decided to revert the concerned part of commit e487122 and to rather use

entitymaint instead of "entity/list" request.

Removed: Duplicate getRelatedParties service definition. It was left during the service conversion from XML to Groovy (OFBIZ-11361)

Thanks: Rohit Kaushal for the report.

Removed: Unwanted character mistakely added during All the service level error messages for missing required field for party component.

Incorrect column alias in EntitySQLProcessor for sql query working with mysql (OFBIZ-11573)

More details: Method getColumnLabel returns the designated column's suggested title for use in printouts and displays. Method getColumnName returns the designated column's name.

Thanks: Suraj and Jacques for the review.

Incorrect column alias in EntitySQLProcessor for sql query working with mysql (OFBIZ-11573)

More details: Method getColumnLabel returns the designated column's suggested title for use in printouts and displays. Method getColumnName returns the designated column's name.

Thanks: Suraj and Jacques for the review.