ofbiz-framework

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Revert "Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail for CommunicationEvent.subject field" (OFBIZ-10879)

This reverts commit 9706acf064e26c291c0bd10081df8286ae6b359b.

Revert "Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail for CommunicationEvent.subject field" (OFBIZ-10879)

This reverts commit bbcc4692dccdf573aa0205f927b56bc271719031.

Revert "Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail for CommunicationEvent.subject field" (OFBIZ-10879)

This reverts commit 832076ce91dbca182ffab38d27ea72ca5e2cb0be.

Fixed: Cannot run ComponentContainerTest on windows (OFBIZ-11331)

Running ComponentContainerTest on windows fails due to parsing of paths of the

form '/c:/dev/....'

org.apache.ofbiz.base.container.ComponentContainerTest >

testCheckDependencyForComponent FAILED

java.nio.file.InvalidPathException at ComponentContainerTest.java:44

Line 44:

private Path ofbizHome = Paths.get(ComponentContainerTest.class.getResource

("testsdata").getFile()).toAbsolutePath().normalize();

PR created: #8

Thanks: Daniel WatfordNina Simone - My Baby Just Cares For Me.mp3

Fixed: Change 'restMethod' by '_method' in request parameters (OFBIZ-11007)

Some issue has been introduce on the previous commit 6e1c7b5 [1], corrected by this one :

* the view link on ListGeneric failed

* the paginate on ListGeneric failed

I also simplify the url writing with delegate the entity path generation and translation

to two function on EntityUtil : entityToPath and getPkValuesMapFromPath

thanks to Pawan Verma to spot the pagination problem

[1] https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6e1c7b5

Improved: Change 'restMethod' by '_method' in request parameters (OFBIZ-11332)

When we analyse a request method, we currently check the parameter "restMethod".

Mathieu Lirzin propose [1] to use "_method" instead to use a parameter name more generic

I create a new function UtilHttp.getRequestMethod() to centralize the request method resolution.

[1] https://issues.apache.org/jira/browse/OFBIZ-11007?focusedCommentId=17012712&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17012712

OFBIZ-11331: Allow ComponentContainerTest to run on windows (#8)

* Get Path from URI than a string representation of a file path when building Path to test resources.

* Removed unused test imports.

Fixed: No functional change, correct checkstyle issues on GenericWebEvent.java

Removed unused test imports.

Get Path from URI than a string representation of a file path when building Path to test resources.

Fixed: Fixed the issue on party page that will upload the data each time after refreshing the page. (OFBIZ-11325)

Earlier 'view' response type is used on the request that cause the issue.

We need to use request-redirect response type along with the required

redirect-parameter instead of view response type, i.e. We need to

request-redirect on viewProfile along with partyId as redirect-parameter.

Thanks: Humera Khan

Fixed: Fixed the issue on party page that will upload the data each time after refreshing the page. (OFBIZ-11325)

Earlier 'view' response type is used on the request that cause the issue.

We need to use request-redirect response type along with the required

redirect-parameter instead of view response type, i.e. We need to

request-redirect on viewProfile along with partyId as redirect-parameter.

Thanks: Humera Khan

Fixed: Fixed the issue on party page that will upload the data each time after refreshing the page. (OFBIZ-11325)

Earlier 'view' response type is used on the request that cause the issue.

We need to use request-redirect response type along with the required

redirect-parameter instead of view response type, i.e. We need to

request-redirect on viewProfile along with partyId as redirect-parameter.

Thanks: Humera Khan

Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail for CommunicationEvent.subject field (OFBIZ-10879)

CommunicationEventServices#updateCommEventAfterEmail could generate wrong result. If general.properties value 'mail.notifications.redirectTo' is used, it is possible that the subject string has more than 255 character.

Thanks, Ulrich Heidfeld for your contribution.

Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail for CommunicationEvent.subject field (OFBIZ-10879)

CommunicationEventServices#updateCommEventAfterEmail could generate wrong result. If general.properties value 'mail.notifications.redirectTo' is used, it is possible that the subject string has more than 255 character.

Thanks, Ulrich Heidfeld for your contribution.

Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail for CommunicationEvent.subject field (OFBIZ-10879)

CommunicationEventServices#updateCommEventAfterEmail could generate wrong result. If general.properties value 'mail.notifications.redirectTo' is used, it is possible that the subject string has more than 255 character.

Thanks, Ulrich Heidfeld for your contribution.

Fixed: Same content uploaded twice, if refresh the page after uploading the content (OFBIZ-11171)

Thanks, Humera Khan and Shubham Goswami for your contribution.

Fixed: Same content uploaded twice, if refresh the page after uploading the content (OFBIZ-11171)

Thanks, Humera Khan and Shubham Goswami for your contribution.

Fixed: Same content uploaded twice, if refresh the page after uploading the content (OFBIZ-11171)

Thanks, Humera Khan and Shubham Goswami for your contribution.

Fixed: Order Status History section broken for anonymous order (OFBIZ-11231)

Reason for the issue: Anonymous orders doen't have associated User login record, so shown statusUserLogin in that case.

Fixed: Order Status History section broken for anonymous order (OFBIZ-11231)

Reason for the issue: Anonymous orders doen't have associated User login record, so shown statusUserLogin in that case.

Fixed: Order Status History section broken for anonymous order (OFBIZ-11231)

Reason for the issue: Anonymous orders doen't have associated User login record, so shown statusUserLogin in that case.

Improved: Use FlexibleStringExpander for field parameter names. (OFBIZ-11330)

Allows generation of unique names when repeating rendering of a form on a screen.

Added test cases to ensure parameter names can be built using FlexibleStringExpander.

Amend previous by removing a typo:

Improved: no functional change

After 12 years being unperceived I suddenly wondered about the world "default"

at the right of the connection and main Webtools screen.

It was added by OFBIZ-914, and missed a label, here it is.

Improved: no functional change

After 12 years being unperceived I suddenly wondered about the world "default"

at the right of the connection and main Webtools screen.

It was added by OFBIZ-914, and missed a label, here it is.

    • -0
    • +12
    /framework/webtools/config/WebtoolsUiLabels.xml
Fixed: updatePassword does not save optional parameter requirePasswordChange (OFBIZ-11320)

When changing the password of a User Login through the Party Manager the Require Password Change dropdown menu selection does not save the selected value. The corresponding process is missing from the LoginMapProcs.xml.

Thanks: Ingo Könemann for your contribution.

Fixed: updatePassword does not save optional parameter requirePasswordChange (OFBIZ-11320)

When changing the password of a User Login through the Party Manager the Require Password Change dropdown menu selection does not save the selected value. The corresponding process is missing from the LoginMapProcs.xml.

Thanks: Ingo Könemann for your contribution.

Fixed: updatePassword does not save optional parameter requirePasswordChange (OFBIZ-11320)

When changing the password of a User Login through the Party Manager the Require Password Change dropdown menu selection does not save the selected value. The corresponding process is missing from the LoginMapProcs.xml.

Thanks: Ingo Könemann for your contribution.

Improved: Add 'controlPath' attribute to 'ofbizUrl' freemarker macro

(OFBIZ-11317)

Adding the controlPath attribute to allow the controls by ofbizUrl to support uri to other OFBiz web application.

Thanks: Jacques for the review

  1. … 46 more files in changeset.
Fixed: Bug when order contains adjustments with NULL amount (OFBIZ-11316)

The issue was introduced by OFBIZ-7012 where adding isTaxIncludedInPrice was

missing at line 565. Because the compared amount in this line (in the adjustment)

is different from 0 and equals to amountAlreadyIncluded only if

the tax is included in price

Thanks: Amine Azzi