ofbiz-framework

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed: setUserTimeZone should ran only once based on error (OFBIZ-11329)

This will be notably useful when committing CSRF solution as explained in

OFBIZ-11306:

SetTimeZoneFromBrowser when starting gives a RequestHandlerException:

Invalid or missing CSRF token for AJAX call to path '/SetTimeZoneFromBrowser'.

Also not only when starting.

Thanks: James Yong for review

(cherry picked from commit 350c71f4df45cbe5671b54e61f74f9a352d78e05)

# Conflicts:

# framework/common/groovyScripts/SetLocaleFromBrowser.groovy

# themes/common-theme/webapp/common/js/util/setUserTimeZone.js replaced

by setUserLocale.js modified by hand

I can compile locally but I can see a reason why and certainly not related to

these changes

Fixed: setUserTimeZone should ran only once based on error (OFBIZ-11329)

This will be notably useful when committing CSRF solution as explained in

OFBIZ-11306:

SetTimeZoneFromBrowser when starting gives a RequestHandlerException:

Invalid or missing CSRF token for AJAX call to path '/SetTimeZoneFromBrowser'.

Also not only when starting.

Thanks: James Yong for review

Fixed: impersonateLogin (OFBIZ-5409)

I reopended this old issue because, while working on OFBIZ-11329, I found that

userLogin and impersonateLogin should be removed from

jsonResponseFromRequestAttributes

Thanks: James Yong for pointing that out

Fixed: impersonateLogin (OFBIZ-5409)

I reopended this old issue because, while working on OFBIZ-11329, I found that

userLogin and impersonateLogin should be removed from

jsonResponseFromRequestAttributes

Thanks: James Yong for pointing that out

# Conflicts:

# framework/common/src/main/java/org/apache/ofbiz/common/CommonEvents.java

Fixed: impersonateLogin (OFBIZ-5409)

I reopended this old issue because, while working on OFBIZ-11329, I found that

userLogin and impersonateLogin should be removed from

jsonResponseFromRequestAttributes

Thanks: James Yong for pointing that out

Improved: no functional change

Fixed Javadoc creation issue reported at INFRA-19807

Thanks: Chris Lambertus

Documented: Financial Account Help Docbook file migration to asciidoc format (OFBIZ-10296)

All the new files are now included in the Financial Account

documentation presentation, at the end in a sub-chapter Financial

Account management in User Interface.

  1. … 21 more files in changeset.
Improvement: German translation improvements in HumanResUiLabels (OFBIZ-11134)

Thanks Ulrich Heidfeld for reporting and providing the patch.

Improvement: German translation improvements in HumanResUiLabels (OFBIZ-11134)

Thanks Ulrich Heidfeld for reporting and providing the patch.

Update README

Rectified broken link for Known Issues

Current link points to a Page Not Found in Confluence

(cherry picked from commit b35cd8a1534b3563f60e789626fb61793d6d8694)

Improved: Translate invoice type dropdown (OFBIZ-10191)

Thanks Ingo Wolfmayr for reporting and providing the patch.

    • -2
    • +2
    /applications/accounting/widget/InvoiceForms.xml
Improvement: German translation improvements in HumanResUiLabels (OFBIZ-11134)

Thanks Ulrich Heidfeld for reporting and providing the patch.

Multi Part Input Parameters not Available in Groovy Event (OFBIZ-5048)

This change provides easier access to the FileItem by not wrapping it

into a buffer.

Multi Part Input Parameters not Available in Groovy Event (OFBIZ-5048)

This change provides easier access to the FileItem by not wrapping it

into a buffer.

Multi Part Input Parameters not Available in Groovy Event (OFBIZ-5048)

This change provides easier access to the FileItem by not wrapping it

into a buffer.

Extend UtilHttp.urlEncodeArgs API with preserveEmpty-parameter (OFBIZ-10198)

This patch extends the current UtilHttp.urlEncodeArgs() method with an

additional input parameter: boolean preserveEmpty.

It allows to get a query string with empty parameters, useful if the

receiver expects mandatory parameters or wants to explicit

override/clear existing values with an empty one.

Thanks Martin Becker for reporting and providing the patch.

Improved: Remove unnecessary header-row classes in Upcoming.ftl (OFBIZ-11305)

Thanks Dennis Balkir for reporting an providing the patch.

Improved: ‘EntityOperator#getId()’ is not used in the framework (OFBIZ-10607)

Thanks Mathieu Lirzin for reporting and providing the patch.

Improved: ‘EntityOperator#getId()’ is not used in the framework (OFBIZ-10607)

Thanks Mathieu Lirzin for reporting and providing the patch.

Improved: Add Asciidoc template for plugin creation task (OFBIZ-10322)

Create a README.adoc stub and help file stub in the new format under

framework/resources/templates and use in the plugin creation task.

Thanks Ulrich Heidfeld for providing the patch.

    • -0
    • +1
    /framework/resources/templates/HELP.adoc
    • -0
    • +3
    /framework/resources/templates/README.adoc
Fixed: German translation typo in PartyUiLabels (OFBIZ-11308)

Thanks: Ingo Könemann for reporting and providing the patch.

Fixed: German translation typo in PartyUiLabels (OFBIZ-11308)

Thanks: Ingo Könemann for reporting and providing the patch.

Documented: Agreement Help Docbook file migration to asciidoc format (OFBIZ-10290)

All the new files are now included in the Agreement documentation

presentation, at the end in a sub-chapter Agreement management in User

Interface.

  1. … 19 more files in changeset.
Fixed: Clean unecessary code and convert to groovy syntax

No functional change

The code present on ViewGeneric.groovy has been migrated from bsh script

without deep rewrite.

I removed all unecessary or redund code to lighten the reading

Revert "Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail for CommunicationEvent.subject field" (OFBIZ-10879)

This reverts commit 9706acf064e26c291c0bd10081df8286ae6b359b.

Revert "Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail for CommunicationEvent.subject field" (OFBIZ-10879)

This reverts commit bbcc4692dccdf573aa0205f927b56bc271719031.

Revert "Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail for CommunicationEvent.subject field" (OFBIZ-10879)

This reverts commit 832076ce91dbca182ffab38d27ea72ca5e2cb0be.

Fixed: Cannot run ComponentContainerTest on windows (OFBIZ-11331)

Running ComponentContainerTest on windows fails due to parsing of paths of the

form '/c:/dev/....'

org.apache.ofbiz.base.container.ComponentContainerTest >

testCheckDependencyForComponent FAILED

java.nio.file.InvalidPathException at ComponentContainerTest.java:44

Line 44:

private Path ofbizHome = Paths.get(ComponentContainerTest.class.getResource

("testsdata").getFile()).toAbsolutePath().normalize();

PR created: #8

Thanks: Daniel WatfordNina Simone - My Baby Just Cares For Me.mp3

Fixed: Change 'restMethod' by '_method' in request parameters (OFBIZ-11007)

Some issue has been introduce on the previous commit 6e1c7b5 [1], corrected by this one :

* the view link on ListGeneric failed

* the paginate on ListGeneric failed

I also simplify the url writing with delegate the entity path generation and translation

to two function on EntityUtil : entityToPath and getPkValuesMapFromPath

thanks to Pawan Verma to spot the pagination problem

[1] https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6e1c7b5

Improved: Change 'restMethod' by '_method' in request parameters (OFBIZ-11332)

When we analyse a request method, we currently check the parameter "restMethod".

Mathieu Lirzin propose [1] to use "_method" instead to use a parameter name more generic

I create a new function UtilHttp.getRequestMethod() to centralize the request method resolution.

[1] https://issues.apache.org/jira/browse/OFBIZ-11007?focusedCommentId=17012712&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17012712