ofbiz-framework

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed: Unable to continue to Step 3 in One Page Checkout (OFBIZ-11318)

The following error is returned when trying to continue to Step3 when checking

out using One Page Checkout.

Could not create new purpose, a purpose with that type already exists.:

[GenericEntity:PartyContactWithPurpose][contactFromDate,2020-01-05 19:48:18.29

(java.sql.Timestamp)][contactMechId,10020(java.lang.String)]

[contactMechPurposeTypeId,SHIPPING_LOCATION(java.lang.String)]

[partyId,admin(java.lang.String)][purposeFromDate,2020-01-05 19:48:18.332

(java.sql.Timestamp)

It does not happen with DemoCustomer but at least with admin user

It was caused by OFBIZ-10588. I checked for similar issues and found that, in

unlike in createUpdateBillingAddress, in createUpdateShippingAddress and

createUpdateCreditCard partyId was used without a prior setting from

parameters.partyId

Thanks: James Young for proposing a solution. I rather fixed otherwise this and

another similar case in createUpdateCreditCard

Documented: Invoice Docbook files migration to asciidoc format (OFBIZ-10292)

All the help files associated to it are called via include in the main

document

  1. … 6 more files in changeset.
Fixed: Crashed Scheduled jobs are not getting rescheduled with temporal expression (OFBIZ-11340)

When a OFBiz server are stopped or crashed with job on queued state,

at the start, they are restarted but without information on tempExprId and recurrenceInfoId

This causes a break for recurrence jobs to their planning

Thanks to Mohammed Rehan Khan for this issue and Scott Gray for the review.

Fixed: Crashed Scheduled jobs are not getting rescheduled with temporal expression (OFBIZ-11340)

When a OFBiz server are stopped or crashed with job on queued state,

at the start, they are restarted but without information on tempExprId and recurrenceInfoId

This causes a break for recurrence jobs to their planning

Thanks to Mohammed Rehan Khan for this issue and Scott Gray for the review.

Fixed: Crashed Scheduled jobs are not getting rescheduled with temporal expression (OFBIZ-11340)

When a OFBiz server are stopped or crashed with job on queued state,

at the start, they are restarted but without information on tempExprId and recurrenceInfoId

This causes a break for recurrence jobs to their planning

Thanks to Mohammed Rehan Khan for this issue and Scott Gray for the review.

Fixed: correct check style issue on ComponentContainerTest.java

No functionnal change

Fixed: Prevent possible NullPointerException in FinAccountServices. (OFBIZ-11341)

Documented: Global GL Setting Help Docbook file migration to asciidoc format (OFBIZ-10297)

All the new files are now included in the Global Gl Setting

documentation presentation, each of the three Help file are included in

the concerning sub-chapter.

  1. … 3 more files in changeset.
Fixed: setUserTimeZone should ran only once based on error (OFBIZ-11329)

This will be notably useful when committing CSRF solution as explained in

OFBIZ-11306:

SetTimeZoneFromBrowser when starting gives a RequestHandlerException:

Invalid or missing CSRF token for AJAX call to path '/SetTimeZoneFromBrowser'.

Also not only when starting.

Thanks: James Yong for review

Fixed: setUserTimeZone should ran only once based on error (OFBIZ-11329)

This will be notably useful when committing CSRF solution as explained in

OFBIZ-11306:

SetTimeZoneFromBrowser when starting gives a RequestHandlerException:

Invalid or missing CSRF token for AJAX call to path '/SetTimeZoneFromBrowser'.

Also not only when starting.

Thanks: James Yong for review

(cherry picked from commit 350c71f4df45cbe5671b54e61f74f9a352d78e05)

# Conflicts:

# framework/common/groovyScripts/SetLocaleFromBrowser.groovy

# themes/common-theme/webapp/common/js/util/setUserTimeZone.js replaced

by setUserLocale.js modified by hand

I can compile locally but I can see a reason why and certainly not related to

these changes

Fixed: setUserTimeZone should ran only once based on error (OFBIZ-11329)

This will be notably useful when committing CSRF solution as explained in

OFBIZ-11306:

SetTimeZoneFromBrowser when starting gives a RequestHandlerException:

Invalid or missing CSRF token for AJAX call to path '/SetTimeZoneFromBrowser'.

Also not only when starting.

Thanks: James Yong for review

Fixed: impersonateLogin (OFBIZ-5409)

I reopended this old issue because, while working on OFBIZ-11329, I found that

userLogin and impersonateLogin should be removed from

jsonResponseFromRequestAttributes

Thanks: James Yong for pointing that out

Fixed: impersonateLogin (OFBIZ-5409)

I reopended this old issue because, while working on OFBIZ-11329, I found that

userLogin and impersonateLogin should be removed from

jsonResponseFromRequestAttributes

Thanks: James Yong for pointing that out

# Conflicts:

# framework/common/src/main/java/org/apache/ofbiz/common/CommonEvents.java

Fixed: impersonateLogin (OFBIZ-5409)

I reopended this old issue because, while working on OFBIZ-11329, I found that

userLogin and impersonateLogin should be removed from

jsonResponseFromRequestAttributes

Thanks: James Yong for pointing that out

Improved: no functional change

Fixed Javadoc creation issue reported at INFRA-19807

Thanks: Chris Lambertus

Documented: Financial Account Help Docbook file migration to asciidoc format (OFBIZ-10296)

All the new files are now included in the Financial Account

documentation presentation, at the end in a sub-chapter Financial

Account management in User Interface.

  1. … 21 more files in changeset.
Improvement: German translation improvements in HumanResUiLabels (OFBIZ-11134)

Thanks Ulrich Heidfeld for reporting and providing the patch.

Improvement: German translation improvements in HumanResUiLabels (OFBIZ-11134)

Thanks Ulrich Heidfeld for reporting and providing the patch.

Update README

Rectified broken link for Known Issues

Current link points to a Page Not Found in Confluence

(cherry picked from commit b35cd8a1534b3563f60e789626fb61793d6d8694)

Improved: Translate invoice type dropdown (OFBIZ-10191)

Thanks Ingo Wolfmayr for reporting and providing the patch.

    • -2
    • +2
    /applications/accounting/widget/InvoiceForms.xml
Improvement: German translation improvements in HumanResUiLabels (OFBIZ-11134)

Thanks Ulrich Heidfeld for reporting and providing the patch.

Multi Part Input Parameters not Available in Groovy Event (OFBIZ-5048)

This change provides easier access to the FileItem by not wrapping it

into a buffer.

Multi Part Input Parameters not Available in Groovy Event (OFBIZ-5048)

This change provides easier access to the FileItem by not wrapping it

into a buffer.

Multi Part Input Parameters not Available in Groovy Event (OFBIZ-5048)

This change provides easier access to the FileItem by not wrapping it

into a buffer.

Extend UtilHttp.urlEncodeArgs API with preserveEmpty-parameter (OFBIZ-10198)

This patch extends the current UtilHttp.urlEncodeArgs() method with an

additional input parameter: boolean preserveEmpty.

It allows to get a query string with empty parameters, useful if the

receiver expects mandatory parameters or wants to explicit

override/clear existing values with an empty one.

Thanks Martin Becker for reporting and providing the patch.

Improved: Remove unnecessary header-row classes in Upcoming.ftl (OFBIZ-11305)

Thanks Dennis Balkir for reporting an providing the patch.

Improved: ‘EntityOperator#getId()’ is not used in the framework (OFBIZ-10607)

Thanks Mathieu Lirzin for reporting and providing the patch.

Improved: ‘EntityOperator#getId()’ is not used in the framework (OFBIZ-10607)

Thanks Mathieu Lirzin for reporting and providing the patch.

Improved: Add Asciidoc template for plugin creation task (OFBIZ-10322)

Create a README.adoc stub and help file stub in the new format under

framework/resources/templates and use in the plugin creation task.

Thanks Ulrich Heidfeld for providing the patch.

    • -0
    • +1
    /framework/resources/templates/HELP.adoc
    • -0
    • +3
    /framework/resources/templates/README.adoc
Fixed: German translation typo in PartyUiLabels (OFBIZ-11308)

Thanks: Ingo Könemann for reporting and providing the patch.