ofbiz

Checkout Tools
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
"Applied fix from trunk framework for revision: 1867099"

------------------------------------------------------------------------

r1867099 | jleroux | 2019-09-18 09:29:18 +0200 (mer. 18 sept. 2019) | 17 lignes

Fixed: Error in log when looking for parties at partymgr/control/main

(OFBIZ-11201)

There is this a (long stack trace) error in log (only), mostly

java.lang.ClassCastException: java.util.ArrayList cannot be cast to java.util.Map

at org.apache.ofbiz.base.util.string.UelFunctions.getSize(UelFunctions.java:318)

I did not notice any other effect, so the fix only cleans the log.

It's actually an issue in ListParty grid with this line:

<set field="userLoginSize" value="${util:size(logins)}" type="Integer"/>

This fixes it by replacing by

<set field="userLoginSize" value="${groovy:logins.size()}"/>

------------------------------------------------------------------------

?\026

"Applied fix from trunk for revision: 1867099"

------------------------------------------------------------------------

r1867099 | jleroux | 2019-09-18 09:29:18 +0200 (mer. 18 sept. 2019) | 17 lignes

Fixed: Error in log when looking for parties at partymgr/control/main

(OFBIZ-11201)

There is this a (long stack trace) error in log (only), mostly

java.lang.ClassCastException: java.util.ArrayList cannot be cast to java.util.Map

at org.apache.ofbiz.base.util.string.UelFunctions.getSize(UelFunctions.java:318)

I did not notice any other effect, so the fix only cleans the log.

It's actually an issue in ListParty grid with this line:

<set field="userLoginSize" value="${util:size(logins)}" type="Integer"/>

This fixes it by replacing by

<set field="userLoginSize" value="${groovy:logins.size()}"/>

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1867099"

------------------------------------------------------------------------

r1867099 | jleroux | 2019-09-18 09:29:18 +0200 (mer. 18 sept. 2019) | 17 lignes

Fixed: Error in log when looking for parties at partymgr/control/main

(OFBIZ-11201)

There is this a (long stack trace) error in log (only), mostly

java.lang.ClassCastException: java.util.ArrayList cannot be cast to java.util.Map

at org.apache.ofbiz.base.util.string.UelFunctions.getSize(UelFunctions.java:318)

I did not notice any other effect, so the fix only cleans the log.

It's actually an issue in ListParty grid with this line:

<set field="userLoginSize" value="${util:size(logins)}" type="Integer"/>

This fixes it by replacing by

<set field="userLoginSize" value="${groovy:logins.size()}"/>

------------------------------------------------------------------------

Fixed: Error in log when looking for parties at partymgr/control/main

(OFBIZ-11201)

There is this a (long stack trace) error in log (only), mostly

java.lang.ClassCastException: java.util.ArrayList cannot be cast to java.util.Map

at org.apache.ofbiz.base.util.string.UelFunctions.getSize(UelFunctions.java:318)

I did not notice any other effect, so the fix only cleans the log.

It's actually an issue in ListParty grid with this line:

<set field="userLoginSize" value="${util:size(logins)}" type="Integer"/>

This fixes it by replacing by

<set field="userLoginSize" value="${groovy:logins.size()}"/>

"Applied fix from trunk for revision: 1867038"

------------------------------------------------------------------------

r1867038 | jleroux | 2019-09-17 08:32:20 +0200 (mar. 17 sept. 2019) | 11 lignes

Documented:

Got this error with Eclipse Asciidoctor editor plugin

>> rendering:-273312131_hidden-editorfile_developer-manual.adoc

asciidoctor: WARNING: C:/projectsASF/ofbiz/framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc: line 473: unterminated listing block

asciidoctor: WARNING: C:/projectsASF/ofbiz/framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc: line 511: unterminated listing block

This fixes it

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1867038"

------------------------------------------------------------------------

r1867038 | jleroux | 2019-09-17 08:32:20 +0200 (mar. 17 sept. 2019) | 11 lignes

Documented:

Got this error with Eclipse Asciidoctor editor plugin

>> rendering:-273312131_hidden-editorfile_developer-manual.adoc

asciidoctor: WARNING: C:/projectsASF/ofbiz/framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc: line 473: unterminated listing block

asciidoctor: WARNING: C:/projectsASF/ofbiz/framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc: line 511: unterminated listing block

This fixes it

------------------------------------------------------------------------

Documented:

Got this error with Eclipse Asciidoctor editor plugin

>> rendering:-273312131_hidden-editorfile_developer-manual.adoc

asciidoctor: WARNING: C:/projectsASF/ofbiz/framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc: line 473: unterminated listing block

asciidoctor: WARNING: C:/projectsASF/ofbiz/framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc: line 511: unterminated listing block

This fixes it

"Applied fix from trunk framework for revision: 1866986"

------------------------------------------------------------------------

r1866986 | jleroux | 2019-09-16 10:20:46 +0200 (lun. 16 sept. 2019) | 4 lignes

Fixed: Path Traversal in webtools/control/FetchLogs and ViewFile

(OFBIZ-11196)

Fixes a typo which was crashing webtools/control/LogView

------------------------------------------------------------------------

?\026

"Applied fix from trunk for revision: 1866986"

------------------------------------------------------------------------

r1866986 | jleroux | 2019-09-16 10:20:46 +0200 (lun. 16 sept. 2019) | 4 lignes

Fixed: Path Traversal in webtools/control/FetchLogs and ViewFile

(OFBIZ-11196)

Fixes a typo which was crashing webtools/control/LogView

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1866986"

------------------------------------------------------------------------

r1866986 | jleroux | 2019-09-16 10:20:46 +0200 (lun. 16 sept. 2019) | 4 lignes

Fixed: Path Traversal in webtools/control/FetchLogs and ViewFile

(OFBIZ-11196)

Fixes a typo which was crashing webtools/control/LogView

------------------------------------------------------------------------

Fixed: Path Traversal in webtools/control/FetchLogs and ViewFile

(OFBIZ-11196)

Fixes a typo which was crashing webtools/control/LogView

Fixed: Fix Default or Empty Catch block in Java and Groovy files

(OFBIZ-8341)

In many Java and Groovy files we have auto generated catch blocks or empty catch

blocks.

To avoid such exception swallowing this should be improved to at least log the

error and also return error in case of service.

Missed this one in last commit

Improved: Use spaces instead of tabs in “common.gradle”

Thanks: Samuel Trégouët for your contribution

Improved: Don't exclude properties and labels file from the Jar

(OFBIZ-11161)

In order to have an independent deployable jar, we need to include the

properties and labels inside the jar.

The properties and labels file was previously excluded from the jar

because it was not possible to replace the compile time values by

invalidating OFBiz caches which is convenient when developing

OFBiz. It was then necessary to reconstruct the jar and restart

OFBiz (See OFBIZ-8321 for more details).

With the recent improvment from revision 1865719 allowing to run OFBiz

without building a jar, it is now possible to enable this cache

invalidation by running both ‘gradle run’ in one shell and ‘gradlew

--continuous classes’ in a separate shell. Doing so make the

combination of editing the label files and clearing the caches use

the new value defined in the source file.

Fixed: Fix Default or Empty Catch block in Java and Groovy files

(OFBIZ-)

In many Java and Groovy files we have auto generated catch blocks or empty catch

blocks.

To avoid such exception swallowing this should be improved to at least log the

error and also return error in case of service.

Last ones :)

Fixed: Fix Default or Empty Catch block in Java and Groovy files

(OFBIZ-)

In many Java and Groovy files we have auto generated catch blocks or empty catch

blocks.

To avoid such exception swallowing this should be improved to at least log the

error and also return error in case of service.

Here we use 3 try-with-ressource blocks and log some errors

Fixed: Fix Default or Empty Catch block in Java and Groovy files

(OFBIZ-)

In many Java and Groovy files we have auto generated catch blocks or empty catch

blocks.

To avoid such exception swallowing this should be improved to at least log the

error and also return error in case of service.

Here we use a try-with-ressource block and log some errors

Improved: Document how to store the JWT secret key

(OFBIZ-10751)

Copy manually all files from trunk because of weird conflicts

Improved: Document how to store the JWT secret key

(OFBIZ-10751)

Copy manually all files from trunk because of weird conflicts

Improved: Document how to store the JWT secret key

(OFBIZ-10751)

Copy manually all files from trunk because of weird conflicts

Improved: Document how to store the JWT secret key

(OFBIZ-10751)

Adds a link to OWASP documentation

Improved: Refactor boolean returns from methods

(OFBIZ-10725)

Stumbled upon it by chance, a last one

Improved: Refactor boolean returns from methods

(OFBIZ-10725)

Reverts mistakes made in previous commit

Improved: Refactor boolean returns from methods

(OFBIZ-10725)

Stumbled upon it by chance, here are few changes

Improved: no functional change

In my previous commit I forgot I used FileUtile::normalizePath (old name

of now normalizeFilePath) in FileUtile::getFile. This is useless, and reverted

here

Improved: no functional change

While working on OFBIZ-11196,I renamed the normalizePath() method in FileUtil

class to createFileWithNormalizedPath() and added the normalizeFilePath()

method which deals only with String (in -> out), could be useful later...

"Applied fix from trunk framework for revision: 1866920"

------------------------------------------------------------------------

r1866920 | jleroux | 2019-09-14 10:19:18 +0200 (sam. 14 sept. 2019) | 18 lignes

Fixed: Path Traversal in webtools/control/FetchLogs and ViewFile

(OFBIZ-11196)

These are not really path traversal issues.

We can't solve them using the traditional way to fix path traversal issues

(ie normalising path). Because Fetchlogs and ViewFile are actually reading

files and if you have the right to read these files then nothing will prevent

you to read them.

The problem is more what those requests are supposed to do.

Fetchlogs is supposed to read a log in the log dir

and ViewFile is supposed to read a file containing labels

(ie either an XML or Properties file).

So the solution is to allow these requests to only do what they are supposed to

do. This is what is done in ViewFile and FetLogs Groovy files.

------------------------------------------------------------------------

?\026

"Applied fix from trunk for revision: 1866920"

------------------------------------------------------------------------

r1866920 | jleroux | 2019-09-14 10:19:18 +0200 (sam. 14 sept. 2019) | 18 lignes

Fixed: Path Traversal in webtools/control/FetchLogs and ViewFile

(OFBIZ-11196)

These are not really path traversal issues.

We can't solve them using the traditional way to fix path traversal issues

(ie normalising path). Because Fetchlogs and ViewFile are actually reading

files and if you have the right to read these files then nothing will prevent

you to read them.

The problem is more what those requests are supposed to do.

Fetchlogs is supposed to read a log in the log dir

and ViewFile is supposed to read a file containing labels

(ie either an XML or Properties file).

So the solution is to allow these requests to only do what they are supposed to

do. This is what is done in ViewFile and FetLogs Groovy files.

------------------------------------------------------------------------

"Applied fix from trunk for revision: 1866920"

------------------------------------------------------------------------

r1866920 | jleroux | 2019-09-14 10:19:18 +0200 (sam. 14 sept. 2019) | 18 lignes

Fixed: Path Traversal in webtools/control/FetchLogs and ViewFile

(OFBIZ-11196)

These are not really path traversal issues.

We can't solve them using the traditional way to fix path traversal issues

(ie normalising path). Because Fetchlogs and ViewFile are actually reading

files and if you have the right to read these files then nothing will prevent

you to read them.

The problem is more what those requests are supposed to do.

Fetchlogs is supposed to read a log in the log dir

and ViewFile is supposed to read a file containing labels

(ie either an XML or Properties file).

So the solution is to allow these requests to only do what they are supposed to

do. This is what is done in ViewFile and FetLogs Groovy files.

------------------------------------------------------------------------

Fixed: Path Traversal in webtools/control/FetchLogs and ViewFile

(OFBIZ-11196)

These are not really path traversal issues.

We can't solve them using the traditional way to fix path traversal issues

(ie normalising path). Because Fetchlogs and ViewFile are actually reading

files and if you have the right to read these files then nothing will prevent

you to read them.

The problem is more what those requests are supposed to do.

Fetchlogs is supposed to read a log in the log dir

and ViewFile is supposed to read a file containing labels

(ie either an XML or Properties file).

So the solution is to allow these requests to only do what they are supposed to

do. This is what is done in ViewFile and FetLogs Groovy files.