Clone Tools
  • last updated 26 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
ISIS-928: mothballing the todoapp (example app and archetype)

    • -26
    • +0
    ./src/main/java/META-INF/persistence.xml
    • -69
    • +0
    ./src/main/java/app/ToDoAppDashboard.java
    • binary
    ./src/main/java/app/ToDoAppDashboard.png
    • -126
    • +0
    ./src/main/java/app/ToDoItemAnalysis.java
  1. … 420 more files in changeset.
ISIS-1027: improving validation messages

- show if the method is inherited or not

- reformat messages to put the violation class/method first

- order the messages alphabetically

Also:

- changed Optionality enum in applib, from TRUE|FALSE to OPTIONAL|MANDATORY.

- updates to the DomainChangeJdoAbstract

    • -5
    • +5
    ./src/main/java/dom/todo/ToDoItem.java
    • -3
    • +3
    ./src/main/java/dom/todo/ToDoItems.java
  1. … 87 more files in changeset.
ISIS-1027: allow @Property and @Collection to be specified for actions to that the corresponding facets are copied over when contributed as contributed property or contributed collection.

  1. … 36 more files in changeset.
ISIS-1027: also, refactored ToDoAppDashboard, so uses @DomainObject(nature=VIEW_MODEL) rather than inherit from AbstractViewModel.

... most of this refactoring was done in previous commit.

    • -14
    • +0
    ./src/main/java/app/ToDoAppDashboard.java
ISIS-1027: refactoring the metamodel validation for detecting duplicates ObjectSpecIdFacet.

Previously this was performed by the ObjectReflectorDefafult, called by the default "not quite no-op" MetaModelValidatorDefault". Have now moved to DomainObjectAnnotationFacetFactory, and removed the API from ObjectReflector.

In addition, updated isis.properties comments for simpleapp and todoapp.

    • -17
    • +17
    ./src/main/java/app/ToDoAppDashboard.java
  1. … 8 more files in changeset.
ISIS-1027: more stuff...

... undeprecating Isis' own services (eg EventBusServiceJdo)

... adding in validators for XxxAnnotationFacetFactory

... moving Bounded and ObjectType annotation processing into DomainObjectAnnotationFacetFactory

  1. … 65 more files in changeset.
ISIS-928: tiny update to ToDo app example.

ISIS-968: @ActionLayout(contributed=...) support.

    • -9
    • +10
    ./src/main/java/dom/todo/ToDoItemContributions.java
  1. … 12 more files in changeset.
ISIS-968: adding unit tests, updates to the todo app.

  1. … 16 more files in changeset.
ISIS-968: extending @DomainService(nature=...).

Also deprecating @NotInServiceMenu.

    • -10
    • +3
    ./src/main/java/dom/todo/ToDoItemContributions.java
  1. … 13 more files in changeset.
ISIS-970: unit testing of @Action annotation

Includes:

- HiddenFacet is now multi-typed (as a minor improvement so that all hidden facets are held (as HidingInteractionAdvisors) and added to, rather than potentially being replaced as the "blessed" facet impl.

- slight alteration (simplification) of the design of @Action(restrictoTo=...)

    • -3
    • +3
    ./src/main/java/dom/todo/ToDoItem.java
    • -2
    • +2
    ./src/main/java/dom/todo/ToDoItems.java
  1. … 96 more files in changeset.
ISIS-970: some unit tests for @ActionAnnotationFacetFactory; fixes/improvements to the todoapp.

    • -8
    • +5
    ./src/main/java/dom/todo/ToDoItem.java
    • -18
    • +38
    ./src/main/java/dom/todo/ToDoItemSubscriptions.java
  1. … 8 more files in changeset.
ISIS-970, ISIS-1003: Reapply veto(...) change to AbstractDomainEvent.

Trivial fix for ToDoItemContributions

  1. … 1 more file in changeset.
ISIS-1008: trivial tidy up in ActionModel; moved exportAsJson into the ToDoItemContributions, minor enhancements.

    • -12
    • +0
    ./src/main/java/dom/todo/ToDoItem.java
    • -1
    • +30
    ./src/main/java/dom/todo/ToDoItemContributions.java
  1. … 1 more file in changeset.
ISIS-1008 A dummy demo of downloading a ToDo as a JSON in an Ajax request.

The action requires a mandatory comment parameter to trigger an action prompt (thus Ajaxy)

    • -4
    • +19
    ./src/main/java/dom/todo/ToDoItem.java
ISIS-970: changing 'interaction' to 'domainEvent', with...

... corresponding new XxxDomainEvent classes deprecating XxxInteractionEvent

    • -9
    • +9
    ./src/main/java/dom/todo/ToDoItem.java
  1. … 66 more files in changeset.
ISIS-1000: generalizing CssClassFacet to accept an (optional) ObjectAdapter

This allows the same facet to be used for the object-level cssClass() (corresponding to CssClassFacetMethod) as well as the member-level @XxxLayout(cssClass=...) annotations. It also opens up the possibility of member-level CSS being dynamic (per object instance) in the future.

Also, updated todoapp to demonstrate the feature (completed items are rendered in tables with a line-through and lightgrey).

    • -0
    • +3
    ./src/main/java/dom/todo/ToDoItem.java
  1. … 22 more files in changeset.
ISIS-995: read "namedEscaped" from xxx.layout.json.

Also, honour escape setting for column headers and for collection panel name.

    • -2
    • +9
    ./src/main/java/dom/todo/ToDoItem.layout.json
  1. … 7 more files in changeset.
Merge remote-tracking branch 'remotes/origin/master' into DN_404

Conflicts:

example/application/simpleapp/webapp/pom.xml

example/application/todoapp/webapp/pom.xml

example/application/todoapp/webapp/src/main/webapp/WEB-INF/persistor.properties

    • -7
    • +7
    ./src/main/java/dom/todo/ToDoItem.java
  1. … 2 more files in changeset.
Removed last 'instanceOf' references to PersistenceCapable. Added a few overrides in the JDOStateManagerForIsis

    • -4
    • +5
    ./src/main/java/dom/todo/ToDoItem.java
  1. … 12 more files in changeset.
ISIS-970: moving the new ActionInvocationContext from applib.annotatoin to applib.services.actinvoc

    • -1
    • +1
    ./src/main/java/dom/todo/ToDoItem.java
    • -1
    • +1
    ./src/test/java/dom/todo/ToDoItemTest.java
  1. … 9 more files in changeset.
ISIS-970: refactoring the Bulk.InteractionContext and BulkInteractionContext services: no longer does former inherit from latter...

... instead these are two separate services, with BulkInteractionContext renamed to ActionInvocationContext.

Refactored ToDoItem to use ActionInvocationContext rather than Bulk.InteractionContext

    • -10
    • +9
    ./src/main/java/dom/todo/ToDoItem.java
    • -2
    • +2
    ./src/test/java/dom/todo/ToDoItemTest.java
  1. … 10 more files in changeset.
ISIS-970: changing @DomainObject(viewModel=true) to @DomainObject(nature=VIEW_MODEL | JDO_ENTITY | EXTERNAL_ENTITY)

  1. … 3 more files in changeset.
ISIS-970: remove support for @ActionLayout(prototype=...) and parsing from xxx.layout.json; add support for @Action(restrictTo=Environment[]).

    • -4
    • +9
    ./src/main/java/dom/todo/ToDoItem.java
    • -3
    • +6
    ./src/main/java/dom/todo/ToDoItems.java
  1. … 15 more files in changeset.
ISIS-970: completed the ActionAnnotationFacetFactory, with additional refactoring for DomainObjectFacetFactory

... so that these do all the processing of auditing, commands, publishing.

ActionAnnotationFacetFactory also does all the processing of @Bulk

In addition:

- gone through the todoapp and simpleapp, updated annotations.

    • -6
    • +12
    ./src/main/java/app/ToDoAppDashboard.java
    • -13
    • +15
    ./src/main/java/app/ToDoItemAnalysis.java
    • -77
    • +110
    ./src/main/java/dom/todo/ToDoItem.java
    • -21
    • +30
    ./src/main/java/dom/todo/ToDoItemContributions.java
    • -26
    • +34
    ./src/main/java/dom/todo/ToDoItems.java
  1. … 112 more files in changeset.
ISIS-983: testing neo4j support for todoapp and simpleapp.

changes:

- the todoapp has been changed to use a Set (rather than SortedSet) for ToDoItem#dependencies... would seem that DataNucleus' neo4j support returns an object of the incorrect type.

- the neo4j settings in persistor.properties has been moved to the end (and is commented out).

- replaced tabs for spaces in pom.xml.

With these change the webapps run ok:

* edit in neo4j setting in WEB-INF/persistor.properties

* build using "mvn clean install -P neo4j"

* run using "mvn antrun:run -Pself-host,neo4j -o"

However, note that the integration tests were tested and do NOT pass:

- the issue for simpleapp was that looks like unique index constraints are not implemented,

- the issue for todoapp looked down to ordering of the dependencies collection.

This commit also:

- renames ToDoSystemInitializer to ToDoAppSystemInitializer (for consistency with simpleapp)

- adds a new putDataNucleusProperty in IsisConfigurationForJdoIntegTests

    • -7
    • +7
    ./src/main/java/dom/todo/ToDoItem.java
  1. … 12 more files in changeset.
ISIS-284: change the todoapp and simpleapp's "isis" profile to be called "isis-validate".

  1. … 1 more file in changeset.
ISIS-284: Use forward slashes for file system paths.

They are accepted by Windows, while '\' is not liked by Unixes.

  1. … 1 more file in changeset.
ISIS-964 Use @ActionLayout#prototype=true instead of the deprecated @Prototype

    • -4
    • +4
    ./src/main/java/dom/todo/ToDoItem.java
ISIS-928: minor incidental changes to the todoapp (additional tests)

    • -12
    • +22
    ./src/main/java/dom/todo/ToDoItem.java
    • -3
    • +43
    ./src/test/java/dom/todo/ToDoItemTest.java
  1. … 1 more file in changeset.