Clone Tools
  • last updated 15 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
ISIS-2158: further simplify WebModules

removes unused field from shared context

  1. … 4 more files in changeset.
ISIS-2259: moves core/viewers up a level.

    • -47
    • +0
    ./integration/AnonymousWebSessionForIsis.java
    • -284
    • +0
    ./integration/AuthenticatedWebSessionForIsis.java
    • -85
    • +0
    ./integration/ConverterForObjectAdapter.java
    • -79
    • +0
    ./integration/ConverterForObjectAdapterMemento.java
    • -114
    • +0
    ./integration/IsisResourceSettings.java
    • -149
    • +0
    ./integration/LocalizerForIsis.java
    • -404
    • +0
    ./integration/WebRequestCycleForIsis.java
    • -306
    • +0
    ./registries/components/ComponentFactoryRegistrarDefault.java
    • -200
    • +0
    ./registries/components/ComponentFactoryRegistryDefault.java
    • -151
    • +0
    ./registries/pages/PageClassListDefault.java
    • -93
    • +0
    ./registries/pages/PageClassRegistryDefault.java
    • -76
    • +0
    ./registries/pages/PageNavigationServiceDefault.java
    • -46
    • +0
    ./services/BookmarkUiServiceWicket.java
  1. … 2136 more files in changeset.
ISIS-2158: fix WebModules getting discovered by CDI

WebModules are managed by Isis and should not be discovered by any

container.

  1. … 11 more files in changeset.
ISIS-2260: adds pdfjs

also moves security/shiro-realm-ldap to impl subdir; ditto vw/exceldownload; ditto vro/cors

    • -2
    • +5
    ./registries/components/ComponentFactoryRegistrarDefault.java
  1. … 95 more files in changeset.
ISIS-2158: reordering injection points to the top of the class

and making these private when possible

also fixing lots of unused field compiler warnings

    • -3
    • +0
    ./registries/pages/PageClassListDefault.java
    • -5
    • +6
    ./registries/pages/PageClassRegistryDefault.java
    • -5
    • +1
    ./registries/pages/PageNavigationServiceDefault.java
    • -3
    • +0
    ./services/BookmarkUiServiceWicket.java
    • -3
    • +0
    ./services/ImageResourceCacheClassPath.java
    • -2
    • +0
    ./services/WicketViewerSettingsDefault.java
  1. … 104 more files in changeset.
ISIS-2183: minor: cleaning up java-doc

    • -8
    • +2
    ./wicketapp/IsisWicketApplication.java
ISIS-2183: minor: converts debug code to proper logging

    • -1
    • +6
    ./registries/components/ComponentFactoryRegistrarDefault.java
ISIS-2183: Convert ComponentFactory to an interface for managed beans

    • -9
    • +13
    ./registries/components/ComponentFactoryRegistrarDefault.java
    • -2
    • +0
    ./registries/components/ComponentFactoryRegistryDefault.java
  1. … 14 more files in changeset.
ISIS-2158: re-run 'optimize imports' for 'core'

    • -1
    • +1
    ./integration/WebRequestCycleForIsis.java
    • -1
    • +1
    ./registries/components/ComponentFactoryRegistryDefault.java
    • -1
    • +2
    ./services/ImageResourceCacheClassPath.java
    • -1
    • +1
    ./services/TranslationsResolverWicket.java
    • -1
    • +1
    ./services/mementos/ObjectMarshaller.java
    • -3
    • +4
    ./wicketapp/IsisWicketApplication.java
  1. … 82 more files in changeset.
ISIS-2158: organize imports in core using IntelliJ

    • -1
    • +1
    ./integration/WebRequestCycleForIsis.java
    • -1
    • +1
    ./registries/components/ComponentFactoryRegistryDefault.java
    • -1
    • +1
    ./services/TranslationsResolverWicket.java
    • -1
    • +1
    ./services/mementos/ObjectMarshaller.java
    • -2
    • +3
    ./wicketapp/IsisWicketApplication.java
  1. … 67 more files in changeset.
ISIS-2158: auto organize imports (/core)

    • -1
    • +2
    ./wicketapp/IsisWicketApplication.java
  1. … 243 more files in changeset.
ISIS-2158: auto organize imports

    • -2
    • +2
    ./registries/components/ComponentFactoryRegistryDefault.java
    • -3
    • +3
    ./registries/pages/PageClassListDefault.java
    • -3
    • +3
    ./registries/pages/PageClassRegistryDefault.java
    • -3
    • +3
    ./registries/pages/PageNavigationServiceDefault.java
    • -2
    • +1
    ./services/BookmarkUiServiceWicket.java
    • -2
    • +1
    ./services/HintStoreUsingWicketSession.java
    • -3
    • +3
    ./services/ImageResourceCacheClassPath.java
    • -2
    • +1
    ./services/TranslationsResolverWicket.java
    • -1
    • +1
    ./services/WicketViewerSettingsDefault.java
  1. … 319 more files in changeset.
ISIS-2249: moving all the classes

not yet enabling DN and Wicket support; we might do this on top of a

more generic solution as targeted by ISIS-1695

    • -10
    • +1
    ./registries/components/ComponentFactoryRegistrarDefault.java
  1. … 57 more files in changeset.
ISIS-2243: uses resteasy-spring-boot-starter to configure

also

- includes fix for ISIS-2240 (dependency injection into servlets and filters);

- incorporates ISIS-2238 (move IsisModuleRestfulObjects to the jaxrs-resteasy4 module)

specifically:

- adds dependency, upgrades to 4.4.1-Final

- introduces RestEasyConfiguration for the "resteasy.servlet.mapping.prefix" and related configs

- annotates the resources, providers etc. so managed as string beans

- removes RestfulObjectsApplication completely, is automatically created if missing

- nb:when existed, got duplicate definition in the Spring ApplicationContext, so this is a bit of a workaround

- introduces WebModuleAbstract for the injection str

also includes ISIS-2238.

    • -19
    • +19
    ./webmodule/WebModuleWicket.java
  1. … 43 more files in changeset.
ISIS-2240: optimise imports is all for some WebModuleXxx's

  1. … 2 more files in changeset.
ISIS-2240: uses WebModule to inject into all servlets, filters etc.

  1. … 7 more files in changeset.
ISIS-2239: adds validation for base-path

... and removes unnecessary logic in WebModuleXxx

  1. … 2 more files in changeset.
ISIS-2237: simplifies WebModule implementations

*assume isApplicable is true unless otherwise specified

* don't use loadClass to check for class presence if is known to be there via 'compile' dependency

* use name field rather than override getName

* calculate path in constructor if possible, reduce duplication

    • -61
    • +25
    ./webmodule/WebModuleWicket.java
  1. … 13 more files in changeset.
ISIS-2226: fixes incubator:model not considering action-parameter facets

also reverts annotation @Supporting -> @Model, because for the moment,

using the more generic idea of @Model being the opposite of

@Programmatic is much simpler to implement when it comes to meta-model

validation

    • -2
    • +2
    ./integration/WebRequestCycleForIsis.java
  1. … 37 more files in changeset.
ISIS-2177: lift AuthenticationSession.getRoles() deprecation

instead make the return type immutable (Can<String>)

    • -1
    • +1
    ./integration/AuthenticatedWebSessionForIsis.java
  1. … 9 more files in changeset.
ISIS-2177: runtime: rationalize package names before further refactoring

    • -1
    • +1
    ./integration/AuthenticatedWebSessionForIsis.java
    • -4
    • +4
    ./integration/WebRequestCycleForIsis.java
  1. … 140 more files in changeset.
ISIS-2158: disable exception suppression for Interaction.execute(...)

- there is an issue with exceptions getting swallowed: unless this is

fixed, we rather print all of them, no matter whether recognized or not

later on

- also throw more meaningful exceptions, when the BookmarkService is

unable to provide a bookmark for a certain type

  1. … 16 more files in changeset.
ISIS-2216: adds @Qualifier to all services.

Also renames some services:

- AuditingServiceInternal (to AuditerDispatchService)

- PublishingServiceInternal (to PublisherDispatchService)

- AuthenticationManagerStandard (to AuthenticationManagerDefault)

- AuthorizationManagerStandard (to AuthorizationManagerDefault)

    • -1
    • +3
    ./registries/components/ComponentFactoryRegistrarDefault.java
    • -1
    • +3
    ./registries/components/ComponentFactoryRegistryDefault.java
    • -1
    • +3
    ./registries/pages/PageClassListDefault.java
    • -1
    • +3
    ./registries/pages/PageClassRegistryDefault.java
    • -1
    • +3
    ./registries/pages/PageNavigationServiceDefault.java
    • -1
    • +2
    ./services/BookmarkUiServiceWicket.java
    • -1
    • +2
    ./services/HintStoreUsingWicketSession.java
    • -1
    • +3
    ./services/ImageResourceCacheClassPath.java
    • -2
    • +3
    ./services/TranslationsResolverWicket.java
    • -1
    • +3
    ./services/WicketViewerSettingsDefault.java
  1. … 133 more files in changeset.
ISIS-2216: adds @Ordered and @Primary

    • -0
    • +11
    ./registries/components/ComponentFactoryRegistrarDefault.java
    • -0
    • +9
    ./registries/components/ComponentFactoryRegistryDefault.java
    • -0
    • +11
    ./registries/pages/PageClassListDefault.java
    • -0
    • +10
    ./registries/pages/PageClassRegistryDefault.java
    • -0
    • +10
    ./registries/pages/PageNavigationServiceDefault.java
    • -0
    • +5
    ./services/BookmarkUiServiceWicket.java
    • -0
    • +10
    ./services/DeepLinkServiceWicket.java
    • -0
    • +5
    ./services/HintStoreUsingWicketSession.java
    • -0
    • +10
    ./services/ImageResourceCacheClassPath.java
    • -0
    • +11
    ./services/LocaleProviderWicket.java
    • -1
    • +9
    ./services/TranslationsResolverWicket.java
    • -0
    • +9
    ./services/WicketViewerSettingsDefault.java
  1. … 88 more files in changeset.
ISIS-2177: finally decouples mementos from persistence

    • -3
    • +3
    ./services/mementos/StandaloneData.java
ISIS-2177: align service name with module name

    • -161
    • +0
    ./services/mementos/ObjectMementoServiceDefault.java
    • -0
    • +161
    ./services/mementos/ObjectMementoServiceWicket.java
ISIS-2177: splitting memento code into API/Impl

moving API to core/webapp

moving Impl to wicket/viewer

    • -1
    • +1
    ./integration/AuthenticatedWebSessionForIsis.java
    • -1
    • +1
    ./integration/ConverterForObjectAdapterMemento.java
    • -5
    • +4
    ./services/BookmarkUiServiceWicket.java
    • -5
    • +3
    ./services/HintStoreUsingWicketSession.java
    • -2
    • +2
    ./services/ImageResourceCacheClassPath.java
    • -0
    • +55
    ./services/mementos/CollectionData.java
    • -0
    • +47
    ./services/mementos/Data.java
    • -0
    • +77
    ./services/mementos/ObjectData.java
    • -0
    • +153
    ./services/mementos/ObjectMarshaller.java
    • -0
    • +670
    ./services/mementos/ObjectMementoLegacy.java
    • -0
    • +161
    ./services/mementos/ObjectMementoServiceDefault.java
    • -0
    • +288
    ./services/mementos/ObjectUnmarshaller.java
    • -0
    • +70
    ./services/mementos/StandaloneData.java
  1. … 74 more files in changeset.
ISIS-2177: further cleanup memento code (better reflect common idioms)

    • -7
    • +7
    ./integration/ConverterForObjectAdapterMemento.java
    • -2
    • +2
    ./wicketapp/IsisWicketApplication.java
  1. … 53 more files in changeset.
ISIS-2216: changes capitalization of @Named("..")

and ensures that all @DomainService(...) are also @Named

    • -1
    • +1
    ./services/BookmarkUiServiceWicket.java
    • -1
    • +1
    ./services/HintStoreUsingWicketSession.java
  1. … 93 more files in changeset.
ISIS-2216: adds @Named(...) and converts @DomainService(nature=DOMAIN) to @Service

    • -3
    • +8
    ./services/BookmarkUiServiceWicket.java
    • -3
    • +5
    ./services/HintStoreUsingWicketSession.java
  1. … 110 more files in changeset.