Clone Tools
  • last updated 22 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
ISIS-1416: new configuration properties to enable/disable inject...() and set...() style injection.

Also updates to docs and migration notes.

    • -1
    • +5
    ./ObjectActionLayoutXmlDefaultTest.java
    • -1
    • +4
    ./OneToManyAssociationDefaultTest.java
  1. … 14 more files in changeset.
ISIS-1410: instantiate FacetFactory's directly rather than reflectively; replace 3 RemoveXxx facet factories with just one; replace/simplify CollectionTypeRegistry (to CollectionUtils); minor reformattings.

    • -2
    • +1
    ./OneToManyAssociationDefaultTest.java
  1. … 22 more files in changeset.
ISIS-1408: removing RuntimeContext, ObjectSpecificationDependencies, ObjectMemberDependencies - now passing the unit tests

    • -5
    • +14
    ./ObjectActionLayoutXmlDefaultTest.java
    • -8
    • +15
    ./OneToManyAssociationDefaultTest.java
  1. … 4 more files in changeset.
ISIS-1408: removing RuntimeContext, ObjectSpecificationDependencies, ObjectMemberDependencies (WIP)

Also adding some micro-caching/helper methods in ServicesInjector (not sure if significant).

WIP - runs up ok, but unit tests failing.

    • -6
    • +3
    ./ObjectActionLayoutXmlDefaultTest.java
    • -7
    • +4
    ./OneToManyAssociationDefaultTest.java
  1. … 104 more files in changeset.
ISIS-1409: internal components of RuntimeContext subclasses are now internal domain services; RuntimeContext hierarchy collapsed into a single class.

    • -5
    • +5
    ./ObjectActionLayoutXmlDefaultTest.java
    • -5
    • +5
    ./OneToManyAssociationDefaultTest.java
  1. … 124 more files in changeset.
ISIS-1407: removed SpecificationLoaderAware.

Also:

- minor extension to ServiceRegistry2

- collapsed ServicesInjector, ServicesInjectorSpi and ServicesInjectorDefault to just ServicesInjector.

    • -1
    • +1
    ./ObjectActionLayoutXmlDefaultTest.java
    • -1
    • +1
    ./OneToManyAssociationDefaultTest.java
  1. … 270 more files in changeset.
ISIS-1407: SpecificationLoader is now a concrete class (rolled ObjectReflector up into it).

    • -1
    • +1
    ./ObjectActionLayoutXmlDefaultTest.java
    • -1
    • +1
    ./OneToManyAssociationDefaultTest.java
  1. … 154 more files in changeset.
ISIS-1402: removing Debuggable interface and implementations, and supporting unused debug methods.

  1. … 42 more files in changeset.
ISIS-993: factored out LayoutMetadataService, renamed the metadata classes

    • -0
    • +107
    ./ObjectActionLayoutXmlDefaultTest.java
  1. … 61 more files in changeset.
ISIS-1213: renamed metamodel classes ("...Impl" to "...Default"); derive name of ObjectActionMixedIn from mixin type (if "_"); simplified logic of #getParameters; also...

renamed:

- ObjectActionImpl to ObjectActionDefault

- OneToOneAssociationImpl to OneToOneAssociationDefault

- OneToManyAssociationImpl to OneToManyAssociationDefault

- OneToOneActionParameterImpl to OneToOneActionParameterDefault

also:

- reduced number of methods subclassed under ObjectMemberAbstract by introducing overridable getFacetHolder()

- OneToOneAssociationContributee

- OneToManyAssociationContributee

- similarly for ObjectActionParameterAbstract

    • -0
    • +107
    ./ObjectActionDefaultTest.java
    • -0
    • +188
    ./OneToManyAssociationDefaultTest.java
    • -188
    • +0
    ./OneToManyAssociationImplTest.java
  1. … 22 more files in changeset.
ISIS-1194: deleting Specification#getInstance() and implementations - never used.

  1. … 11 more files in changeset.
ISIS-1194: simplify isis-maven-plugin to use appManifest (rather than isisConfigDir).

As a result, delete the IsisMetaModel class, since no longer required.

    • -276
    • +0
    ./persistence/PersistenceSessionTest.java
  1. … 6 more files in changeset.
ISIS-1194: simplfying the bootstrap and wiring of components, in particular around PersistenceSessionFactory

specifically:

- IsisSessionFactory

- now passed in the ServicesInjector (rather than obtaining it from the PersistenceSessionFactory)

- initialization of FixtureClock done in IsisSessionFactory rather than PersistenceSessionFactory

- IsisSystem

- createSessionFactory(), changed the order in order to remove some bidir relationships

- in shutdownServices, avoid NPE if the serviceInitializer was never instantiated during init()

- PersistenceSessionFactory

- no longer implements MetaModelRefiner, instead moved out to separate class (PersistenceSessionFactoryMetamodelRefiner)

- this allows us to break the bidir between PersistenceSessionFactory and SpecificationLoader

- no longer requires a RuntimeContext

- no longer requires a ServicesInjector (is provided by IsisSessionFactory when #createPersistenceSession() is called to pass onto the created PersistenceSession)

- no longer implements SpecificationLoaderAware, nor requires a SpecificationLoader (is provided by IsisSessionFactory when #createPerisistenceSession is called)

- similar changes to IsisMetaModel, in its constructor an init() method, to wire up components in the correct order

- PersistenceSession

- no longer holds reference to PersistenceSessionFactory (though does only as FixturesInstallerFlag in order that PSF can continue to cache whether fixtures installed)

- is passed in the JDO PersistenceManagerFactory from Isis' PSF (rather than accessing the PSF's DataNucleusApplicationComponents, which is now wholly internal to PSF)

- is passed in the ServicesInjector directly (rather than obtain from Isis' PSF)

- RuntimeContextAbstract

- now also passed in SpecificationLoader into its constructor (required reordering of IsisSessionFactory#init to be able to do this)

- thereby remove the whole SpecificationLookupDelegator contrivance

- JavaReflectorHelper

- pass through deploymentType to ObjectReflectorDefault

- ObjectReflectorDefault

- removal of isInjectorMethodFor, instead have callers instantiate the InjectorMethodEvaluatorDefault directly

also, to make caller hierarchy more useful::

- changed ApplicationScopedComponent and SessionScopedComponent into marker interfaces

- removed Injectable, pushed injectInto(Object) into subtypes

also:

- enhanced IsisMojoAbstract and IsisMojoValidate (maven-isis-plugin)

- to accept an appManifest in the pom.xml

- use an AppManifest rather than MetaModel to bootstrap the system and validate

- moved IsisComponentProviderDefault from core-integtest into core-runtime (renamed as ...Default2), so can be used by maven-isis-plugin

also:

- deleted AdapterManagerDefault, no longer used

    • -12
    • +17
    ./persistence/PersistenceSessionTest.java
  1. … 66 more files in changeset.
ISIS-1194: remove AdapterManager from ObjectMemberDependencies context class, use PersistenceSessionService instead.

  1. … 13 more files in changeset.
ISIS-1194: moving application-scoped components to RuntimeContextAbstract superclass; IsisTransaction simplifications

- IsisConfigurationDefault now implements ConfigurationService (and using IsisConfigurationDefault concrete class rather than interface where necessary)

- RuntimeContext implementations now require a ServiceInjector, and default the deployment category and configuration; these are set up and immutable for the runtime context

- meaning that RuntimeContext no longer is ServiceInjectorAware.

also:

- IsisTransaction passed through the PersistenceSession (rather than obtain from IsisContext)

    • -6
    • +8
    ./persistence/PersistenceSessionTest.java
  1. … 21 more files in changeset.
ISIS-1194: continuing to inline AdapterManager into PersistenceSession

    • -2
    • +2
    ./persistence/PersistenceSessionTest.java
  1. … 3 more files in changeset.
ISIS-1194: reverting the move of AdapterManager and AdapterManagerAware, as unnecessarily breaks addons (devutils)

  1. … 144 more files in changeset.
ISIS-1194: inlined AdapterManager functionality back into PersistenceSession

    • -3
    • +1
    ./persistence/PersistenceSessionTest.java
  1. … 2 more files in changeset.
ISIS-1194: moving AdapterManager interface to same package as other "runtimecontext" interfaces

  1. … 144 more files in changeset.
ISIS-1194: removing MessageBrokerService from ObjectMemberDependencies

  1. … 7 more files in changeset.
ISIS-1194: renamed ObjectPersistor interface to PersistenceSessionService

  1. … 28 more files in changeset.
ISIS-1194: renaming QuerySubmitter interface (currently empty) to MessageBrokerService

  1. … 18 more files in changeset.
ISIS-1194: moving methods from QuerySubmitter interface to ObjectPersistor interface.

QuerySubmitter is now empty

  1. … 19 more files in changeset.
ISIS-1194: moving interfaces for subcomponents of RuntimeContext into different package.

  1. … 51 more files in changeset.
ISIS-1194: fixing up unit tests; also changing isis-core-runtime's pom.xml, skipTests = false

    • -90
    • +0
    ./session/IsisSessionFactoryAbstractTest_init_and_shutdown.java
  1. … 18 more files in changeset.
ISIS-1194: inlining functionality of PojoRecreator into AdapterManagerDefault

    • -2
    • +1
    ./persistence/PersistenceSessionTest.java
  1. … 3 more files in changeset.
ISIS-1194: pass dependencies to AdapterManager through constructor, rather than using IsisContext. Also remove PojoAdapterFactory, inlining its functionality into AdapterManagerDefault.

    • -7
    • +10
    ./persistence/PersistenceSessionTest.java
  1. … 4 more files in changeset.
ISIS-1194: renamed PersistenceSession#makePersistent to ...InTransaction

    • -1
    • +1
    ./persistence/PersistenceSessionTest.java
  1. … 4 more files in changeset.
ISIS-1194: renamed PersistenceSession#destroyObject to ...InTransaction

    • -2
    • +2
    ./persistence/PersistenceSessionTest.java
  1. … 2 more files in changeset.
ISIS-1194: moved remaining helper methods from ObjectStore to PersistenceSession; removed ObjectStore class.

    • -2
    • +0
    ./persistence/PersistenceSessionTest.java
  1. … 7 more files in changeset.