Clone Tools
  • last updated 17 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
ISIS-1194: fixing up unit tests; also changing isis-core-runtime's pom.xml, skipTests = false

    • -90
    • +0
    ./session/IsisSessionFactoryAbstractTest_init_and_shutdown.java
  1. … 18 more files in changeset.
ISIS-1194: inlining functionality of PojoRecreator into AdapterManagerDefault

    • -2
    • +1
    ./persistence/PersistenceSessionTest.java
  1. … 3 more files in changeset.
ISIS-1194: pass dependencies to AdapterManager through constructor, rather than using IsisContext. Also remove PojoAdapterFactory, inlining its functionality into AdapterManagerDefault.

    • -7
    • +10
    ./persistence/PersistenceSessionTest.java
  1. … 4 more files in changeset.
ISIS-1194: renamed PersistenceSession#makePersistent to ...InTransaction

    • -1
    • +1
    ./persistence/PersistenceSessionTest.java
  1. … 4 more files in changeset.
ISIS-1194: renamed PersistenceSession#destroyObject to ...InTransaction

    • -2
    • +2
    ./persistence/PersistenceSessionTest.java
  1. … 2 more files in changeset.
ISIS-1194: moved remaining helper methods from ObjectStore to PersistenceSession; removed ObjectStore class.

    • -2
    • +0
    ./persistence/PersistenceSessionTest.java
  1. … 7 more files in changeset.
ISIS-1194: simplifying PersistenceSession#open

    • -2
    • +0
    ./persistence/PersistenceSessionTest.java
  1. … 1 more file in changeset.
ISIS-1194: renaming ObjectStore#open and #close, prior to moving to PersistenceSession.

    • -2
    • +2
    ./persistence/PersistenceSessionTest.java
  1. … 2 more files in changeset.
ISIS-1194: moved isFixturesInstalled and transaction management stuff from ObjectStore to PersistenceSession

    • -13
    • +13
    ./persistence/PersistenceSessionTest.java
  1. … 7 more files in changeset.
ISIS-1194: refactor PojoRecreator to pass its dependencies through constructor rather than via IsisContext.

    • -1
    • +2
    ./persistence/PersistenceSessionTest.java
  1. … 4 more files in changeset.
ISIS-1194: working towards combining ObjectStore and PersistenceSession...

... moved execute(commandList) from ObjectStore to PersistenceSession

    • -20
    • +19
    ./persistence/PersistenceSessionTest.java
  1. … 6 more files in changeset.
ISIS-1194: working towards combining ObjectStore and PersistenceSession

... move createXxxCommand from ObjectStore to PersistenceSession

... derive ObjectStore's state from PersistenceSession

    • -5
    • +8
    ./persistence/PersistenceSessionTest.java
  1. … 2 more files in changeset.
ISIS-1194: moving persistence classes around, removing PersistenceSessionFactoryAware. ; + fix for unit test per previous commit

moved:

-DataNucleusApplicationComponents

- FrameworkSynchronizer

- IsisLifecycleListener (renamed as ...2 to ensure backward compatibility)

also:

- CreateSchemaObjectFromClassMetadata no longer requires PersistenceSessionFactory so remove PersistenceSessionFactoryAware interface

- fixing test that references ObjectStore#name() - was removed in previous commit.

    • -1
    • +0
    ./persistence/PersistenceSessionTest.java
  1. … 22 more files in changeset.
ISIS-1194: moving ObjectStore to same package as PersistenceSesion.

also:

- deleted PersistorImplementation

    • -1
    • +0
    ./persistence/PersistenceSessionTest.java
  1. … 13 more files in changeset.
ISIS-1194: renamed DataNucleusObjectStore to ObjectStore; tidying up comments for PersistenceSession and ObjectStore

    • -2
    • +2
    ./persistence/PersistenceSessionTest.java
  1. … 11 more files in changeset.
ISIS-1194: deleting ObjectAdapterFactory; just use PojoAdapterFactory instead.

in addition, inject its dependencies via constructor, rather than have it look them up from IsisContext.

    • -3
    • +2
    ./persistence/PersistenceSessionTest.java
  1. … 8 more files in changeset.
ISIS-1194: PersistenceSession creates DataNucleusObjectStore (rather than the PersistenceSessionFactory creating, and handing to PersistenceSession)

in addition, in DataNucleusObjectStore

- remove the unused TransactionMode (chained/unchained)

- pass in additional dependencies in the constructor, to avoid having to look them up from IsisContext

- remove #adapterFactory field, since not used

- just new up OidMarshaller rather than looking up from IsisContext

- don't register the incomplete PersistenceQueryProcessors in the hash (and delete aforesaid incomplete PQPs)

also

- in PersistenceSession, don't expose PersistenceSessionFactory (only used internally)

- in PersistenceSession, remove the unused createAggregatedInstance, and #testReset

- removed unused suspendListener/resumeListener from DataNucleusApplicationComponents

    • -1
    • +1
    ./persistence/PersistenceSessionTest.java
  1. … 7 more files in changeset.
ISIS-1194: combined OidGenerator and IdentifierGenerator

also:

- pass dependencies into ObjectFactory and to OidGenerator so that they don't need to use IsisContext#getXxx()

- involves passing some components through to PersistenceSession.

    • -1
    • +4
    ./persistence/PersistenceSessionTest.java
  1. … 8 more files in changeset.
ISIS-1194: removing ObjectStore inteface, use DataNucleusObjectStore class directly instead.

    • -1
    • +2
    ./persistence/PersistenceSessionTest.java
  1. … 6 more files in changeset.
ISIS-1194: simplifying PersistAlgorithm, IdentifierGenerator and PojoRecreator.

Previously we had implementations for both DN and in-memory, but we now only need the one for DN, and no requirement for an interface.

    • -3
    • +8
    ./persistence/PersistenceSessionTest.java
  1. … 21 more files in changeset.
ISIS-1194: removing ServicesProvider from RuntimeContext and elsewhere, instead use ServicesInjector.

  1. … 15 more files in changeset.
ISIS-1194 (and also ISIS-1044): removing unused code.

- ActionFacet#invoke(...)

- Memento#encodedData, recreateFrom

- unused parameters (DeploymentCategory and AuthenticationSessionProvider) in ObjectFeature (members and parameters) class hierarchy

- removed DeploymentCategory and AuthenticationSessionProvider fields for SpecificationContext and ObjectMemberContext

- removed ObjectAssociationFilters static class, no longer used

Also:

- renamed SpecificationContext to ObjectSpecificationDependencies

- renamed ObjectMemberContext to ObjectMemberDependencies

  1. … 43 more files in changeset.
ISIS-1044: remove DeploymentCategory, AuthenticationSession from the InteractionContext class hierarchy.

...refactoring any remaining usages of these fields to instead be injected via constructor:

- DisableForSessionFacetAbstract

- HideForSessionFacetAbstract

- ExplorationFacetAbstract

- PrototypeFacetAbstract

Also:

- reorder the remaining parameters in the constructors of InteractionContext and its subclasses.

  1. … 65 more files in changeset.
ISIS-1044: adding interactionInitiatedBy as param to all interactions with metamodel members.

- renamed/repurposed InvocationInteractionMethod

also:

- added new RendererContext4 to provide access to this info

- removed AuthenticationSession/DeploymentCategory as parameters to ObjectMember calls (since are injected)

- call with InteractionInitiatedBy.USER for Wicket UI, Restful Objects server, WrapperFactory proxy when executionMode == enforce_rules

- call with InteractionInitiatedBy.FRAMEWORK for Memento, Auditing, XmlSnapshot, Dump, DomainObjectContainer#validate(), Title context, RecreatableObjectFacet (ie view models) and WrapperFactory proxy when executionMode != enforce_rules

Still to do:

- remove the ThreadLocal accessed by ObjectAdapter.Util#isVisible()

- should inject AuthenticationSessionProvider and DeploymentCategoryProvider into all facet factories, so can then propogate into Facet impls and not have to pass in as parameters

- should write MetaModelValidator to disallow previous use of the old InteractionInvocationMethod (ProgramPersistable interface etc, ie NotPersistableFacet implementations).

- remove DeploymentCategory, AuthenticationSession from the InteractionContext class hierarchy and also ParseValueContext

  1. … 159 more files in changeset.
ISIS-1194: removing SaveObjectCommand since only one impl which is a no-op.

    • -3
    • +0
    ./persistence/PersistenceSessionTest.java
    • -451
    • +0
    ./transaction/IsisTransactionTest.java
  1. … 7 more files in changeset.
ISIS-1188: where how RuntimeContextFromSession is instantiated (and in particular, instantiate it only once, passing it from IsisSystem through to PersistenceMechanismInstaller and thence PersistenceSessionFactory).

    • -1
    • +1
    ./persistence/PersistenceSessionTest.java
  1. … 9 more files in changeset.
ISIS-1188: IsisSessionFactory create OidMarshaller directly rather than passed in; pass ServicesInjectorSpi to PersistenceSessionFactory.

    • -1
    • +1
    ./session/IsisSessionFactoryAbstractTest_init_and_shutdown.java
  1. … 9 more files in changeset.
ISIS-1188: collapsed IsisSystem and IsisSystemDefault (removed IsisSystemAbstract); ditto for IsisSession and IsisSessionFactory.

    • -1
    • +1
    ./session/IsisSessionFactoryAbstractTest_init_and_shutdown.java
  1. … 10 more files in changeset.
ISIS-1182: refactoring ownership of list of services [ABORTIVE: the simpleapp runs up, but todoapp seems to hang?]

- make ServicesInjectorDefault hold the list of services, passed into PersistenceSessionFactory via

- IsisSystemUsingInstallers#obtainPersistenceSessionFactory

- PersistenceMechanismInstaller#createPersistenceSessionFactory

- IsisSystemAbstract#doCreateSessionFactory

- should call obtainServices and pass them to #createSessionFactory

move call to validate the services (@PostConstruct and @PreDestroy stuff):

- relocate to ServicesInjectorSpi

- moved from IsisSessionFactoryDefault (the validateServices method, can be made static quite easily), and don't call at end of its constructor

- call from IsisSystemAbstract (after adding the fallback FixtureScriptsDefault service)

- in IsisSystemAbstract, inline newIsisSessionFactory, no need to be separate

- ObjectReflectorDefault, split out initAndValidate so that validation is called not in the ObjectReflector's init, but instead by:

- IsisSystemFixturesHookAbstract, after calling sessionFactory#init()

    • -4
    • +3
    ./persistence/PersistenceSessionTest.java
    • -1
    • +1
    ./session/IsisSessionFactoryAbstractTest_init_and_shutdown.java
  1. … 24 more files in changeset.
ISIS-995 Allow the label of a property to be rendered as HTML. Also, allow the label of boolean panels to be rendered on the right hand side.

Add support for 'namedEscaped' attribute to @CollectionLayout, @PropertyLayout and @ParameterLayout.

  1. … 27 more files in changeset.