Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
ISIS-2158: change naming strategy for managed-beans

- the bean-name for managed-beans is already required before meta-model

creation

- so we allow @DomainService(objectType=) to override the bean-name as

recognized by Spring immediately after the scan-phase (before the

post-construct phase begins)

- later during meta-model creation, the bean-name as determined above

gets projected into the corresponding meta-model facets; this replaces

the previous behavior of looking up the bean name using annotation

inspection and other naming strategies

- hence the getId() naming strategy for services is no longer supported

    • -31
    • +0
    ./object/objectspecid/classname/ObjectSpecIdFacetDerivedFromDomainServiceAnnotationElseGetId.java
    • -0
    • +34
    ./object/objectspecid/classname/ObjectSpecIdFacetDerivedFromIoCNamingStrategy.java
  1. … 24 more files in changeset.
ISIS-2158: remove some references to conf-legacy where no longer used

    • -2
    • +0
    ./object/domainobjectlayout/CssClassFacetViaDomainObjectLayoutAnnotationUsingCssClassUiEvent.java
    • -2
    • +0
    ./object/domainobjectlayout/CssClassFacetViaViewModelLayoutAnnotationUsingCssClassUiEvent.java
    • -2
    • +0
    ./object/domainobjectlayout/IconFacetViaDomainObjectLayoutAnnotationUsingIconUiEvent.java
    • -1
    • +0
    ./object/domainobjectlayout/IconFacetViaViewModelLayoutAnnotationUsingIconUiEvent.java
    • -2
    • +0
    ./object/domainobjectlayout/LayoutFacetViaDomainObjectLayoutAnnotationUsingLayoutUiEvent.java
    • -2
    • +0
    ./object/domainobjectlayout/LayoutFacetViaViewModelLayoutAnnotationUsingLayoutUiEvent.java
    • -2
    • +0
    ./object/domainobjectlayout/TitleFacetViaDomainObjectLayoutAnnotationUsingTitleUiEvent.java
    • -3
    • +2
    ./object/domainobjectlayout/TitleFacetViaViewModelLayoutAnnotationUsingTitleUiEvent.java
    • -5
    • +11
    ./object/value/annotcfg/ValueFacetAnnotationOrConfigurationFactory.java
    • -12
    • +18
    ./object/value/vsp/ValueSemanticsProviderUtil.java
  1. … 4 more files in changeset.
ISIS-2158: intermediate commit, breaks some smoketests

- simplifies interaction between spec-loader and type-registry

- speed up 'isManagedBean' check, by no longer using reflection, when we

already can ask a fully populated hash-map

- converts DefaultedFacet to use new 'IsisConfiguration'

    • -6
    • +10
    ./object/defaults/annotcfg/DefaultedFacetAnnotationElseConfigurationFactory.java
  1. … 18 more files in changeset.
ISIS-2158: fixing performance issues and tests

  1. … 7 more files in changeset.
ISIS-2158: replace home-brew service injector with Spring's

  1. … 10 more files in changeset.
ISIS-2158: intermediate commit with debug lines, several fixes though ..

- registered beans now honor the @DomainService(objectType="...")

attribute

- lookup Specification by SpedId other than class-name was broken

- attempted fix for the RO Viewer on collections

  1. … 27 more files in changeset.
ISIS-2158: refactoring towards free MM from ObjectAdapter

    • -2
    • +4
    ./collections/modify/CollectionFacet.java
  1. … 5 more files in changeset.
ISIS-2158: introduces a DeficiencyFacet

- facets of this particular type do now get added directly to the

meta-model during validation; these are specifically added to the

facet-holder, that is considered responsible for the failure

- this automatically allows for the meta-model export to also include

deficiency facets, explaining what's going wrong, right at the place

where they originate from

    • -8
    • +10
    ./actions/action/ActionChoicesForCollectionParameterFacetFactory.java
    • -0
    • +118
    ./all/deficiencies/DeficiencyFacet.java
    • -11
    • +24
    ./object/ViewModelSemanticCheckingFacetFactory.java
    • -2
    • +8
    ./object/mixin/MetaModelValidatorForMixinTypes.java
    • -2
    • +2
    ./object/mixin/MixinFacetForMixinAnnotationFactory.java
  1. … 28 more files in changeset.
ISIS-2158: polish meta-model life cycle

    • -1
    • +2
    ./object/ViewModelSemanticCheckingFacetFactory.java
  1. … 12 more files in changeset.
ISIS-1998: at type-level now supported @Collection and @CollectionLayout

- follows same semantic as @Property and @PropertyLayout

    • -15
    • +37
    ./collections/collection/CollectionAnnotationFacetFactory.java
    • -1
    • +1
    ./collections/layout/CollectionLayoutFacetFactory.java
  1. … 6 more files in changeset.
ISIS-1998: also type-level processes @ActionLayout and @PropertyLayout

    • -16
    • +19
    ./properties/property/PropertyAnnotationFacetFactory.java
  1. … 4 more files in changeset.
ISIS-1998: infers intent when using @Property with mixins ...

- when @Property at type level: infers @Action(semantics=SAFE) and

@Mixin(methodName="proc")

- when @Property at method level: infers @Action(semantics=SAFE), but

@Mixin at type level is still required

    • -1
    • +1
    ./actions/layout/NotContributedFacetForActionLayoutAnnotation.java
    • -1
    • +19
    ./properties/property/PropertyAnnotationFacetFactory.java
  1. … 4 more files in changeset.
ISIS-1998: extending MixinFacet to help with early mixin-main method detection

    • -0
    • +7
    ./object/mixin/MixinFacetAbstract.java
  1. … 3 more files in changeset.
ISIS-1998: proper mixin main method detection

- doing this now in a single place: FacetedMethodsBuilder

- solves issue with any public mixin method being picked up as

contributing action

  1. … 3 more files in changeset.
ISIS-2158: major MM refactoring: replace ObjectAdapter -> ManagedObject

- in order to decouple the meta-model from the stateful 'ObjectAdapter'

- instead the lightweigth 'ManagedObject' just holds a PoJos and its

ObjectSpecification

    • -30
    • +33
    ./actions/action/invocation/ActionInvocationFacetForDomainEventAbstract.java
    • -3
    • +2
    ./collections/accessor/CollectionAccessorFacetViaAccessor.java
    • -1
    • +2
    ./collections/clear/CollectionClearFacetViaAccessor.java
    • -1
    • +2
    ./collections/clear/CollectionClearFacetViaClearMethod.java
    • -5
    • +5
    ./collections/collection/modify/CollectionAddToFacetForDomainEventFromAbstract.java
    • -5
    • +5
    ./collections/collection/modify/CollectionRemoveFromFacetForDomainEventFromAbstract.java
    • -3
    • +4
    ./collections/modify/CollectionAddToFacetViaAccessor.java
    • -2
    • +4
    ./collections/modify/CollectionAddToFacetViaMethod.java
  1. … 149 more files in changeset.
ISIS-1998: minor polishing

  1. … 1 more file in changeset.
ISIS-1998: allows @Action on type as synonym for @Mixin(method="act")

    • -30
    • +26
    ./actions/action/ActionAnnotationFacetFactory.java
    • -37
    • +30
    ./properties/property/PropertyAnnotationFacetFactory.java
  1. … 25 more files in changeset.
    • -1
    • +0
    ./MethodPrefixBasedFacetFactoryAbstract.java
  1. … 7 more files in changeset.
ISIS-2158: simplifies MetaModelRefiner

- an intermediate step, more to come

    • -4
    • +7
    ./MethodPrefixBasedFacetFactoryAbstract.java
    • -10
    • +11
    ./actions/action/ActionChoicesForCollectionParameterFacetFactory.java
    • -7
    • +6
    ./object/ViewModelSemanticCheckingFacetFactory.java
    • -2
    • +1
    ./object/ignore/isis/RemoveStaticGettersAndSettersFacetFactory.java
    • -6
    • +5
    ./object/mixin/MixinFacetForMixinAnnotationFactory.java
  1. … 38 more files in changeset.
ISIS-2158: some minor refinements reg. MixinFacet

    • -5
    • +3
    ./object/mixin/MixinFacetAbstract.java
    • -14
    • +11
    ./object/mixin/MixinFacetForDomainObjectAnnotation.java
    • -16
    • +15
    ./object/mixin/MixinFacetForMixinAnnotation.java
    • -1
    • +1
    ./object/mixin/MixinFacetForMixinAnnotationFactory.java
  1. … 2 more files in changeset.
ISIS-2158: non-invasive preparations for ISIS-1998

adding tests first (test driven development) before actually modifying

the programming model ...

1. facet processing tests

2. smoketests to test whether the generated meta-model is as expected

    • -15
    • +6
    ./object/mixin/MetaModelValidatorForMixinTypes.java
    • -25
    • +39
    ./object/mixin/MixinFacetAbstract.java
    • -8
    • +11
    ./object/mixin/MixinFacetForDomainObjectAnnotation.java
    • -1
    • +3
    ./object/mixin/MixinFacetForMixinAnnotation.java
    • -11
    • +13
    ./object/mixin/MixinFacetForMixinAnnotationFactory.java
  1. … 16 more files in changeset.
ISIS-2158: remove debug code

ISIS-2158: fixes NamedFacet picking up on empty 'named' attribute

  1. … 2 more files in changeset.
ISIS-2158: fixes the annotation syntesizer (proxy generator)

- did fail when a method had multiple annotations sharing the same

attribute

    • -11
    • +1
    ./actions/action/ActionAnnotationFacetFactory.java
  1. … 10 more files in changeset.
ISIS-2158: adds 'fileAccept' for @Action

unrelated: there is still an issue with @Action annotation processing, hence the quickfix code in ActionAnnotationFacetFactory

    • -5
    • +22
    ./actions/action/ActionAnnotationFacetFactory.java
    • -0
    • +47
    ./actions/fileaccept/FileAcceptFacetForActionAnnotation.java
  1. … 2 more files in changeset.
ISIS-2158: fixes @Action annotation processing also looking into fields

    • -0
    • +10
    ./actions/action/ActionAnnotationFacetFactory.java
  1. … 4 more files in changeset.
ISIS-2158: annotation scanning: minor performance tweaks

- also adding caches, but these are all disabled for now

- we'll need a large sample domain to actually measure performance

  1. … 4 more files in changeset.
ISIS-2158: minor: remove unused code

    • -3
    • +0
    ./collections/layout/CollectionLayoutFacetFactory.java
    • -1
    • +0
    ./param/validate/method/ActionParameterValidationFacetViaMethodFactory.java
ISIS-2158: remaining conversions (parameter level annotations)

    • -11
    • +6
    ./param/bigdecimal/javaxvaldigits/BigDecimalFacetOnParameterFromJavaxValidationAnnotationFactory.java
    • -1
    • +4
    ./param/choices/enums/ActionParameterChoicesFacetDerivedFromChoicesFacetFactory.java
    • -2
    • +3
    ./param/describedas/annotderived/DescribedAsFacetOnParameterAnnotationElseDerivedFromTypeFactory.java
    • -2
    • +2
    ./param/disable/method/ActionParameterDisabledFacetViaMethodFactory.java
    • -2
    • +2
    ./param/hide/method/ActionParameterHiddenFacetViaMethodFactory.java
    • -4
    • +3
    ./param/layout/CssClassFacetForParameterLayoutAnnotation.java
    • -4
    • +3
    ./param/layout/DescribedAsFacetForParameterLayoutAnnotation.java
    • -4
    • +3
    ./param/layout/LabelAtFacetForParameterLayoutAnnotation.java
    • -4
    • +3
    ./param/layout/MultiLineFacetForParameterLayoutAnnotation.java
    • -4
    • +3
    ./param/layout/NamedFacetForParameterLayoutAnnotation.java
    • -25
    • +18
    ./param/layout/ParameterLayoutFacetFactory.java
    • -4
    • +3
    ./param/layout/RenderedAdjustedFacetForParameterLayoutAnnotation.java
  1. … 12 more files in changeset.
ISIS-2158: remaining conversions (method level annotations)

- next up: parameter level annotation processing

    • -19
    • +17
    ./actions/layout/ActionLayoutFacetFactory.java
    • -4
    • +4
    ./actions/layout/ActionPositionFacetForActionLayoutAnnotation.java
    • -4
    • +3
    ./actions/layout/BookmarkPolicyFacetForActionLayoutAnnotation.java
    • -4
    • +5
    ./actions/layout/CssClassFaFacetForActionLayoutAnnotation.java
    • -4
    • +3
    ./actions/layout/CssClassFacetForActionLayoutAnnotation.java
    • -4
    • +5
    ./actions/layout/DescribedAsFacetForActionLayoutAnnotation.java
    • -4
    • +3
    ./actions/layout/HiddenFacetForActionLayoutAnnotation.java
    • -4
    • +3
    ./actions/layout/NamedFacetForActionLayoutAnnotation.java
    • -4
    • +3
    ./actions/layout/NotContributedFacetForActionLayoutAnnotation.java
    • -7
    • +6
    ./actions/layout/PromptStyleFacetForActionLayoutAnnotation.java
    • -4
    • +6
    ./actions/layout/RedirectFacetFromActionLayoutAnnotation.java
    • -38
    • +26
    ./collections/collection/CollectionAnnotationFacetFactory.java
  1. … 13 more files in changeset.