Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
ISIS-2158: change naming strategy for managed-beans

- the bean-name for managed-beans is already required before meta-model

creation

- so we allow @DomainService(objectType=) to override the bean-name as

recognized by Spring immediately after the scan-phase (before the

post-construct phase begins)

- later during meta-model creation, the bean-name as determined above

gets projected into the corresponding meta-model facets; this replaces

the previous behavior of looking up the bean name using annotation

inspection and other naming strategies

- hence the getId() naming strategy for services is no longer supported

    • -7
    • +2
    ./specloader/SpecificationLoaderDefault.java
  1. … 17 more files in changeset.
ISIS-2158: remove some references to conf-legacy where no longer used

    • -2
    • +0
    ./facets/object/domainobjectlayout/CssClassFacetViaDomainObjectLayoutAnnotationUsingCssClassUiEvent.java
  1. … 4 more files in changeset.
ISIS-2158: intermediate commit, breaks some smoketests

- simplifies interaction between spec-loader and type-registry

- speed up 'isManagedBean' check, by no longer using reflection, when we

already can ask a fully populated hash-map

- converts DefaultedFacet to use new 'IsisConfiguration'

    • -11
    • +35
    ./facets/object/defaults/DefaultsProviderUtil.java
    • -11
    • +13
    ./specloader/SpecificationLoaderDefault.java
  1. … 15 more files in changeset.
ISIS-2158: fixing performance issues and tests

  1. … 6 more files in changeset.
ISIS-2158: replace home-brew service injector with Spring's

    • -239
    • +20
    ./services/ServiceInjectorDefault.java
    • -0
    • +284
    ./services/ServiceInjectorLegacy.java
  1. … 7 more files in changeset.
ISIS-2158: intermediate commit with debug lines, several fixes though ..

- registered beans now honor the @DomainService(objectType="...")

attribute

- lookup Specification by SpedId other than class-name was broken

- attempted fix for the RO Viewer on collections

    • -0
    • +9
    ./specloader/SpecificationCacheDefault.java
    • -1
    • +5
    ./specloader/SpecificationLoaderDefault.java
  1. … 19 more files in changeset.
ISIS-2158: refactoring towards free MM from ObjectAdapter

    • -2
    • +4
    ./facets/collections/modify/CollectionFacet.java
    • -4
    • +5
    ./specloader/specimpl/OneToManyAssociationDefault.java
    • -5
    • +7
    ./specloader/specimpl/OneToOneAssociationDefault.java
  1. … 1 more file in changeset.
ISIS-2158: regression

ISIS-2158: fixes OpenJDK-11 cross compilation issue

  1. … 4 more files in changeset.
ISIS-2158: fixes the mixed-in association accept logic

- seems one predicate got flipped during refactoring

    • -1
    • +0
    ./specloader/specimpl/OneToOneAssociationMixedIn.java
    • -3
    • +26
    ./specloader/specimpl/Predicates.java
  1. … 2 more files in changeset.
ISIS-2158: polishing the SpecificationLoaderDefault

    • -58
    • +23
    ./specloader/SpecificationLoaderDefault.java
    • -0
    • +79
    ./specloader/SpecificationLoaderDefault_debug.java
  1. … 2 more files in changeset.
ISIS-2158: further regarding terminology

- also consolidate some of the type categorization logic

- a ManagedBeanAdapter is always of BeanSort = MANAGED_BEAN, so field

removed

    • -11
    • +10
    ./MetaModelContext_usingSpring.java
    • -3
    • +2
    ./services/appfeat/ApplicationFeatureRepositoryDefault.java
    • -22
    • +12
    ./services/registry/ServiceRegistryDefault.java
    • -1
    • +0
    ./specloader/SpecificationLoaderDefault.java
    • -4
    • +4
    ./specloader/specimpl/ObjectSpecificationAbstract.java
  1. … 16 more files in changeset.
ISIS-2158: some renaming after clarifying terminology

- ManagedBean <=> injectable

- ManagedObject <=> introspectable

    • -3
    • +3
    ./services/appfeat/ApplicationFeatureRepositoryDefault.java
    • -6
    • +6
    ./specloader/SpecificationLoaderDefault.java
    • -3
    • +3
    ./specloader/specimpl/ObjectSpecificationAbstract.java
    • -3
    • +3
    ./specloader/specimpl/OneToManyAssociationContributee.java
    • -3
    • +3
    ./specloader/specimpl/OneToOneAssociationContributee.java
  1. … 16 more files in changeset.
ISIS-2158: extend spec-loading, also allow for concurrent validation

- as an optimization step we also introduced a new highly specialized

List type '_VersionedList'

- _VersionedList allows to iterate over its elements while concurrently

adding elements to the list

- we have a special traversal function 'forEach(element)' that very fast

traverses all elements even those that get added during traversal

    • -4
    • +17
    ./specloader/SpecificationCacheDefault.java
    • -0
    • +11
    ./specloader/SpecificationLoader.java
    • -0
    • +13
    ./specloader/SpecificationLoaderDefault.java
    • -7
    • +43
    ./specloader/validator/MetaModelValidatorVisiting.java
  1. … 2 more files in changeset.
ISIS-2158: polishing SpecificationLoader interface

    • -1
    • +1
    ./specloader/SpecificationLoaderDefault.java
  1. … 6 more files in changeset.
ISIS-2158: revert FacetAbstract temp. changes to previous version

- OpenJDK 11 build fails on this class - no idea why

ISIS-2158: introduces a DeficiencyFacet

- facets of this particular type do now get added directly to the

meta-model during validation; these are specifically added to the

facet-holder, that is considered responsible for the failure

- this automatically allows for the meta-model export to also include

deficiency facets, explaining what's going wrong, right at the place

where they originate from

    • -8
    • +10
    ./facets/actions/action/ActionChoicesForCollectionParameterFacetFactory.java
    • -0
    • +118
    ./facets/all/deficiencies/DeficiencyFacet.java
    • -22
    • +31
    ./facets/jaxb/JaxbFacetFactory.java
    • -11
    • +24
    ./facets/object/ViewModelSemanticCheckingFacetFactory.java
  1. … 28 more files in changeset.
ISIS-2158: polish meta-model life cycle

    • -1
    • +2
    ./facets/object/ViewModelSemanticCheckingFacetFactory.java
    • -181
    • +0
    ./specloader/ServiceInitializer.java
    • -40
    • +24
    ./specloader/SpecificationLoader.java
    • -74
    • +36
    ./specloader/SpecificationLoaderDefault.java
    • -12
    • +12
    ./specloader/validator/MetaModelValidatorForValidationFailures.java
  1. … 6 more files in changeset.
ISIS-2158: consolidate all jdo programming model refiners

- also renames some classes in 'jdo-common' -> IsisXxxJdo

  1. … 12 more files in changeset.
ISIS-1998: at type-level now supported @Collection and @CollectionLayout

- follows same semantic as @Property and @PropertyLayout

  1. … 6 more files in changeset.
ISIS-1998: also type-level processes @ActionLayout and @PropertyLayout

  1. … 4 more files in changeset.
ISIS-1998: infers intent when using @Property with mixins ...

- when @Property at type level: infers @Action(semantics=SAFE) and

@Mixin(methodName="proc")

- when @Property at method level: infers @Action(semantics=SAFE), but

@Mixin at type level is still required

    • -1
    • +1
    ./facets/actions/layout/NotContributedFacetForActionLayoutAnnotation.java
  1. … 2 more files in changeset.
ISIS-1998: extending MixinFacet to help with early mixin-main method detection

    • -0
    • +7
    ./facets/object/mixin/MixinFacetAbstract.java
    • -1
    • +1
    ./specloader/specimpl/ObjectSpecificationAbstract.java
  1. … 1 more file in changeset.
ISIS-1998: proper mixin main method detection

- doing this now in a single place: FacetedMethodsBuilder

- solves issue with any public mixin method being picked up as

contributing action

    • -37
    • +75
    ./specloader/specimpl/FacetedMethodsBuilder.java
  1. … 1 more file in changeset.
ISIS-2158: major MM refactoring: replace ObjectAdapter -> ManagedObject

- in order to decouple the meta-model from the stateful 'ObjectAdapter'

- instead the lightweigth 'ManagedObject' just holds a PoJos and its

ObjectSpecification

  1. … 149 more files in changeset.
ISIS-1998: minor polishing

    • -3
    • +3
    ./facets/ContributeeMemberFacetFactory.java
    • -1
    • +2
    ./specloader/specimpl/ObjectSpecificationAbstract.java
ISIS-1998: extracts low-level utilities from ObjectSpecificationAbstract

- creating package private Utils, Predicates and Factories

    • -0
    • +96
    ./specloader/specimpl/Factories.java
    • -319
    • +100
    ./specloader/specimpl/ObjectSpecificationAbstract.java
    • -0
    • +145
    ./specloader/specimpl/Predicates.java
    • -0
    • +103
    ./specloader/specimpl/Utils.java
ISIS-2158: makes the ServiceInjectorDefault thread-safe

    • -2
    • +2
    ./services/ServiceInjectorDefault.java
  1. … 1 more file in changeset.
ISIS-1998: allows @Action on type as synonym for @Mixin(method="act")

    • -28
    • +36
    ./specloader/specimpl/FacetedMethodsBuilder.java
    • -2
    • +2
    ./specloader/specimpl/ObjectSpecificationAbstract.java
  1. … 22 more files in changeset.
ISIS-1998: use @Mixin as meta-annotation on @Action, @Property ...

    • -2
    • +0
    ./progmodel/ProgrammingModelAbstract.java
  1. … 11 more files in changeset.