Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
ISIS-2158: simplify MethodRemover interface, predef filter in MethodUtil

also don't register is/get/set as supporting method prefixes

    • -5
    • +3
    ./PropertySetAndClearFacetFactory.java
  1. … 12 more files in changeset.
ISIS-2263: bump schema XSDs to v2/2.0

    • -4
    • +4
    ./PropertySetAndClearFacetFactory.java
    • -2
    • +2
    ./init/PropertyInitializationFacet.java
  1. … 268 more files in changeset.
ISIS-2259: fixes up package name of isis-core-metamodel

    • -0
    • +31
    ./NotPersistableFacetInferred.java
    • -0
    • +68
    ./PropertyModifyFacetFactory.java
    • -0
    • +122
    ./PropertySetAndClearFacetFactory.java
    • -0
    • +43
    ./clear/PropertyClearFacet.java
    • -0
    • +35
    ./clear/PropertyClearFacetAbstract.java
    • -0
    • +74
    ./clear/PropertyClearFacetViaClearMethod.java
    • -0
    • +75
    ./clear/PropertyClearFacetViaSetterMethod.java
    • -0
    • +50
    ./init/PropertyInitializationFacet.java
    • -0
    • +35
    ./init/PropertyInitializationFacetAbstract.java
    • -0
    • +70
    ./init/PropertyInitializationFacetViaSetterMethod.java
    • -0
    • +51
    ./modify/PropertySetterFacet.java
    • -0
    • +35
    ./modify/PropertySetterFacetAbstract.java
    • -0
    • +81
    ./modify/PropertySetterFacetViaModifyMethod.java
    • -0
    • +76
    ./modify/PropertySetterFacetViaSetterMethod.java
  1. … 3152 more files in changeset.
ISIS-2126 aligning most pkg names for module 'metamodel'

- o.a.i.core.metamodel.* -> o.a.i.metamodel.*

    • -119
    • +0
    ./PropertySetAndClearFacetFactory.java
    • -35
    • +0
    ./clear/PropertyClearFacetAbstract.java
    • -74
    • +0
    ./clear/PropertyClearFacetViaClearMethod.java
    • -74
    • +0
    ./clear/PropertyClearFacetViaSetterMethod.java
    • -48
    • +0
    ./init/PropertyInitializationFacet.java
    • -35
    • +0
    ./init/PropertyInitializationFacetAbstract.java
    • -70
    • +0
    ./init/PropertyInitializationFacetViaSetterMethod.java
    • -35
    • +0
    ./modify/PropertySetterFacetAbstract.java
    • -81
    • +0
    ./modify/PropertySetterFacetViaModifyMethod.java
    • -75
    • +0
    ./modify/PropertySetterFacetViaSetterMethod.java
  1. … 3128 more files in changeset.
adds FacetWithAttributes interface

makes existing facets implement

    • -0
    • +6
    ./clear/PropertyClearFacetViaClearMethod.java
    • -0
    • +6
    ./clear/PropertyClearFacetViaSetterMethod.java
    • -0
    • +5
    ./init/PropertyInitializationFacetViaSetterMethod.java
    • -0
    • +5
    ./modify/PropertySetterFacetViaModifyMethod.java
    • -0
    • +6
    ./modify/PropertySetterFacetViaSetterMethod.java
  1. … 157 more files in changeset.
ISIS-1976: removes OA map, stream for metamodel, excising guava

Key achievements:

Metamodel: almost all guava Function and Predicate idioms removed

Metamodel: slight API improvements, such that some of the internal meta-data that is kept in Java

Collections is no longer copied into immutable lists for any calling client, instead Java Streams are returned (which treat the underlying collections un-modifiable by design)

the ObjectAdapter per-session map/cache is history

the legacy modules have been removed, for convenince and ease of migration the legacy/transition-1-2- module remains and shall provide legacy glue code

shiro was moved to plugins, and its artifact renamed, to be inline with the other plugins

    • -0
    • +1
    ./PropertySetAndClearFacetFactory.java
  1. … 558 more files in changeset.
ISIS-1841 automated source cleanup

Add missing '@Override' annotations

Remove trailing white spaces on all lines

Correct indentation

    • -3
    • +3
    ./init/PropertyInitializationFacet.java
  1. … 1408 more files in changeset.
ISIS-1742: removes @NotPersistable annotation + supporting facets

    • -1
    • +0
    ./PropertySetAndClearFacetFactory.java
  1. … 28 more files in changeset.
ISIS-1404: AuthenticationSessionProvider is now a domain service; removed the AuthenticationSessionProviderAbstract and Aware interfaces.

In addition, FacetFactoryAbstract now implements ServiceInjectorAware, none of the subclass FacetFactorys do. The intention here is that we can just let FacetFactory reach into ServicesInjector to pull out the domain services, such as AuthenticationSessionProvider impl'n.

  1. … 72 more files in changeset.
ISIS-1398: moving the command stuff to PropertySetter/ClearFacetForDomainEventAbstract, and out of the wrapped original PropertySetterFacet or PropertyClearFacet.

Also:

- remove DomainEventHelper#hasEventBusService() since will always return true

    • -2
    • +6
    ./clear/PropertyClearFacetViaClearMethod.java
    • -2
    • +6
    ./clear/PropertyClearFacetViaSetterMethod.java
    • -70
    • +6
    ./modify/PropertySetterFacetViaModifyMethod.java
    • -1
    • +2
    ./modify/PropertySetterFacetViaSetterMethod.java
  1. … 15 more files in changeset.
ISIS-1370: construct the aimDto before calling PublisherService. Also refactoring property setter facet and OneToOneAssociation to follow the same general structure as for action invocations, in particular for the set up of Command objects.

    • -17
    • +21
    ./modify/PropertySetterFacetViaModifyMethod.java
    • -1
    • +2
    ./modify/PropertySetterFacetViaSetterMethod.java
  1. … 17 more files in changeset.
ISIS-1389: extending the new Interaction (in applib) to capture args and provide a callable to be executed.

    • -7
    • +14
    ./modify/PropertySetterFacetViaModifyMethod.java
  1. … 2 more files in changeset.
ISIS-1389: InteractionContext service now also being populated to capture invocation memento

    • -3
    • +16
    ./modify/PropertySetterFacetViaModifyMethod.java
  1. … 10 more files in changeset.
ISIS-1390: default CommandServiceDefault. Also simplifying the relationship between IsisTransaction and Command, and how the Command object is initialized.

Also:

... deprecating CommandService#startTransaction(...), make it the responsibility of IsisTransactionManager to populate the transactionId of the Command in all cases.

... simplifying logic in IsisTransaction; the Command is only just created, so will never have a transactionId to reuse. The design is now simply for the IsisTransactionManager to create a new UUID and set on both the Command and also pass into IsisTransaction.

... extend IsisTranscationManager's executeWithTransaction to allow an existing Command to be passed in; leverage this from BackgroundCommandExecution.

Also:

... use ClockService to obtain the time, rather than Clock singleton (for Command#setTimestamp, also Command#setStartedAt,

... make lookup of mandatory services fail-fast if not present (PropertySetterFacet, ActionInvocationFacet, IsisTransactionManager, IsisTransaction)

... minor alterations to visibility of DomainObjectJdoAbstract properties in tables.

    • -10
    • +19
    ./modify/PropertySetterFacetViaModifyMethod.java
  1. … 10 more files in changeset.
ISIS-1374: moved setupXxx functionality out of ActionInvocationFacet, and into ObjectActionDefault. Removed duplication with ObjectActionMixedIn and ObjectActionContributee.

Also:

- removed unnecessary guards for CommandContext or Command being null (they never will)

- removed (after all) the idea of CommandMento

    • -14
    • +22
    ./modify/PropertySetterFacetViaModifyMethod.java
  1. … 7 more files in changeset.
ISIS-1291: memento xsd schemas + utils; new command memento DTO for Command#memento, updated background service, background execution; new PublisherService

specifically:

- deleted aim-1.0.xsd, added in aim-2.0.xsd, also cmd-1.0.xsd and updated common-1.0.xsd.

- Updated ActionMementoDtoUtils new CommandMementoDtoUtils and CommandDtoUtils

- moved CommandMementoService to internal SPI, added asCommandMemento, depends on ObjectAction (in order to handle mixin types) and also works on lists of objects (for bulk command/actions)

- ActionInvocationFacet populates the Command#setMemento using CommandMementoDto (legacy behaviour preserved)

    • -2
    • +2
    ./modify/PropertySetterFacetViaModifyMethod.java
  1. … 26 more files in changeset.
ISIS-1372: extending EventMetadata with a sequenceName, in preparation to CommandMementoService creating different sequences of events (published event, wrapped event, background commands).

Also updated javadoc for Command, and created a constant "(edit)" which is the value of Command#getTargetAction() for property edits.

    • -2
    • +2
    ./modify/PropertySetterFacetViaModifyMethod.java
  1. … 3 more files in changeset.
ISIS-1044: adding interactionInitiatedBy as param to all interactions with metamodel members.

- renamed/repurposed InvocationInteractionMethod

also:

- added new RendererContext4 to provide access to this info

- removed AuthenticationSession/DeploymentCategory as parameters to ObjectMember calls (since are injected)

- call with InteractionInitiatedBy.USER for Wicket UI, Restful Objects server, WrapperFactory proxy when executionMode == enforce_rules

- call with InteractionInitiatedBy.FRAMEWORK for Memento, Auditing, XmlSnapshot, Dump, DomainObjectContainer#validate(), Title context, RecreatableObjectFacet (ie view models) and WrapperFactory proxy when executionMode != enforce_rules

Still to do:

- remove the ThreadLocal accessed by ObjectAdapter.Util#isVisible()

- should inject AuthenticationSessionProvider and DeploymentCategoryProvider into all facet factories, so can then propogate into Facet impls and not have to pass in as parameters

- should write MetaModelValidator to disallow previous use of the old InteractionInvocationMethod (ProgramPersistable interface etc, ie NotPersistableFacet implementations).

- remove DeploymentCategory, AuthenticationSession from the InteractionContext class hierarchy and also ParseValueContext

    • -1
    • +2
    ./clear/PropertyClearFacetViaClearMethod.java
    • -1
    • +2
    ./clear/PropertyClearFacetViaSetterMethod.java
    • -1
    • +5
    ./modify/PropertySetterFacetViaModifyMethod.java
    • -1
    • +5
    ./modify/PropertySetterFacetViaSetterMethod.java
  1. … 155 more files in changeset.
ISIS-1194: removing ImperativeFacet#impliesObjectChanged and #impliesResolve

    • -10
    • +0
    ./clear/PropertyClearFacetViaClearMethod.java
    • -10
    • +0
    ./clear/PropertyClearFacetViaSetterMethod.java
    • -10
    • +0
    ./init/PropertyInitializationFacetViaSetterMethod.java
    • -10
    • +0
    ./modify/PropertySetterFacetViaModifyMethod.java
    • -10
    • +0
    ./modify/PropertySetterFacetViaSetterMethod.java
  1. … 47 more files in changeset.
ISIS-940: move setting up of the Command object from Wicket code and into core (so should work for Restful viewer also).

    • -4
    • +36
    ./modify/PropertySetterFacetViaModifyMethod.java
  1. … 4 more files in changeset.
ISIS-970: reworking property/collection/action interaction facets (done by the interaction facet factories); process hidden facet for property/collection/action annotation facets; process editing for collections; process typeof for collections (done by typeof facet factory)

Also:

- some refactoring of {Disabled/Hidden}Facet{Impl/AlwaysEverywhere}, made abstract (name adjusted accordingly) and created subtypes where used directly

- most notably DisabledFacetForContributee, also {Disabled/Hidden}FacetOnStaticMethod

- deleted {Disabled/Hidden}FacetNever, since not used.

    • -1
    • +0
    ./PropertySetAndClearFacetFactory.java
  1. … 58 more files in changeset.
ISIS-852: updateable derived properties that have just a getter and a modifyXxx() method.

    • -7
    • +11
    ./PropertySetAndClearFacetFactory.java
  1. … 4 more files in changeset.
ISIS-831: property and collection interactions stuff more or less there...

    • -2
    • +1
    ./clear/PropertyClearFacetViaClearMethod.java
    • -2
    • +1
    ./clear/PropertyClearFacetViaSetterMethod.java
    • -2
    • +1
    ./init/PropertyInitializationFacetViaSetterMethod.java
    • -2
    • +1
    ./modify/PropertySetterFacetViaModifyMethod.java
    • -2
    • +1
    ./modify/PropertySetterFacetViaSetterMethod.java
  1. … 144 more files in changeset.
ISIS-831: digression: moving progmodel/facets into metamodel/facets

... and getting names consistent.

    • -0
    • +31
    ./NotPersistableFacetInferred.java
    • -0
    • +68
    ./PropertyModifyFacetFactory.java
    • -0
    • +116
    ./PropertySetAndClearFacetFactory.java
    • -0
    • +38
    ./clear/PropertyClearFacet.java
    • -0
    • +35
    ./clear/PropertyClearFacetAbstract.java
    • -0
    • +74
    ./clear/PropertyClearFacetViaClearMethod.java
    • -0
    • +74
    ./clear/PropertyClearFacetViaSetterMethod.java
    • -0
    • +48
    ./init/PropertyInitializationFacet.java
    • -0
    • +35
    ./init/PropertyInitializationFacetAbstract.java
    • -0
    • +76
    ./init/PropertyInitializationFacetViaSetterMethod.java
    • -0
    • +43
    ./modify/PropertySetterFacet.java
    • -0
    • +35
    ./modify/PropertySetterFacetAbstract.java
    • -0
    • +74
    ./modify/PropertySetterFacetViaModifyMethod.java
    • -0
    • +74
    ./modify/PropertySetterFacetViaSetterMethod.java
  1. … 1811 more files in changeset.