Clone Tools
  • last updated 26 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
ISIS-2158: simplify MethodRemover interface, predef filter in MethodUtil

also don't register is/get/set as supporting method prefixes

    • -5
    • +6
    ./PropertyAccessorFacetViaAccessorFactory.java
  1. … 12 more files in changeset.
ISIS-2264: isis.reflector.facet.filterVisibility -> isis.core.metamodel.filter-visibility

    • -1
    • +1
    ./PropertyAccessorFacetViaAccessor.java
  1. … 4 more files in changeset.
ISIS-2264: isis.reflector.facet.filterVisibility -> isis.core.metamodel.filter-visibility

    • -1
    • +1
    ./PropertyAccessorFacetViaAccessor.java
  1. … 4 more files in changeset.
ISIS-2259: fixes up package name of isis-core-metamodel

    • -0
    • +96
    ./PropertyAccessorFacetViaAccessor.java
    • -0
    • +113
    ./PropertyAccessorFacetViaAccessorFactory.java
  1. … 3164 more files in changeset.
ISIS-2126 aligning most pkg names for module 'metamodel'

- o.a.i.core.metamodel.* -> o.a.i.metamodel.*

    • -98
    • +0
    ./PropertyAccessorFacetViaAccessor.java
    • -109
    • +0
    ./PropertyAccessorFacetViaAccessorFactory.java
  1. … 3140 more files in changeset.
ISIS-2112: backporting from '2033-IoC_Spring' branch

Task-Url: https://issues.apache.org/jira/browse/ISIS-2112

    • -8
    • +3
    ./PropertyAccessorFacetViaAccessor.java
    • -15
    • +1
    ./PropertyAccessorFacetViaAccessorFactory.java
  1. … 1097 more files in changeset.
ISIS-2033: All MetaModel tests fixed.

However there is a lot of cleaning-up left to do.

Task-Url: https://issues.apache.org/jira/browse/ISIS-2033

    • -1
    • +1
    ./PropertyAccessorFacetViaAccessor.java
  1. … 67 more files in changeset.
ISIS-2033: Major: MetaModel refactoring

removing instances of 'ServicesInjector' being passed around in

constructors

removing 'ServicesInjectorAware' interface

Task-Url: https://issues.apache.org/jira/browse/ISIS-2033

    • -9
    • +4
    ./PropertyAccessorFacetViaAccessor.java
    • -15
    • +1
    ./PropertyAccessorFacetViaAccessorFactory.java
  1. … 467 more files in changeset.
ISIS-2040: module 'security': rename and align packages

Task-Url: https://issues.apache.org/jira/browse/ISIS-2040

    • -1
    • +1
    ./PropertyAccessorFacetViaAccessor.java
  1. … 216 more files in changeset.
2039 redesign of config (#134)

* ISIS-2039: major refactoring

move config code into its own module

remove number of classes in metamodel, that hold a reference to

IsisConfiguration or its implementation

hide the mutable IsisConfigurationDefault

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: reduce visibility of some config classes

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: simplify config access

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: cleaning up the component-provider mess

for web-modules: no longer negotiate by writing attributes to the

servlet-context, instead use a java class for that

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: fixing some tests

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: removing arguments of @PostConstruct methods

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: lazy binding to config for wicket

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: proposed test fix

also cleaning up verbose tests

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: more test fixes

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: experimenting with AppConfig managed by Guice

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: solving the AppManifest lookup problem independently of the

configuration bootstrapping

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: simplify helloworld

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: moving type discovery to an earlier stage in bootstrapping

Integration Test Bootstrapping works.

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: on web-context: move the config bootstrapping from wicket

module to the main ServletContextListener

such that the wicket module is no longer responsible for initiating the

framework

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: config bootstrapping: fixes the resource chain

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: allow ServiceLoader lookup for AppConfig to fallback ...

to previous behavior, that is to lookup the AppManifest from config

property 'isis.appManifest'

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: fixes concurrent modification with _Context

add a property 'isUnitTesting' to the IsisSystemEnvironment, to help

with the decision on how to bootstrap the configuration

also doing some cleaning up

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: fixing junit tests ...

by having the IsisSystemEnvironment#isUnitTesting correctly setup by

JunitRuleMocker2

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: further fixing tests ...

also moving ExceptionRecognizer services that depend on the 'config'

module from 'applib' to 'runtime'

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: fixing tests, that fail due to new domain object annot.

processing

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: unify config bootstrapping code for maven-plugin,

wicket-viewer and headless

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: to fix prev. commit: let the maven-plugin bootstrap the

configuration properly

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: fixing mm verification tests

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: reinstating the ConfigurationServiceDefault

also renaming packages within the 'config' module -> 'o.a.i.config'

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: removing the ConfigurationService interface

use the singleton IsisConfiguration instead

for the UI, the ConfigurationServiceMenu was renamed to

ConfigurationMenu which uses a ConfigurationViewService for the single

purpose of displaying config values

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

* ISIS-2039: reorg. packages

Task-Url: https://issues.apache.org/jira/browse/ISIS-2039

    • -4
    • +3
    ./PropertyAccessorFacetViaAccessor.java
    • -1
    • +0
    ./PropertyAccessorFacetViaAccessorFactory.java
  1. … 424 more files in changeset.
ISIS-1991: major: removing the DeploymentCategory

also rolling up RenderContext2-6

Task-Url: https://issues.apache.org/jira/browse/ISIS-1991

    • -3
    • +1
    ./PropertyAccessorFacetViaAccessor.java
    • -1
    • +1
    ./PropertyAccessorFacetViaAccessorFactory.java
  1. … 130 more files in changeset.
Merge remote-tracking branch 'origin/master' into v2

    • -0
    • +6
    ./PropertyAccessorFacetViaAccessor.java
  1. … 143 more files in changeset.
adds FacetWithAttributes interface

makes existing facets implement

    • -0
    • +6
    ./PropertyAccessorFacetViaAccessor.java
  1. … 161 more files in changeset.
ISIS-1976: introduces ManagedObject to replace OA within most of metamodel

Task-Url: https://issues.apache.org/jira/browse/ISIS-1976

    • -2
    • +2
    ./PropertyAccessorFacetViaAccessor.java
  1. … 141 more files in changeset.
ISIS-1976: replace PropertyOrCollectionAccessorFacet.getProperty(OA, ..) -> getProperty(Instance, ..)

Task-Url: https://issues.apache.org/jira/browse/ISIS-1976

    • -1
    • +2
    ./PropertyAccessorFacetViaAccessor.java
  1. … 13 more files in changeset.
    • -2
    • +2
    ./PropertyAccessorFacetViaAccessorFactory.java
  1. … 42 more files in changeset.
ISIS-1976: decouple metamodel's facets from AdapterManager

introduces ObjectAdapterProvider

Task-Url: https://issues.apache.org/jira/browse/ISIS-1976

    • -4
    • +4
    ./PropertyAccessorFacetViaAccessor.java
    • -3
    • +3
    ./PropertyAccessorFacetViaAccessorFactory.java
  1. … 79 more files in changeset.
ISIS-1841 automated source cleanup

Add missing '@Override' annotations

Remove trailing white spaces on all lines

Correct indentation

    • -2
    • +2
    ./PropertyAccessorFacetViaAccessor.java
    • -1
    • +1
    ./PropertyAccessorFacetViaAccessorFactory.java
  1. … 1409 more files in changeset.
ISIS-1592: extends ixn.xsd and cmd.xsd

to include logicalMemberIdentifier.

Also:

- extended OTOA and OTMA so have getOnType, same as ObjectAction. Required in order to be able to obtain the objectSpec in order to populate the new logicalMemberIdentifier field

    • -5
    • +3
    ./PropertyAccessorFacetViaAccessor.java
    • -2
    • +6
    ./PropertyAccessorFacetViaAccessorFactory.java
  1. … 24 more files in changeset.
ISIS-1408: removing RuntimeContext, ObjectSpecificationDependencies, ObjectMemberDependencies (WIP)

Also adding some micro-caching/helper methods in ServicesInjector (not sure if significant).

WIP - runs up ok, but unit tests failing.

    • -1
    • +1
    ./PropertyAccessorFacetViaAccessorFactory.java
  1. … 106 more files in changeset.
ISIS-1409: removing the *Aware interfaces for the internal components of RuntimeContext (PersistenceSession, Localization, MessageBroker, TranState), also removing AdapterManagerAware.

    • -1
    • +11
    ./PropertyAccessorFacetViaAccessorFactory.java
  1. … 60 more files in changeset.
ISIS-1407: SpecificationLoader is now a concrete class (rolled ObjectReflector up into it).

    • -1
    • +1
    ./PropertyAccessorFacetViaAccessor.java
  1. … 156 more files in changeset.
ISIS-1194: reverting the move of AdapterManager and AdapterManagerAware, as unnecessarily breaks addons (devutils)

    • -1
    • +1
    ./PropertyAccessorFacetViaAccessor.java
  1. … 145 more files in changeset.
ISIS-1194: moving AdapterManager interface to same package as other "runtimecontext" interfaces

    • -1
    • +1
    ./PropertyAccessorFacetViaAccessor.java
  1. … 145 more files in changeset.
ISIS-1044: remove DeploymentCategory, AuthenticationSession from the InteractionContext class hierarchy.

...refactoring any remaining usages of these fields to instead be injected via constructor:

- DisableForSessionFacetAbstract

- HideForSessionFacetAbstract

- ExplorationFacetAbstract

- PrototypeFacetAbstract

Also:

- reorder the remaining parameters in the constructors of InteractionContext and its subclasses.

    • -1
    • +1
    ./PropertyAccessorFacetViaAccessor.java
  1. … 65 more files in changeset.
ISIS-1044: removed AuthenticationSession and DeploymentCategory from facet API that call ObjectAdapter.Util#isVisible (either directly or indirectly).

Instead, the facet can obtain the auth session from the AuthenticationSessionProvider injected in the constructor by the facet factory; DeploymentCategory is similarly injected via the constructor.

Updated:

- ActionChoicesFacet

- ActionInvocationFacet

- ActionParameterAutoCompleteFacet

- ActionParameterChoicesFacet

- AutoCompleteFacet

- ChoicesFacet

- CollectionAccessorFacetViaAccessor

- CollectionAddToFacet ... ForDomainEventAbstract

- CollectionRemoveFromFacet ... ForDomainEventAbstract

- PropertyAccessorFacetViaAccessor

- PropertyAutoCompleteFacet

- PropertyChoicesFacetDerivedFromChoicesFacet

- PropertyClearFacet ... ForDomainEventAbstract

- PropertySetterFacet ... ForDomainEventAbstract

... and their respective implementations and facet factories

... the ... ForDomainEventAbstract are because require access to read current state in order to emit event

    • -5
    • +11
    ./PropertyAccessorFacetViaAccessor.java
    • -1
    • +5
    ./PropertyAccessorFacetViaAccessorFactory.java
  1. … 71 more files in changeset.
ISIS-1044: removed the InteractionUtils' withFiltering() and its threadlocal; removed the disabling of the filtering (in ObjectAdapter.Util#isVisible()); also DeploymentCategoryProvider stuff.

namely:

- added new DeploymentCategoryProviderAware infrastructure, retrofitted RuntimeContext to provide a DeploymentCategoryProvider (cf AuthenticationSessionProvider)

- made DeploymentCategoryProvider extend Injectable, so that RuntimeContext's subcomponents (which include DeploymentCategory) can inject themselves, eg into facet factories)

- made FacetFactoryAbstract implement AuthenticationSessionProviderAware and DeploymentCategoryProviderAware, so that all facets will be able to obtain the authSession and deployment category for themselves (this still to do)

- made FormAbstract, FormComponentPanelAbstract and PanelAbstract all implement DeploymentCategoryProvider (because they also all implement AuthenticationSessionProvider)

- made IsisWicketApplication implement DeploymentCategoryProvider (because it also implements AuthenticationSessionProvider)

also:

- changed order of params in ObjectAction#executeWithRuleChecking(...)

    • -3
    • +1
    ./PropertyAccessorFacetViaAccessor.java
  1. … 28 more files in changeset.
ISIS-1044: adding interactionInitiatedBy as param to all interactions with metamodel members.

- renamed/repurposed InvocationInteractionMethod

also:

- added new RendererContext4 to provide access to this info

- removed AuthenticationSession/DeploymentCategory as parameters to ObjectMember calls (since are injected)

- call with InteractionInitiatedBy.USER for Wicket UI, Restful Objects server, WrapperFactory proxy when executionMode == enforce_rules

- call with InteractionInitiatedBy.FRAMEWORK for Memento, Auditing, XmlSnapshot, Dump, DomainObjectContainer#validate(), Title context, RecreatableObjectFacet (ie view models) and WrapperFactory proxy when executionMode != enforce_rules

Still to do:

- remove the ThreadLocal accessed by ObjectAdapter.Util#isVisible()

- should inject AuthenticationSessionProvider and DeploymentCategoryProvider into all facet factories, so can then propogate into Facet impls and not have to pass in as parameters

- should write MetaModelValidator to disallow previous use of the old InteractionInvocationMethod (ProgramPersistable interface etc, ie NotPersistableFacet implementations).

- remove DeploymentCategory, AuthenticationSession from the InteractionContext class hierarchy and also ParseValueContext

    • -3
    • +3
    ./PropertyAccessorFacetViaAccessor.java
  1. … 160 more files in changeset.
ISIS-1044: filtering changed so that it is "opt-in", only enabled from selected callers.

It turns out that it's wrong to perform filtering all the time at the facet (metamodel) level... there are other internal "trusted" callers of the metamodel for which filtering should not be performed. Examples are the auditing support, and creating XmlSnapshots.

As a first step to refactoring, have put a guard around the code via a thread-local, and provided an API - InteractionUtils.withFiltering(Callable) - which callers can use when they do want filtering.

Have then gone through the Wicket viewer (EntityModel, EntityCollectionModel, ActionModel) and also the WrapperFactory (DomainObjectInvocationHandler) to enable:

- In the case of the wicket viewer, it is enabled for property references, collections, action results and also autocomplete, choices.

- For the wrapper factory, it is enabled provided that the execution mode is NOT skipRules.

Note that the Restful Objects viewer currently has NOT been updated.

In addition, have simplified the configuration properties to a single property, "isis.reflector.facet.filterVisibility".

~~~

All that said, I'm now realizing that even this isn't quite safe enough... the thread-local stays in effect for the duration of the call to the getter or action or autoComplete/choices method etc, and that in turn could call domain services or flush the transaction which results in framework-level code (eg auditing) then running while the thread-local is in effect. So next step is to get rid of the thread-local just introduced, and simply filter in the caller afterwards. I'll get there on this one, eventually...

    • -2
    • +4
    ./PropertyAccessorFacetViaAccessor.java
  1. … 11 more files in changeset.
ISIS-1194: removing ImperativeFacet#impliesObjectChanged and #impliesResolve

    • -16
    • +0
    ./PropertyAccessorFacetViaAccessor.java
  1. … 51 more files in changeset.