Clone Tools
  • last updated 23 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
ISIS-1632 , ISIS-1763: converts some more facet factories to handle Lists of annotations (WORK IN PROGRESS, CODE STILL DOES NOT COMPILE)

  1. … 30 more files in changeset.
ISIS-1632: generalises Annotations utility to return a list of annotations rather than first matching. (INCOMPLETE, DOESN'T EVEN COMPILE)

The idea here is that the calling code can look for the first non-default value for whichever attribute of the annotation that they might be interested in.

  1. … 42 more files in changeset.
ISIS-1742: removes "notInServiceMenu" prefix, "name" prefix, "plural" prefix, "description", "optional", "alwaysHide", "protect" prefixes.

    • -119
    • +0
    ./describedas/staticmethod/DescribedAsFacetStaticMethodFactory.java
    • -120
    • +0
    ./disabled/staticmethod/DisabledFacetStaticMethodFacetFactory.java
  1. … 16 more files in changeset.
ISIS-1742: globally replaces imports on applib.filter.Predicate for guava's equiv, deletes applib.filter.Predicate

  1. … 31 more files in changeset.
ISIS-1742: renames applib.filter.Filter to applib.filter.Predicate, same as guava's similar class.

  1. … 34 more files in changeset.
ISIS-1742: moves applib.events to applib.services.wrapper.events

    • -1
    • +1
    ./disabled/method/DisableForContextFacetNone.java
    • -1
    • +1
    ./disabled/method/DisableForContextFacetViaMethod.java
    • -1
    • +1
    ./hidden/method/HideForContextFacetViaMethod.java
  1. … 118 more files in changeset.
ISIS-1742 deletes RenderType and RenderFacet, refactors RO and Wkt viewer to use the replacement DefaultViewFacet instead.

  1. … 5 more files in changeset.
ISIS-1742: deletes When enum from @Hidden, @Disabled, @Immutable

    • -2
    • +1
    ./disabled/DisabledFacetAbstractAlwaysEverywhere.java
    • -26
    • +21
    ./disabled/DisabledFacetAbstractImpl.java
    • -2
    • +1
    ./disabled/DisabledFacetForContributee.java
    • -3
    • +2
    ./hidden/HiddenFacetAbstractAlwaysEverywhere.java
    • -23
    • +8
    ./hidden/HiddenFacetAbstractImpl.java
    • -2
    • +2
    ./hidden/HiddenFacetFromLayoutPropertiesAbstract.java
  1. … 66 more files in changeset.
ISIS-1742: removes support for .layout.json files

    • -34
    • +0
    ./cssclass/annotprop/CssClassFacetOnMemberAnnotation.java
    • -67
    • +0
    ./cssclass/annotprop/CssClassFacetOnMemberFactory.java
    • -36
    • +0
    ./cssclass/annotprop/CssClassFacetOnMemberFromProperties.java
    • -18
    • +1
    ./cssclassfa/annotprop/CssClassFaFacetOnMemberFactory.java
    • -20
    • +2
    ./describedas/annotprop/DescribedAsFacetOnMemberFactory.java
    • -56
    • +0
    ./disabled/layout/DisabledFacetFromProperties.java
    • -56
    • +0
    ./disabled/layout/DisabledFacetOnMemberFromPropertiesFactory.java
    • -51
    • +0
    ./hidden/layout/HiddenFacetOnMemberFromProperties.java
    • -57
    • +0
    ./hidden/layout/HiddenFacetOnMemberFromPropertiesFactory.java
    • -44
    • +0
    ./named/annotprop/NamedFacetOnMemberFromProperties.java
  1. … 137 more files in changeset.
ISIS-1742: delets @Named annotation and corresponding facets and facet factories.

Also updates .adocs.

Also adds in todo list of deprecations to work through.

  1. … 16 more files in changeset.
ISIS-1742: deletes @DescribedAs and corresponding facets, updates/deletes corresponding factories

    • -31
    • +2
    ./describedas/annotprop/DescribedAsFacetOnMemberFactory.java
  1. … 7 more files in changeset.
ISIS-1742: removes @CssClassFa annotation and updates facet.

Also updates .adocs for @CssClass and @CssClassFa

    • -24
    • +1
    ./cssclassfa/annotprop/CssClassFaFacetOnMemberFactory.java
  1. … 4 more files in changeset.
ISIS-1742: removes @CssClass annotation and supporting facet and factories

    • -40
    • +1
    ./cssclass/annotprop/CssClassFacetOnMemberFactory.java
  1. … 7 more files in changeset.
ISIS-1742: deletes @Resolve annotation and supporting facets.

    • -36
    • +0
    ./render/annotprop/RenderFacetViaResolveAnnotation.java
  1. … 3 more files in changeset.
ISIS-1742: removes @Render annotation, replaces Render.Type enum with RenderType enum

  1. … 14 more files in changeset.
ISIS-1742: deletes @FieldOrder and corresponding facet and facet factory. Also:

Also

- removes some deprecated annotations from .adoc

  1. … 9 more files in changeset.
ISIS-1742: deletes @ActionOrder annotation and corresponding facet and facet factory

  1. … 8 more files in changeset.
ISIS-1720: starts refactoring, but abandoned because...

... because necessary to pass the target instance into the NamedFacet everywhere

    • -0
    • +67
    ./named/staticmethod/NamedFacetInstanceMethod.java
    • -0
    • +136
    ./named/staticmethod/NamedFacetStaticOrInstanceMethodFactory.java
  1. … 4 more files in changeset.
ISIS-1650: the disabledfacet for JAXB (recreatable objects) no longer clobbers any existing disabled facet.

    • -2
    • +11
    ./disabled/DisabledFacetAbstract.java
  1. … 2 more files in changeset.
ISIS-1578: changes the existing {Hide/Disable}ForContextFacetViaMethodFactory to (optionally, but by default) no longer search for supporting methods that have anything other than no-args.

Can be disabled using configuration parameter.

    • -6
    • +16
    ./disabled/method/DisableForContextFacetViaMethodFactory.java
    • -4
    • +13
    ./hidden/method/HideForContextFacetViaMethodFactory.java
  1. … 8 more files in changeset.
ISIS-1478: now honours @Property(editing=ENABLED), takes precedence over isis.properties config file (if configured as isis.objects.editing=false)

Also, refactored simpleapp so that the majority of isis.properties and persistor_datanucleus.properties are read in programmatically by the app manifest.

    • -2
    • +23
    ./disabled/DisabledFacetAbstract.java
    • -0
    • +10
    ./disabled/DisabledFacetAbstractImpl.java
  1. … 16 more files in changeset.
ISIS-1429: removing AuthenticationSessionUtils, moving responsibility directly onto AuthenticationSession. Also removing unused utility classes (Base64Serializer, HexUtils).

  1. … 6 more files in changeset.
ISIS-1422: refactoring (no functional change) - completely eliminated ValueSemanticsProviderContext, just use ServicesInjector throughout, and don't pass IsisConfiguration to VSP either, since derivable from ServicesInjector.

Also:

- made ConfigurationServiceInternal extend from IsisConfiguration (IsisConfigurationDefault is the only impl anyway)

- removed unnecessary casts to IsisConfiguration

- removed components passed into AutoCompleteFacetAbstract, since all derivable from ServicesInjector.

    • -2
    • +1
    ./describedas/annotprop/DescribedAsFacetOnMemberFactory.java
    • -1
    • +1
    ./describedas/staticmethod/DescribedAsFacetStaticMethodFactory.java
    • -1
    • +1
    ./disabled/staticmethod/DisabledFacetStaticMethodFacetFactory.java
  1. … 179 more files in changeset.
ISIS-1408: removing RuntimeContext, ObjectSpecificationDependencies, ObjectMemberDependencies (WIP)

Also adding some micro-caching/helper methods in ServicesInjector (not sure if significant).

WIP - runs up ok, but unit tests failing.

    • -2
    • +1
    ./describedas/annotprop/DescribedAsFacetOnMemberFactory.java
    • -3
    • +1
    ./describedas/staticmethod/DescribedAsFacetStaticMethodFactory.java
    • -3
    • +1
    ./disabled/staticmethod/DisabledFacetStaticMethodFacetFactory.java
  1. … 100 more files in changeset.
ISIS-1407: removed SpecificationLoaderAware.

Also:

- minor extension to ServiceRegistry2

- collapsed ServicesInjector, ServicesInjectorSpi and ServicesInjectorDefault to just ServicesInjector.

    • -1
    • +1
    ./cssclassfa/annotprop/CssClassFaFacetOnMemberFactory.java
    • -1
    • +1
    ./describedas/annotprop/DescribedAsFacetOnMemberFactory.java
    • -1
    • +1
    ./describedas/staticmethod/DescribedAsFacetStaticMethodFactory.java
    • -1
    • +1
    ./disabled/staticmethod/DisabledFacetStaticMethodFacetFactory.java
  1. … 262 more files in changeset.
ISIS-1406: lots more refactoring around IsisConfiguration and IsisConfigurationBuilder.

specifically:

- simplified IsisConfigurationBuilder, now a single class (rather than an interface with 4 different impls, only 2 of which were used).

- removed IsisRunner, so that the command line options are now a responsibility of the IsisConfigurationBuilder

- IsisConfigurationBuilder is passed from o.a.i.WebServer to IsisWicketApplication (not just the "primers"

- removed OptionValidator, wasn't being used

- FacetFactoryAbstract responsible for providing IsisConfiguration to all subclass impls

- InstallerLookup simplified, no longer responsible for appending to the IsisConfigurationBuilder

- InstallerAbstract impls now all have the IsisConfiguration injected into them (constructor injection).

- removed duplication between IsisWebAppBootstrapper and IsisWicketApplication

As of this commit the app runs, but the fixtures are not being automatically installed.

    • -17
    • +1
    ./cssclass/annotprop/CssClassFacetOnActionFromConfiguredRegexFactory.java
    • -6
    • +2
    ./cssclassfa/annotprop/CssClassFaFacetOnMemberFactory.java
  1. … 103 more files in changeset.
ISIS-1405: removing IsisConfigurationAware.

    • -3
    • +8
    ./cssclass/annotprop/CssClassFacetOnActionFromConfiguredRegexFactory.java
    • -3
    • +11
    ./cssclass/annotprop/CssClassFacetOnMemberFactory.java
    • -9
    • +13
    ./cssclassfa/annotprop/CssClassFaFacetOnMemberFactory.java
    • -3
    • +10
    ./describedas/annotprop/DescribedAsFacetOnMemberFactory.java
    • -3
    • +10
    ./describedas/staticmethod/DescribedAsFacetStaticMethodFactory.java
    • -3
    • +8
    ./disabled/staticmethod/DisabledFacetStaticMethodFacetFactory.java
  1. … 81 more files in changeset.
ISIS-1404: AuthenticationSessionProvider is now a domain service; removed the AuthenticationSessionProviderAbstract and Aware interfaces.

In addition, FacetFactoryAbstract now implements ServiceInjectorAware, none of the subclass FacetFactorys do. The intention here is that we can just let FacetFactory reach into ServicesInjector to pull out the domain services, such as AuthenticationSessionProvider impl'n.

    • -9
    • +3
    ./cssclass/annotprop/CssClassFacetOnActionFromConfiguredRegexFactory.java
    • -9
    • +2
    ./disabled/method/DisableForContextFacetViaMethodFactory.java
  1. … 70 more files in changeset.
ISIS-993: fleshing out the GridNormalizerServiceAbstract for the "complete" and "minimal" updating of Grid graphs (prior to conversion to XML).

    • -0
    • +24
    ./cssclassfa/CssClassFaPosition.java
  1. … 15 more files in changeset.
ISIS-993: pretty much there on deriving and syncing the metamodel with the layout.xml info;

next step is to do the new Wicket views for the tabs themselves

    • -0
    • +35
    ./order/annotprop/MemberOrderFacetXml.java
  1. … 39 more files in changeset.