isis-git

Clone Tools

Stats

Commits this week: 161
Total Committers: 57
Last Commit:
Commits this week: 161

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 10 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 02 Oct
6:52 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2086: fixes syntax errors in metadata

Options
    • -4
    • +4
    /core/config/src/main/resources/META-INF/additional-spring-configuration-metadata.json
6:49 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2086: Hsql and H2 UI now read ConnectionURL from IsisConfiguration.

Options
    • -3
    • +5
    /core/runtime-extensions/src/main/java/org/apache/isis/runtime/services/hsqldb/HsqlDbManagerMenu.java
    • -4
    • +6
    /core/runtime-web/src/main/java/org/apache/isis/webapp/modules/h2console/WebModuleH2Console.java
6:41 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2086: adds javax.jdo.option settings to IsisConfiguration

with metadata so that they are correctly bound.

Options
    • -0
    • +21
    /core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java
    • -1
    • +15
    /core/config/src/main/resources/META-INF/additional-spring-configuration-metadata.json
6:16 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2062: updating docs on using Antora

Options
    • -1
    • +1
    /antora/components/toc/modules/comguide/pages/about.adoc
    • -0
    • +161
    /antora/components/toc/modules/comguide/pages/antora-publish-procedure.adoc
    • -161
    • +0
    /antora/components/toc/modules/comguide/pages/asciidoc-publish-procedure.adoc
    • -2
    • +2
    /antora/components/toc/modules/comguide/pages/post-release-successful.adoc
    • -0
    • +1
    /antora/components/toc/modules/devguide/pages/about.adoc
    • -0
    • +10
    /antora/components/toc/modules/devguide/pages/building-docs-and-website.adoc
6:16 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2062: updating docs on using Antora

Options
    • -1
    • +1
    /antora/components/toc/modules/comguide/pages/about.adoc
    • -0
    • +161
    /antora/components/toc/modules/comguide/pages/antora-publish-procedure.adoc
    • -161
    • +0
    /antora/components/toc/modules/comguide/pages/asciidoc-publish-procedure.adoc
    • -2
    • +2
    /antora/components/toc/modules/comguide/pages/post-release-successful.adoc
    • -0
    • +1
    /antora/components/toc/modules/devguide/pages/about.adoc
    • -0
    • +10
    /antora/components/toc/modules/devguide/pages/building-docs-and-website.adoc
6:13 am

Andi Huber

ISIS-2158: config-beans: adding test case for 'ConnectionURL'

Options
    • -0
    • +4
    /core/config/src/main/java/org/apache/isis/config/IsisPresets.java
    • -0
    • +22
    /core/config/src/main/resources/presets/H2InMemory_withUniqueSchema.properties
    • -1
    • +1
    /examples/smoketests/src/main/java/org/apache/isis/testdomain/conf/Configuration_usingJdo.java
    • -0
    • +5
    /examples/smoketests/src/test/java/org/apache/isis/testdomain/config/FooProperties.java
    • -2
    • +13
    /examples/smoketests/src/test/java/org/apache/isis/testdomain/config/FooTest.java
    • -19
    • +26
    /examples/smoketests/src/test/java/org/apache/isis/testdomain/publishing/PublisherServiceTest.java
Tuesday 01 Oct
9:24 pm

Andi Huber

ISIS-2158: MethodRemover: using Set<Method> instead of List<Method>

- should(!?) perform better on classes with lots of methods

- also solving concurrent modification issues when stress testing

spec-loading

Options
    • -67
    • +84
    /core/metamodel/src/main/java/org/apache/isis/metamodel/commons/MethodUtil.java
    • -2
    • +7
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facetapi/MethodRemover.java
    • -5
    • +0
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/SpecificationLoaderDefault.java
    • -3
    • +7
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/facetprocessor/FacetProcessor.java
    • -31
    • +56
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/specimpl/FacetedMethodsBuilder.java
    • -2
    • +2
    /examples/smoketests/src/test/java/org/apache/isis/testdomain/domainmodel/SpecloaderPerformanceTest.java
    • -1
    • +1
    /examples/smoketests/src/test/java/org/apache/isis/testdomain/publishing/PublisherServiceTest.java
7:27 pm

Andi Huber

ISIS-2158: refine MethodRemover interface

- less List instances required during spec-loading

- also makes the FacetHolderImpl thread-safe, which is required for

concurrent spec-loading

Options
    • -7
    • +7
    /core/metamodel/src/main/java/org/apache/isis/metamodel/commons/MethodUtil.java
    • -7
    • +11
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facetapi/FacetHolderImpl.java
    • -3
    • +21
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facetapi/MethodRemover.java
    • -4
    • +5
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facets/FacetFactory.java
    • -4
    • +2
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facets/MethodRemoverConstants.java
    • -4
    • +8
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facets/collections/accessor/CollectionAccessorFacetViaAccessorFactory.java
    • -1
    • +1
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facets/properties/accessor/PropertyAccessorFacetViaAccessorFactory.java
    • -16
    • +23
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/specimpl/FacetedMethodsBuilder.java
    • -1
    • +2
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/specimpl/ObjectSpecificationAbstract.java
    • -0
    • +2
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/specimpl/OneToOneAssociationMixedIn.java
    • -2
    • +2
    /core/metamodel/src/test/java/org/apache/isis/metamodel/facets/MethodRemoverForTesting.java
    • -1
    • +1
    /examples/smoketests/src/test/java/org/apache/isis/testdomain/domainmodel/SpecloaderPerformanceTest.java
5:52 pm

Andi Huber

ISIS-2158: performance regression?

Options
    • -2
    • +0
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facetapi/MethodRemover.java
    • -10
    • +0
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facets/FacetFactory.java
    • -3
    • +0
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facets/MethodRemoverConstants.java
    • -15
    • +10
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facets/object/callbacks/CreatedCallbackFacetFactory.java
    • -10
    • +7
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facets/object/callbacks/LoadCallbackFacetFactory.java
    • -13
    • +10
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facets/object/callbacks/PersistCallbackFacetFactory.java
    • -14
    • +11
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facets/object/callbacks/PersistCallbackViaSaveMethodFacetFactory.java
    • -12
    • +9
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facets/object/callbacks/RemoveCallbackFacetFactory.java
    • -16
    • +12
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facets/object/callbacks/RemoveCallbackViaDeleteMethodFacetFactory.java
    • -11
    • +8
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facets/object/callbacks/UpdateCallbackFacetFactory.java
    • -14
    • +0
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/specimpl/FacetedMethodsBuilder.java
    • -10
    • +0
    /core/metamodel/src/test/java/org/apache/isis/metamodel/facets/MethodRemoverForTesting.java
    • -1
    • +1
    /examples/smoketests/src/test/java/org/apache/isis/testdomain/domainmodel/SpecloaderPerformanceTest.java
3:24 pm

Andi Huber

ISIS-2158: spec-loading: minor tweaks

- profiling data shows, that basically most of the time is spent doing

reflective stuff like finding annotations including meta-annotations

Instead of writing or own reflection tools (with caching), we could

utilize those that Spring already provides.

Options
    • -13
    • +22
    /core/commons/src/main/java/org/apache/isis/commons/internal/reflection/_Reflect.java
    • -1
    • +1
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facetapi/MethodRemover.java
    • -3
    • +8
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facets/Annotations.java
    • -0
    • +4
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/SpecificationLoaderDefault.java
    • -2
    • +2
    /core/metamodel/src/test/java/org/apache/isis/metamodel/facets/AbstractFacetFactoryTest.java
    • -0
    • +102
    /core/metamodel/src/test/java/org/apache/isis/metamodel/facets/MethodRemoverForTesting.java
    • -120
    • +0
    /core/metamodel/src/test/java/org/apache/isis/metamodel/facets/ProgrammableMethodRemover.java
    • -3
    • +5
    /examples/smoketests/src/test/java/org/apache/isis/testdomain/domainmodel/SpecloaderPerformanceTest.java
12:51 pm

Andi Huber

ISIS-2158: spec-loading: simplify spec-cache

Options
    • -1
    • +3
    /core/config/src/main/java/org/apache/isis/config/registry/IsisBeanTypeRegistry.java
    • -37
    • +0
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/SpecificationCacheDefault.java
    • -32
    • +6
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/SpecificationLoaderDefault.java
    • -3
    • +3
    /core/metamodel/src/test/java/org/apache/isis/metamodel/specloader/SpecificationCacheDefaultTest.java
    • -2
    • +13
    /examples/smoketests/src/test/java/org/apache/isis/testdomain/domainmodel/SpecloaderPerformanceTest.java
11:10 am

Andi Huber

ISIS-2158: spec-loading: some refinement and polishing

Options
    • -1
    • +1
    /core/metamodel/src/main/java/org/apache/isis/metamodel/facets/object/domainobject/DomainObjectAnnotationFacetFactory.java
    • -1
    • +1
    /core/metamodel/src/main/java/org/apache/isis/metamodel/services/appfeat/ApplicationFeatureRepositoryDefault.java
    • -1
    • +1
    /core/metamodel/src/main/java/org/apache/isis/metamodel/services/layout/LayoutServiceDefault.java
    • -1
    • +1
    /core/metamodel/src/main/java/org/apache/isis/metamodel/services/metamodel/MetaModelExporter.java
    • -1
    • +1
    /core/metamodel/src/main/java/org/apache/isis/metamodel/services/metamodel/MetaModelServiceDefault.java
    • -2
    • +2
    /core/metamodel/src/main/java/org/apache/isis/metamodel/services/swagger/internal/Generation.java
    • -0
    • +7
    /core/metamodel/src/main/java/org/apache/isis/metamodel/spec/ObjectSpecification.java
    • -2
    • +3
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/SpecificationLoader.java
    • -43
    • +15
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/SpecificationLoaderDefault.java
    • -3
    • +1
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/specimpl/ObjectSpecificationAbstract.java
    • -1
    • +1
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/validator/MetaModelValidatorVisiting.java
    • -1
    • +1
    /core/metamodel/src/test/java/org/apache/isis/metamodel/services/appfeat/ApplicationFeatureRepositoryDefaultTest.java
    • -2
    • +8
    /core/metamodel/src/test/java/org/apache/isis/metamodel/testspec/ObjectSpecificationStub.java
    • -1
    • +1
    /core/runtime/src/main/java/org/apache/isis/runtime/system/session/IsisSessionFactoryDefault.java
    • -1
    • +1
    /core/testsupport/integtestsupport/src/main/java/org/apache/isis/integtestsupport/validate/ValidateDomainModel.java
  16. … 3 more files in changeset.
10:22 am

Andi Huber

ISIS-2158: have IsisConfiguration not depend on any Isis service

Options
    • -16
    • +21
    /core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java
    • -7
    • +0
    /core/metamodel/src/main/java/org/apache/isis/metamodel/services/registry/ServiceRegistryDefault.java
9:59 am

Andi Huber

ISIS-2158: adds 2 fields to IsisConfiguration, populated by ServiceRegistryDefault

- Map<String, String> rawKeyValueMap

- Environment environment

using environment might be the better choice of the 2, but we'll see

also fixes build issues after merge

Options
    • -0
    • +14
    /core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java
    • -6
    • +15
    /core/metamodel/src/main/java/org/apache/isis/metamodel/services/registry/ServiceRegistryDefault.java
    • -10
    • +8
    /core/viewer-wicket/impl/src/main/java/org/apache/isis/viewer/wicket/viewer/IsisWicketApplication.java
    • -1
    • +4
    /core/viewer-wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/models/EntityCollectionModel.java
9:22 am

Andi Huber

Merge pull request #149 from apache/ISIS-2086

more work on config-beans

Options
9:15 am

Andi Huber

ISIS-2158: attempt to simplify some of the spec-loading code

Options
    • -0
    • +5
    /core/commons/src/main/java/org/apache/isis/commons/internal/base/_Timing.java
    • -52
    • +39
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/SpecificationCacheDefault.java
    • -7
    • +8
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/SpecificationLoaderDefault.java
    • -11
    • +13
    /core/metamodel/src/test/java/org/apache/isis/metamodel/specloader/SpecificationCacheDefaultTest.java
    • -7
    • +1
    /examples/smoketests/src/main/java/org/apache/isis/testdomain/conf/Configuration_usingJdo.java
    • -6
    • +0
    /examples/smoketests/src/main/java/org/apache/isis/testdomain/conf/Configuration_usingJdoAndShiro.java
    • -8
    • +1
    /examples/smoketests/src/main/java/org/apache/isis/testdomain/model/bad/Configuration_usingInvalidDomain.java
    • -8
    • +1
    /examples/smoketests/src/main/java/org/apache/isis/testdomain/model/good/Configuration_usingValidDomain.java
    • -0
    • +63
    /examples/smoketests/src/test/java/org/apache/isis/testdomain/domainmodel/SpecloaderPerformanceTest.java
7:26 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2086: refactors 'isis.viewer.wicket.liveReloadUrl' to type-safe config

Options
    • -0
    • +2
    /core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java
    • -58
    • +37
    /core/viewer-wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.java
7:24 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2086: refactors 'isis.viewer.wicket.dialogMode' and 'isis.viewer.wicket.dialogModeForMenu' to type-safe config

Options
    • -9
    • +21
    /core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java
    • -0
    • +26
    /core/config/src/main/java/org/apache/isis/viewer/wicket/ui/DialogMode.java
    • -26
    • +0
    /core/viewer-wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/DialogMode.java
    • -9
    • +4
    /core/viewer-wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/themepicker/ThemeChooser.java
    • -10
    • +4
    /core/viewer-wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.java
7:18 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2086: converts 'isis.viewer.wicket.themes.*' (3 of em) to type-safe config

Options
    • -3
    • +20
    /core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java
    • -0
    • +9
    /core/config/src/main/resources/META-INF/additional-spring-configuration-metadata.json
    • -15
    • +4
    /core/viewer-wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/themepicker/IsisWicketThemeSupport.java
    • -17
    • +9
    /core/viewer-wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/themepicker/IsisWicketThemeSupportDefault.java
7:00 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2086: refactors 'isis.viewer.wicket.breadcrumbs.showChooser' to type-safe config

Options
    • -0
    • +8
    /core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java
    • -2
    • +1
    /core/viewer-wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/footer/FooterPanel.java
    • -6
    • +1
    /core/viewer-wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/breadcrumbs/BreadcrumbPanel.java
    • -2
    • +1
    /core/viewer-wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.java
6:57 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2086: refactors 'isis.viewer.wicket.datePicker.minDate' and 'isis.viewer.wicket.datePicker.maxDate' to type-safe config

Options
    • -0
    • +15
    /core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java
    • -15
    • +8
    /core/viewer-wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/datepicker/TextFieldWithDateTimePicker.java
6:53 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2086: adds metadata for 'isis.viewer.wicket.credit.{1|2|3}.{url|name|image}

Options
    • -0
    • +39
    /core/config/src/main/resources/META-INF/additional-spring-configuration-metadata.json
    • -4
    • +4
    /core/viewer-wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/footer/FooterPanel.java
6:47 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2086: converts 'isis.viewer.wicket.bookmarkedPages.showChooser' to type-safe config

Options
    • -0
    • +6
    /core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java
    • -6
    • +0
    /core/viewer-wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/bookmarkedpages/BookmarkedPagesPanel.java
    • -6
    • +9
    /core/viewer-wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/PageAbstract.java
6:45 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2086: refactors 'isis.viewer.wicket.whereAmI.*' (2 of em) to type-safe config

Options
    • -0
    • +7
    /core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java
    • -7
    • +0
    /core/viewer-wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/models/whereami/WhereAmIModel.java
    • -13
    • +9
    /core/viewer-wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/models/whereami/WhereAmIModelDefault.java
6:40 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2086: converts 'isis.persistor.datanucleus.standaloneCollection.bulkLoad' to type-safe config

Options
    • -2
    • +11
    /core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java
    • -4
    • +1
    /core/viewer-wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/models/EntityCollectionModel.java
6:37 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2086: refactors 'isis.viewer.wicket.bookmarkedPages.maxSize' to type-safe config

Options
    • -0
    • +6
    /core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java
    • -5
    • +6
    /core/viewer-wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/models/BookmarkedPagesModel.java
6:34 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2086: declares isis.persistor.datanucleus.impl.javax.jdo.option.ConnectionURL in metadata

this can't be declared using type-safe config, because key must be called "ConnectionURL", (probably) not recognised by Spring.

Options
    • -0
    • +13
    /core/config/src/main/resources/META-INF/additional-spring-configuration-metadata.json
6:33 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2086: just reorders some of the config setting members for wicket

Options
    • -66
    • +80
    /core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java
6:30 am

danhaywood <dan@haywood-associates.co.uk>

ISIS-2086: refactors 'isis.viewer.wicket.*' to type-safe (about 6 of em)

Options
    • -1
    • +35
    /core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java
    • -74
    • +16
    /core/viewer-wicket/impl/src/main/java/org/apache/isis/viewer/wicket/viewer/IsisWicketApplication.java
Monday 30 Sep
11:28 pm

Andi Huber

ISIS-2158: spec-loading: fixing todo markers, removing hacks

Options
    • -0
    • +11
    /core/commons/src/main/java/org/apache/isis/commons/internal/debug/_Probe.java
    • -13
    • +5
    /core/metamodel/src/main/java/org/apache/isis/metamodel/spec/Hierarchical.java
    • -39
    • +21
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/specimpl/FacetedMethodsBuilder.java
    • -34
    • +60
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/specimpl/ObjectSpecificationAbstract.java
    • -11
    • +12
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/specimpl/dflt/ObjectSpecificationDefault.java
    • -4
    • +1
    /core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/traverser/SpecificationTraverser.java
    • -7
    • +3
    /core/metamodel/src/test/java/org/apache/isis/metamodel/testspec/ObjectSpecificationStub.java
    • -4
    • +5
    /core/plugins/jdo/common/src/main/java/org/apache/isis/jdo/metamodel/facets/object/query/VisitorForFromClause.java