Clone Tools
  • last updated 14 mins ago
Constraints: committers
Constraints: files
Constraints: dates
ISIS-1082: tiny update to docs re: externalizing configuration using Tomcat.

ISIS-1182: further tiny change to migration notes.

Merge branch 'ISIS-1182'

ISIS-1082: minor edits to docs

ISIS-1182: improving error messages in RegisterEntities. minor update to migration notes.

ISIS-1182: CreateSchema... listener now uses the PMF to obtain connection. Upgrading to released version of fast-classpath-scanner. Added migration notes.

ISIS-1182: refactoring ownership of list of services [ABORTIVE: the simpleapp runs up, but todoapp seems to hang?]

- make ServicesInjectorDefault hold the list of services, passed into PersistenceSessionFactory via

- IsisSystemUsingInstallers#obtainPersistenceSessionFactory

- PersistenceMechanismInstaller#createPersistenceSessionFactory

- IsisSystemAbstract#doCreateSessionFactory

- should call obtainServices and pass them to #createSessionFactory

move call to validate the services (@PostConstruct and @PreDestroy stuff):

- relocate to ServicesInjectorSpi

- moved from IsisSessionFactoryDefault (the validateServices method, can be made static quite easily), and don't call at end of its constructor

- call from IsisSystemAbstract (after adding the fallback FixtureScriptsDefault service)

- in IsisSystemAbstract, inline newIsisSessionFactory, no need to be separate

- ObjectReflectorDefault, split out initAndValidate so that validation is called not in the ObjectReflector's init, but instead by:

- IsisSystemFixturesHookAbstract, after calling sessionFactory#init()

  1. … 11 more files in changeset.
ISIS-1182: fixing issue with the schema not being created (because our CreateSchemaObjectFromClassMetadata listener wasn't being called by DN)...

... the reason being that the FastClasspathScanner, when it finds entities (in RegisterEntities), was then loading them via the ClassLoader. These classes, being enhanced, registered themselves with DN's internal EnhancementHelper#registerClass(...) - a static method. Somewhere along the line (perhaps because of the probe that DataNucleusApplicationComponents does to determine if it is running with a SchemaAwareStoreManager) it ended up so that DN knew about the entitiy when the PersistenceManagerFactory was created. Consequently (per other tickets raised recently on the DN JIRA), this meant that our listener was not called.

The fix is to use a different API in RegisterEntities that returns only the names of the classes that are annotated with @PersistenceCapable, and not the Class<?> themselves. This has a further benefit that the Class<?> aren't loaded, and neither do we bother to populate Isis' SpecificationLoader.

ISIS-1182: tidying up with the FCS implementation, deleting Reflections-related stuff.

ISIS-1182: spiking using fast-classpath-scanner.

ISIS-1051: updating doc for LayoutMetadataReader2.

ISIS-1051: FacetMethodsBuilder uses new LayoutMetadataReader2 interface to ask reader whether to attempt to load metadata for class. In addition...

In addition, the LayoutMetadataReaderFromJson now remembers whether it was able to find a layout.json file for a given class, and won't attempt to in future. Also doesn't use throw/catch of exceptions for control flow.

ISIS-1179: only call defaultXxx(...) once for action parameters.

ISIS-1173: menu separators were not appearing correctly on prototyping menu when the FixtureScriptsSpecificationProvider in use

Possibly an interaction with fix for ISIS-1175, or more likely just as result of missing annotations in the fallback FixtureScriptsDefault.

ISIS-1158: adding i18n support to Specification interface.

also added some documentation for specification, in the ref guide.

  1. … 12 more files in changeset.
Merge branch 'ISIS-1157_pr-33'


Add reference to SAFE_AND_REQUEST_CACHEABLE on error message

ISIS-1153: migrating to DN 4.1.2.


ISIS-1052: update contributors guide, moving IntelliJ plugins section to tips-n-tricks.

ISIS-1052: reference extended version of petclinic tutorial.

ISIS-1157: simplified design for SAFE_AND_REQUEST_CACHEABLE.

Instead add the caching to ActionInvocationFacetForDomainEventAbstract. No need for a new facet, just use the value of ActionSemanticsFacet.


- introduce new #isSafeInNature() to the SemanticsOf enum (also the deprecated equivalent ActionSemantics enum), which incorporates both #SAFE and #SAFE_AND_REQUEST_CACHEABLE

- go through codebase and change any hardcoded comparisons with SemanticsOf.SAFE (also the deprecated equivalent ActionSemantics enum) to use SemanticsOf#isSafeInNature() instead

- whether an action is bookmarkable

- whether concurrency checking should be performed

- a couple of uses in Restful Objects

- deprecate old #isSafe() method, since is potentially confusing

ISIS-1150: removed -r (--persistor) command flag support; removed PersistenceMechanismInstaller (pushed down into DataNucleusPersistenceMechanismInstaller).

ISIS-1150: mothballed the in-memory objectstore.

In addition, cosmetic change to all the pom.xml in isis/core, removed "Core" from name (since we don't have any separate components anymore).

  1. … 36 more files in changeset.
ISIS-1178: mothballing the tck tests.

    • -0
    • +226
    • -0
    • +19
    • -0
    • +40
    • -0
    • +137
  1. … 1144 more files in changeset.
ISIS-1178: moved first tranche of RO TCK tests to isis-app-kitchensink


ISIS-1177: fix for deserializing into RO applib using jackson.

ISIS-1175: fixing issue with menu separators disappearing in do force reload in Wicket viewer.

In addition, refactored ServiceActionsPanel and TertiaryActionsPanel, remove some of the duplication of code (moved to ServiceActionUtil class instead).

ISIS-1052: tiny CSS fix for prototype actions on menus.

ISIS-1052: fixing bad links.

ISIS-1052: adding new quote to index.html; converting "Isis" to "Apache Isis" throughout on index.html

    • -10
    • +28