Checkout Tools
  • last updated 53 mins ago
Constraints: committers
Constraints: files
Constraints: dates

Changeset 604385 is being indexed.

Refactor ftp_config out of win32, and out of unix in-tree builds.

FTP_APXS_BUILD is hiding in Makefile.apxs, and won't otherwise

be defined.

  1. … 13 more files in changeset.
Clean this up for good, and hold on to basefsc for multiple purposes

(not only limitdbfile, but future changes for a root port daemon).

no var declarations after function calls.

Group <directory> directives to the end of the cmd table

Honor const'ness

According to mod_ftp.xml, LimitDBFile is global, while the

specific Limit directives are permitted per-vhost. Drop the

invalid context checks for those related directives, and

greatly simplify the global LimitDBFile logic and save a ton

of cycles at startup.

FTPEPSVIgnoreFamily is the sort of directive that a typical installation

would use globally or not at all, depending on the physical topography.

Drop the no-inherit aspect of epsv_ignore_family.

  1. … 1 more file in changeset.
Refine EPSV behavior and add a new directive, FTPEPSVIgnoreFamily,

which allows the user confronted by firewall NAT translation to

simply accept either AF IPv4 or IPv6 and listen on the client's

connected port. Because some NAT's are going to present an address

family other than the one the client believed it's using, this is

an important override to avoid firewall/routing/nat issues.

Because EPSV never reports a desired IP address, it's a bad idea

for us to support any aspect of the FTPPASVbindaddr feature.

  1. … 2 more files in changeset.
Limit active and pasv port range to a ushort, and ensure

these are not negative (we permit 'port 0' only to override

a globally declared explicit range with the ephemeral range).

Filter ordering is still flakey, and not actually required AFAICT (certainly,

not NULL filter ordering!)

Clean up ftp_module declaration syntax.

Uhm - FTPUMask FTPDirMask are -always- supported (possibly not well, but

that's an apr issue). FTPUmask happens to be less-lame with fchmod, but

it's not impossible otherwise. With fchmod, the file perms are 000 as the

file is initally accumulated, and then switched. Without, the perms are

determined at create-time.

removed tabs and trailing spaces.

The scope of FTPDirMask and FTPUMask are much more dir-centric than server-centric.

Refactor them out of the server_conf scope into the dir_conf scope.

  1. … 1 more file in changeset.