Checkout Tools
  • last updated 7 hours ago
Constraints: committers
Constraints: files
Constraints: dates
The process_connection hook for mod_ftp must run before the process_connection

hook(s) for mod_http2 because http2 attempts a 24-byte speculative read. FTP

connections don't send headers, so mod_http2 hangs until this read times out.

http2's hook cannot be registered as a successor to ftp's because there are two mod_http2

process_connection hook functions. This change makes mod_ftp register as APR_HOOK_FIRST

and before mod_ssl & mod_reqtimeout to ensure that it runs before any other

protocol handlers.

Use the httpd-2.4 API function ap_get_conn_socket to set the socket timeout.

This has been wrong since 2.4, and the socket timeout hasn't been set correctly.

mod_ftp segfaults after httpd change r1839997 because setting the timeout

clobbers the filter context.

Set the useragent_addr and useragent_ip values from the connection

when creating a new request_rec. This enables use of the

Require ip authorization directive, which needs useragent_addr.

Avert constant svn mismatch by -not- embedding build time in the composite
Introduce the HOST command (and XWEL command for diagnostics), and support for

TLS-SNI provided hostname via an implicit HOST invocation. Corrects headers

and fields to ensure the host names are initialized at the appropriate times,

and that the orig_server maps to the correct host. This is known to work

correctly with the latest Filezilla (uses SNI by default), for both Explicit

and Implicit SSL connections on httpd-2.2, but the SSL logic is known to be

broken for the data channel on httpd-2.4 (likely not a regression).

  1. … 2 more files in changeset.
Fix AIX compile error for ap_log_error macro, similar to PR 52394
Introduce 2.4 logging mechanics
This information resides in NOTICE
This information resides in NOTICE
Fix language syntax foobar
This Copyright is already preserved in NOTICE-FTP as well as in svn history
  1. … 6 more files in changeset.
Quiet an error in what's actually a NOOP at the present time

Our input filter is a core filter, need to restore this 'hidden' declaration
  1. … 1 more file in changeset.
A workaround for client_ip in 2.4 compatibility
Catch up with 2.2.29 for r->trailers[in|out] with mod_ftp
Resolve a crash-bug in RETR/REST when the client would terminate

the retrieval in interesting ways. Ensure we linger close prior

to reverting the filter stack.

Many thanks to Mikhail T for crash dump results and testing of

this fix.

  1. … 1 more file in changeset.
Cleanup effort in prep for GA push:

Trim trailing whitespace... no func change

Cleanup effort in prep for GA push:

Trim trailing whitespace... no func change

  1. … 1 more file in changeset.
Cleanup effort in prep for GA push:

Trim trailing whitespace... no func change

  1. … 6 more files in changeset.
Revert my local work on apr TOS options miscommitted in r1055260
Vote failed, not released
  1. … 1 more file in changeset.
Trouble with testing unix changes on win32; fix abbreviation of conn_rec
Pass the original server_rec to lowportd, it does not need the

document_root as munged by login when using FTPJailUser.

  1. … 1 more file in changeset.
fixed comment.

Fix Rainer's observed compiler warnings, follow unixd.c formatting choice
Add the new HAVE_SYS_STAT_H entry
Prepare to test for sys/stat.h; although this appears to be almost universal,

and in most places httpd neglects to test for it, at all (likewise with apr),

introducing the test seems sanest.

  1. … 2 more files in changeset.
Revert r816074.

Wait for result of apr discussion about APR_HAVE_SYS_STAT_H


Revert r816061 and instead follow along the lines

of r782531.

APR currentyl doesn't correctly define APR_HAVE_SYS_STAT_H.

So fall back to HAVE_SYS_STAT_H as a second option.


- implicit declaration of function 'fchmod'

- 'S_I[RWX](USR|GRP|OTH)' undeclared

At least on Solaris we need sys/types.h and sys/stat.h.

sys/types.h already get included, but stat.h is missing.