Checkout Tools
  • last updated 5 hours ago
Constraints: committers
Constraints: files
Constraints: dates
convert malloc(3) into ap_malloc

bz 64049

  1. … 4 more files in changeset.
Fix spelling errors found by codespell. [skip ci]

  1. … 100 more files in changeset.
mpm_winnt: Advertise support for preshutdown notifications in the service,

and perform shutdown in respond to SERVICE_CONTROL_PRESHUTDOWN.

The pure shutdown notification leaves a small amount of time for the service

to finish (and the allowed amount of time has been shrinking with every new

version of Windows), and handling only it increases the chance of the process

being killed by SCM, instead of gracefully shutting down. Handling the

preshutdown control code extends this period, and increases the chances of

finishing everything properly when the machine is rebooted or shut down.


Please note that although the preshutdown notifications are available only

starting from Windows Vista, the code is compatible with the previous versions

of Windows, since the SCM ignores unknown SERVICE_ACCEPT codes, and will

still send an ordinary SERVICE_CONTROL_SHUTDOWN under old Windows


winnt/service: each log message should use its own APLOGNO.
  1. … 1 more file in changeset.
Fix spelling in comments and text files.

No functional change.

PR 59990

  1. … 69 more files in changeset.
As noted by Yann, this resulted in a dead var assignment. Preinit won't

work due to the fact that we overload rv as both the DWORD windows result

and the apr_status_t result code.

mpm_winnt: Accept utf-8 (Unicode) service names and descriptions for


  1. … 1 more file in changeset.
General whitespace cleanup, error message normalization, and style conformance

for 80 character folding and legibility.

Folds several identical errors into the same APLOGNO() groups.

Catches several errors which were missing APLOGNO() entries, in the

existing groups and in one new message.

  1. … 1 more file in changeset.
cppCheck: same expression on both side of '|'.

Fix it the same way other messages are managed in the function.

Add lots of unique tags to error log messages

  1. … 172 more files in changeset.
Cleanup effort in prep for GA push:

Trim trailing whitespace... no func change

  1. … 118 more files in changeset.
Not possible; you don't declare a variable const and then

maniuplate it.

match expected type of arg to StartService()

axe ap_registry_get_server_root(), which seems to have been unused

after httpd 1.3

can't format time_t with %d; cast this small interval time to int

yank some dead code and variables

  1. … 2 more files in changeset.
cleanups to function signatures, prototypes, visibility

  1. … 5 more files in changeset.
fix some grammar mistakes, mostly in comments

  1. … 12 more files in changeset.
Axed C++ comments and tabs.

  1. … 3 more files in changeset.
Correct constness fix to manipulate our copy
Some minor fixes to provide protos and build with Watcom.
  1. … 2 more files in changeset.
Use the new APLOG_USE_MODULE/AP_DECLARE_MODULE macros everywhere to take

advantage of per-module loglevels

  1. … 169 more files in changeset.
Drop exit value (always NO_ERROR, needs work). Pass about the service context
Pick up earlier SHUTDOWN notification
Move comment block closer to related function.

No functional change.

Further Win9x code elimination and simplification
  1. … 1 more file in changeset.
Drop support for Service Description labels from < Win2000
Axe Win9x codepath, including Win32DisableAcceptEx logic. Starting clean.
  1. … 7 more files in changeset.
The next of several helper threads which do not need a default 1GB stack
Remove all references to CORE_PRIVATE.

  1. … 67 more files in changeset.