Checkout Tools
  • last updated 2 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Add missing pool tags to help debugging.
  1. … 41 more files in changeset.
malloc -> ap_malloc

bz #63967

Fix spelling errors found by codespell. [skip ci]

  1. … 100 more files in changeset.
MPMs: early initialize scoreboard's child generation number.

Since [mpm]_note_child_killed uses the scoreboard's generation number for

child_status hook (MPM_CHILD_EXITED), we must initialize it early (i.e. in

[mpm]_note_child_started where MPM_CHILD_STARTED is set) to avoid race

conditions on restart (e.g. storm/loop of restarts) leading to AH00546.

PR 62658.

  1. … 5 more files in changeset.
mpm_winnt: remove the AcceptEx data network bucket

Follow-up to the prior commit: without an incoming data buffer, the

custom network bucket code is now orphaned and we can remove it

entirely. This has the added benefit that we are no longer using the

internal OVERLAPPED.Pointer field, which is discouraged by the MSDN


  1. … 2 more files in changeset.
Fix spelling in comments and text files.

No functional change.

PR 59990

  1. … 69 more files in changeset.
mpms: follow up to r1629925: more error reports.

Failing to setup (or no) listeners is also an error.

  1. … 4 more files in changeset.
Join multi-line MPM startup log messages into

single long lines.

Followup to r1725394 and r1725548.

  1. … 6 more files in changeset.
Added many log numbers to log statements that

had none.

Handled all files in server/mpm/.

I used the coccinelle script provided by Stefan.

  1. … 6 more files in changeset.
mpm_winnt: make AP_MPMQ_GENERATION available in the child process as soon

as possible, so that hooks/modules can query it at config stage.

This is (e.g.) needed by r1702501 for PR 58024.

core: Follow up to r1599601: s/ap_log_common/ap_log_mpm_common/.
  1. … 9 more files in changeset.
core: ensure that MPMs return an error on runtime failure and hence that

httpd's main process also exits with an error.

  1. … 9 more files in changeset.
Now allow MPMs to call ap_log_common()

  1. … 5 more files in changeset.
more apr_file_write_full() simplification (like r1542413)

  1. … 5 more files in changeset.
WinNT MPM: Exit the child if the parent process crashes or is terminated.

Submitted by: Oracle, via trawick

The original modification was made some years ago for Oracle HTTP Server

by an Oracle employee. trawick made additional changes for style and

for trunk/2.4.x changes.

  1. … 4 more files in changeset.
WinNT MPM logging:

clarify when it is the child process event handle being logged

log the child process id in a few obvious places

use state query API instead of static counters to determine processing

phase in check_config and post_config hooks

the rest of r1374877

minor cleanups

- don't duplicate prototype for child_main()

- make a few things static

WinNT MPM: Store pid and generation for each thread in scoreboard

to allow tracking of threads from exiting children via mod_status

or other such mechanisms.

  1. … 3 more files in changeset.
Windows: Fix output of -M, -L, and similar command-line options

which display information about the server configuration.

  1. … 1 more file in changeset.
Replace ap_create_core_ctx()/ap_core_ctx_get_bb() with a hook

  1. … 7 more files in changeset.
Add lots of unique tags to error log messages

  1. … 172 more files in changeset.
Downgrade to DEBUG level several messages which were all redundant

to these NOTICE level messages;

Child: Starting %d worker threads

Child: All worker threads have exited

  1. … 1 more file in changeset.

Resolve server and remote IP's in the AcceptFilter 'none' path.

Lower the volume on a number of debug messages (and omit errno

where we have no errno).

  1. … 2 more files in changeset.
Cleanup effort in prep for GA push:

Trim trailing whitespace... no func change

  1. … 118 more files in changeset.
WinNT MPM has hard-coded daemon limit of 1, not 0

trunk mod_status relies on this value for proper formatting

of the workers; now we see '-' for the idle WinNT MPM workers

instead of ' '

Add child_status hook for tracking creation/termination of MPM child

processes. Add end_generation hook for notification when the last

MPM child of a generation exits.

end_generation is implemented completely by core using the

child_status hook run by the MPM.

simple and mpmt_os2 MPMs don't currently run the child_status

hook, so neither hook is invoked with those MPMs.

  1. … 11 more files in changeset.

mpm_winnt.c: Fail to compile if enabled, and add a hint about the

issue to address before it will work. Move the --enable-v4-mapped check to below the

MPM logic, and default to --disable-v4-mapped if

using the WinNT MPM

  1. … 1 more file in changeset.
add some debug logging to show more information about passing of sockets

between parent and child

the extra info is helpful when using a generic listener on an IPv6-

enabled box when either IPV6_V6ONLY isn't defined for the APR build

or httpd is built with IPv4-mapped addresses enabled

in that case you'll see the parent writing one socket but the child

expecting too, before it bails out with

(OS 109)The pipe has been ended. : Child: Unable to read socket data

from parent

axe the cast in the call to our mpm_nt_eventlog_stderr_open()

by fixing the function

  1. … 2 more files in changeset.