Checkout Tools
  • last updated 6 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Fix spelling errors found by codespell. [skip ci]

  1. … 100 more files in changeset.
mpms: follow up to r1629925: more error reports.

Failing to setup (or no) listeners is also an error.

  1. … 4 more files in changeset.
Join multi-line MPM startup log messages into

single long lines.

Followup to r1725394 and r1725548.

  1. … 6 more files in changeset.
Added many log numbers to log statements that

had none.

Handled all files in server/mpm/.

I used the coccinelle script provided by Stefan.

  1. … 6 more files in changeset.
s/a a/a/g

  1. … 1 more file in changeset.
core: ensure that MPMs return an error on runtime failure and hence that

httpd's main process also exits with an error.

  1. … 9 more files in changeset.
Add lots of unique tags to error log messages

  1. … 172 more files in changeset.
Rename MaxClients to MaxRequestWorkers which describes more accurately what

it does.

  1. … 14 more files in changeset.
the mpm-note-child-killed hook is just for state sync between

ap_{reclaim,relieve}_child_processes() and their callers

the NetWare and OS/2 MPMs don't use that

  1. … 1 more file in changeset.
mpm_common.c implements a handful of config directives; the

related state has to be re-initialized to the default values

at pre-config time, but that was handled inconsistently by

the MPMs, resulting in unexpected behavior when some of the

directives were removed across restart

move that necessary initialization from the MPMs to common

code run from core's pre-config; MPMs that need to override

defaults can do so by running after core's pre-config (the

NetWare MPM now does that)

the DEFAULT_MAX_REQUESTS_PER_CHILD compile setting wasn't useful

enough to keep

the simple MPM wasn't consistent in which of these directives

were respected and which weren't, and that hasn't changed

(see procmgr.max_requests_per_child vs. ap_max_requests_per_child)

  1. … 15 more files in changeset.
ap_max_requests_per_child is a global

(otherwise, this local one doesn't match the one used by the OS/2 child

code or the MaxConnectionsPerChild directive)

consolidate logic to remove the pidfile in a new API,

ap_remove_pid(), related to existing ap_log_pid() and


presumably this is useful to third-party MPMs as well

  1. … 7 more files in changeset.
Remove definition of ap_pid_fname from OS/2 MPM. It's now in mpm_common.c.

Use the new APLOG_USE_MODULE/AP_DECLARE_MODULE macros everywhere to take

advantage of per-module loglevels

  1. … 169 more files in changeset.
remove dead code related to the accept mutex

  1. … 4 more files in changeset.
Brind OS/2 MPM up to date with current API.

  1. … 4 more files in changeset.
Bring OS/2 MPM back from the dead.

Reverses r758899.

  1. … 16 more files in changeset.
Remove all references to CORE_PRIVATE.

  1. … 67 more files in changeset.
Remove ap_graceful_stop_signalled from all MPMs.

  1. … 8 more files in changeset.
Revert r547987 ("svn merge -c -547987 .")

  1. … 17 more files in changeset.
PID table impl: parent process keeps a local table store of

Apache child process PIDs and uses that to check validity

of what's in the scoreboard.

  1. … 17 more files in changeset.
Replace ap_get_server_version with ap_get_server_banner() and


High-level summary:

The full server version information is now included in the error log at

startup as well as server status reports, irrespective of the setting

of the ServerTokens directive.

Third-party modules must now use ap_get_server_banner() or

ap_get_server_description() in place of ap_get_server_version().

  1. … 27 more files in changeset.
Introduce a check_config phase between pre_config and open_logs,

to allow modules to review interdependent configuration directive

values and adjust them while messages can still be logged to the


The open_logs phase is already used somewhat for this purpose by

certain MPMs (winnt, prefork, worker, and event) but only by forcing

their functions ahead of the core ap_open_logs() function, and

since this phase runs after the ap_signal_server function during startup,

it can not be used to generate messages on the console when restarting.

Add the check_config phase to mod_info and mod_example.

Handle relevant MPM directives during this phase and format messages

for both the console and the error log, as appropriate. Bounds and sanity

checks on the values of the MPM directives are handled in sequence in

this phase instead of in the various directive handling functions, since

those functions (e.g., set_max_clients()) may not be called at all if their

directives do not appear in the configuration files, and even if they

are called, there is no guarantee that this will occur in any particular


Remove from the worker and event MPMs the code in the pre_config phase

that alters the configuration node tree by re-ordering ThreadsPerChild

ahead of MaxClients. This code is effective but insufficient; for

example, if ServerLimit follows MaxClients, the test against server_limit

in set_max_clients() is invalid. (In practice, this only results in

incorrect or absent warnings on the console, because server_limit is

set to its configured value when the main loop re-runs the configuration


Prevent ap_threads_per_child from exceeding thread_limit in the

winnt, worker, and event MPMs. This situation could occur if

ThreadsPerChild was not specified in the configuration files and

ThreadLimit was set to a value smaller than DEFAULT_THREADS_PER_CHILD,

because set_threads_per_child() would never be called and therefore

its bounds check against thread_limit would not be performed.

Remove from the winnt, prefork, worker, and event MPMs the

changed_limit_at_restart flag. Set the first_server_limit and

first_thread_limit values during the first execution of the check_config

function, and use them to detect changes to ServerLimit and ThreadLimit

across restarts and issue appropriately formatted warnings. Remove the

comments about the error log being a "bit bucket"; this was true when

the code was originally committed in r92530 but that was due to a bug

fixed in r92769.

Be consistent about setting all MPM configuration directive values in the

pre_config phase.

Rephrase and reformat the console and log file messages relating to

MPM configuration directives to be consistent across all MPMs. Use

briefer messages when logging to the error log than to the console.

Update miscellaneous stale comments and messages (e.g., reference to

daemons_min_free in worker and event MPMs, "prefork open_logs" in

winnt MPM, and StartServers in netware MPM).

The winnt, netware, beos, and mpmt_os2 MPMs should be tested by developers

with access to those platforms, especially the winnt MPM, which has

unique logic with respect to distinguishing between parent and child

processes during the configuration phases.

Update the English documentation for the worker MPM's ThreadsPerChild

directive, which no longer needs to precede other MPM directives in the

configuration files if it has a non-default value. The German (.de) and

Japanese (.ja) translations should be updated by developers fluent in

those languages.

  1. … 13 more files in changeset.
update license header text
  1. … 316 more files in changeset.
Update the copyright year in all .c, .h and .xml files

  1. … 497 more files in changeset.
No functional change: remove "internal" tab spacing/formatting.

  1. … 32 more files in changeset.
No functional Change: Removing trailing whitespace. This also

means that "blank" lines consisting of just spaces or

tabs are now really blank lines

  1. … 180 more files in changeset.
No functional change: simple detabbing of indented code.

  1. … 72 more files in changeset.
Update copyright year to 2005 and standardize on current copyright owner line.

  1. … 522 more files in changeset.
general property cleanup

  1. … 712 more files in changeset.