Checkout Tools
  • last updated 4 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Slighly simplify code.

No need to set to NULL or 0 fields that are apr_pcalloc'ed.

Axe 'set_cookie_enable' and use 'ap_set_flag_slot' instead.

(based on ideas taken from r1874389)

Remove duplicated "CookieTracking" directive in 'command_rec'.
* Another whitespace fix
* Whitespace fix
PR64077: samesite/httponly/secure flags for usertrack

Submitted By: Prashant Keshvani <prashant2400>, Eric Covener

Committed By: covener

  1. … 2 more files in changeset.
Remove some useless 'return' statements.
Save a few bytes of memory. This can be done in temp_pool.
Various code cleanup to avoid compiler, cppcheck, or clang warnings:

modules/debugging/mod_firehose.c: Make some internal functions static

(to do: logs_cleanup() is unused)

modules/filters/mod_charset_lite.c: Remove dead assignments

modules/filters/mod_include.c: likewise

modules/metadata/mod_usertrack.c: likewise

modules/proxy/mod_proxy_ftp.c: likewise

modules/ssl/ssl_engine_pphrase.c: likewise

modules/proxy/mod_proxy_balancer.c: likewise;

Remove NULL check that can never happen

modules/proxy/proxy_util.c: Axe NULL-check that can never happen and if it

would, it would just mask another bug

os/unix/unixd.c: likewise

modules/http/http_filters.c: Remove sub-condition that is always true

modules/lua/mod_lua.c: Add default cases to switch statements

modules/generators/mod_autoindex.c: Unsigned value can never be < 0

server/util_expr_eval.c: Fix compiler warnings with VC and on OS2

  1. … 12 more files in changeset.
Add lots of unique tags to error log messages

  1. … 172 more files in changeset.
Use random value instead of remote IP address in cookie value. This has the

advantage that we don't leak internal IP addresses in reverse proxy setups.

Also, use hex to make the cookie shorter.

  1. … 1 more file in changeset.
More checks of ap_pregsub return values

PR29755: mod_usertrack gets skipped when modules return a status code from

their fixup hook, and headers are also not sent on non-2xx responses.

Submitted by: Sami J. Mäkinen

Reviewed by: Eric Covener (modified to just run REALLY_FIRST)

  1. … 1 more file in changeset.
more temp pool usage and remove some useless apr_pstrdup()s

  1. … 5 more files in changeset.
remove some useless use of strlen()

  1. … 2 more files in changeset.
Use the new APLOG_USE_MODULE/AP_DECLARE_MODULE macros everywhere to take

advantage of per-module loglevels

  1. … 169 more files in changeset.
update license header text
  1. … 316 more files in changeset.
Update the copyright year in all .c, .h and .xml files

  1. … 497 more files in changeset.
No functional change: remove "internal" tab spacing/formatting.

  1. … 32 more files in changeset.
No functional Change: Removing trailing whitespace. This also

means that "blank" lines consisting of just spaces or

tabs are now really blank lines

  1. … 180 more files in changeset.
No functional change: simple detabbing of indented code.

  1. … 72 more files in changeset.
Move the POSIX reg* implementations into the ap_* namespace;

internalise the ap_reg*<->PCRE wrapper:

* Add srclib/pcre to the include path.

* include/ap_regex.h: Renamed from include/pcreposix.h. Prefix all

constants with AP_; prefix all functions and types with ap_. Define

AP_DECLARE to nothing if necessary. Remove regcomp error codes.

* include/httpd.h: Include ap_regex.h not pcreposix.h.

(ap_pregcomp, ap_regexec, ap_regfree): s/regex_t/ap_regex_t/.

(ap_regexec, ap_regerror): Prototypes moved to ap_regex.h.

* server/util.c (regex_cleanup, ap_pregcomp, ap_pregsub, ap_pregfree):

Adjust for ap_ prefixed types. (ap_regexec, ap_regerror): Removed.

* server/ Build util_pcre.c.

* server/util_pcre.c: Copied from srclib/pcre/pcreposix.c; remove use

of PCRE-internals to do error mapping; rename types to add AP_/ap_

prefixes as above. Use APR includes. (ap_regerror): Use apr_snprintf.

* srclib/pcre/ Don't build pcreposix.c into

* modules/*: Update to use new type and constant names.

PR: 27750 (part one)

Submitted by: Andres Salomon <dilinger>, Joe Orton

  1. … 25 more files in changeset.
Update copyright year to 2005 and standardize on current copyright owner line.

  1. … 522 more files in changeset.
general property cleanup

  1. … 712 more files in changeset.
Just a simple switch of mod_usertrack to run earlier in the fixup hook.

PR: 29755

  1. … 1 more file in changeset.
Fix a bunch of cases where the return code of the regex compiler

was not checked properly. This affects: mod_setenvif, mod_usertrack,

mod_proxy, mod_proxy_ftp and core.

PR: 28218

  1. … 5 more files in changeset.
escape the cookie_name before pasting into the regexp.

  1. … 1 more file in changeset.
let's be more lenient, in what we accept.

commas are allowed as separators and whitespaces are not a must.

Fix bug in mod_usertrack when no CookieName is set.

PR: 24483

Submitted by: Manni Wood <manniwood>

Reviewed by: Cliff Woolley, Jim Jagielski

  1. … 1 more file in changeset.
fix name of The Apache Software Foundation

  1. … 361 more files in changeset.
fix copyright dates according to the first check in

  1. … 25 more files in changeset.