Checkout Tools
  • last updated 4 hours ago
Constraints: committers
Constraints: files
Constraints: dates

Changeset 1790457 is being indexed.

Fix directive name in


Use cmd->cmd->name instead to be future proof.

Rename RemoteIPProxyProtocolDisableHosts to RemoteIPProxyProtocolExceptions
  1. … 1 more file in changeset.
Update PROXY handling by removing Optional processing
  1. … 1 more file in changeset.
Finally include feedback from Ruediger Pluem. Add slave "backoff" verified by Sander Hoentjen
Change tactic for PROXY processing in Optional case
  1. … 1 more file in changeset.
* modules/metadata/mod_remoteip.c (register_hooks,

remoteip_hook_pre_connection): Reference the filter by handle rather

than name (avoiding tree lookup by name on use).

* modules/metadata/mod_remoteip.c: Fix GCC strict-aliasing warning

by moving deference of header array via a different pointer type

("type-punning") out of line.

Set all read buckets aside in case we need to restore all during optional header processing
* Silence compiler warning
Reinsert attribution to mod_remoteip.c for PROXY protocol
On the trunk:

* mod_remoteip: added cast to fix clang compiler error

Move attribution for mod_remoteip RemoteIPProxyProtocol from file to CHANGES
  1. … 1 more file in changeset.
Shorten RemoteIPProxyProtocolEnable to RemoteIPProxyProtocol and correct references in docs
  1. … 6 more files in changeset.
Merge new PROXY protocol code into mod_remoteip
  1. … 2 more files in changeset.
mod_remoteip: Set useragent port to zero PR59931

When overriding the useragent address from X-Forwarded-For,

zero out what had been initialized as the connection-level port.

Submitted By: Hank Ibell <hwibell>

  1. … 1 more file in changeset.
mod_remoteip: Use r->useragent_addr as the root trusted address for verifying.

This fixes issue resulting in setting of bad useragent_ip when internal

redirection has been generated as response to the request (typically as

result of "ErrorDocument 40x").

In this case, the original request has been handled by mod_remoteip and its

useragent_ip has been changed properly, but when internal redirection

to ErrorDocument has been generated later, the mod_remoteip's handler has been

executed again with *the same* c->client_addr as in the original request. If

c->client_addr IP is trusted, this results in bad useragent_ip being set.

When using r->useragent_addr as the root trusted address instead of

c->client_addr, the internal redirection uses the first non-trusted

IP in this particular case, so it won't change the r->useragent_ip during

the internal redirection to ErrorDocument.

Prevent an external proxy from presenting an internal proxy

in mod_remoteip.c. PR 55962.

  1. … 1 more file in changeset.
Use the correct IP addresses to populate the proxy_ips field

in mod_remoteip.c. PR 55972.

  1. … 1 more file in changeset.
Correct the trusted proxy match test in mod_remoteip. PR 54651.\n\nSubmitted By: Yoshinori Ehara <yoshinori ehara gmail com>\nEndorsed By: Eugene L <eugenel amazon com>\nCommited By: mrumph
  1. … 1 more file in changeset.
s/equivalant/equivalent/ in comments
  1. … 1 more file in changeset.
Remove redundant check
s/ip/IP/ in comments
Close file in error path.
Use %pm available since apr 1.3 instead of an extra call to apr_strerror

  1. … 5 more files in changeset.
remove warning:

mod_remoteip.c:404:38: warning: data argument not used by format string [-Wformat-extra-args]

It's a hack, but maintain the orig hack ;)

Downgrade log message about adjusted IP address to trace1

Further clarify the naming of the entity that directly connects to us by

calling that entity a client instead of a peer.

  1. … 15 more files in changeset.
Further clarify the naming of the entity that originates the request by

calling that entity a useragent instead of a client.

  1. … 14 more files in changeset.
Remove usage of APLOG_NOERRNO. It has been a no-op since at least 2.0.x

  1. … 5 more files in changeset.
Add lots of unique tags to error log messages

  1. … 172 more files in changeset.