mod_mime_magic.c

Checkout Tools
  • last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add missing pool tags to help debugging.
  1. … 41 more files in changeset.
Fix spelling errors found by codespell. [skip ci]

  1. … 100 more files in changeset.
* modules/metadata/mod_mime_magic.c: Constify some constant

data, remove unused "suf_recursion" field. No functional

change.

Fix remaning compilation warning when MIME_MAGIC_DEBUG is defined.

Style is not perfect, but at least, the warning is fixed.

warning: format ‘%c’ expects argument of type ‘int’, but argument 10 has type ‘long unsigned int’ [-Wformat=]

Fix some compilation warning when MIME_MAGIC_DEBUG is defined.

warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument <n> has type ‘<something> *’ [-Wformat=]

Fix spelling in comments and text files.

No functional change.

PR 59990

  1. … 69 more files in changeset.
Reduce stack usage by 3k
According to comment in 'magic_rsl_add' and to the way 'magic_rsl_printf' manages its buffer, I think that this memory should be apr_pstrdup'ed.

This has been like that forever, but seems broken to me.

Untested.

Add lots of unique tags to error log messages

  1. … 172 more files in changeset.
Fix issues found by PVS-Studio static analyzer:

mod_mime_magic:

cut'n'paste error rsl_encoding vs. rsl_separator, also simplify code a bit

mod_header:

wrong string initialization (leading to segfault if format argument is missing)

util_win32: duplicate sizeof (untested; Windows people, please review)

PR: 51542

Submitted by: Andrey Karpov <karpov viva64 com>, Stefan Fritsch

  1. … 2 more files in changeset.
Intel's compiler warns about assigning the non-enum value 0 to the

enumeration apr_finfo_t.filetype, which is done when forgetting

the previously-derived file type

use the appropriate enum value APR_NOFILE instead

Also change comparisons of the field with 0 to use APR_NOFILE instead,

as is the practice of some existing code.

  1. … 14 more files in changeset.
Code cleanup: replace strncpy by apr_cpystrn or apr_pstrmemdup

Submitted by: Takashi Sato <takashi lans tv com>

PR: 43432

  1. … 3 more files in changeset.
Use the new APLOG_USE_MODULE/AP_DECLARE_MODULE macros everywhere to take

advantage of per-module loglevels

  1. … 169 more files in changeset.
When trying to detect the content type of the

uncompressed content it is often not enough

to read the same number of bytes, we already

read compressed. Since uncompress() allocates a

new buffer, we can increase the number of bytes

to read to the same size, we use in the case,

where the content isn't compressed.

Furthermore zero-terminate the read data to keep

assumptions consistent with the uncompressed case.

Set the content encoding for compressed content

even if we can't detect the content type of the

uncompressed content.

Creating the external gzip process fails, because we

call execve() with "gzip" without full path.

Let's look for it in the PATH instead and drop the

passing of the environment. There seems to be no

reason why gzip should need the httpd environment.

Creation of external gzip process fails, if we

try to set the working directory to r->filename.

Use ap_make_dirstr_parent() instead, like in all

other similar places.

Whitespace cleanup before doing other changes.

* modules/metadata/mod_mime_magic.c: Constify some constant data.

(magic_rsl_puts, magic_rsl_add): Update accordingly.

* Fix precedence problem.

PR: 40656

Submitted by: Larry Cipriani <lvc lucent.com>

Reviewed by: rpluem

  1. … 1 more file in changeset.
update license header text
  1. … 316 more files in changeset.
Update the copyright year in all .c, .h and .xml files

  1. … 497 more files in changeset.
No functional change: remove "internal" tab spacing/formatting.

  1. … 32 more files in changeset.
No functional Change: Removing trailing whitespace. This also

means that "blank" lines consisting of just spaces or

tabs are now really blank lines

  1. … 180 more files in changeset.
No functional change: simple detabbing of indented code.

  1. … 72 more files in changeset.
rewrite CR mitigation logic to wipe out any trailing

white space

Suggested by: wrowe

mod_mime_magic: Handle CRLF-format magic files so that it works with

the default installation on Windows.

  1. … 1 more file in changeset.
Update copyright year to 2005 and standardize on current copyright owner line.

  1. … 522 more files in changeset.
general property cleanup

  1. … 712 more files in changeset.
fix name of The Apache Software Foundation

  1. … 361 more files in changeset.