Checkout Tools
  • last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix a typo
* modules/metadata/mod_remoteip.c (remoteip_process_v2_header,

remoteip_input_filter): Add sanity checks.

Submitted by: jorton, Daniel McCarney <cpu letsencrypt.org>

* modules/metadata/mod_mime_magic.c: Constify some constant

data, remove unused "suf_recursion" field. No functional

change.

This is harmless, but this really should be an 'echo_do *'
mod_remoteip: Fix RemoteIP{Trusted,Internal}ProxyList loading broken by 2.4.30.

Overwriting server config in pre_config hook breaks EXEC_ON_READ directives,

it's automatically created on purpose anyway.

PR 62220.

  1. … 1 more file in changeset.
copy apr_sockaddr_is_wildcard to maintain 1.4.x support.

mod_remoteip: make proxy-protocol work on slave connections, e.g. in HTTP/2

requests. See also https://github.com/roadrunner2/mod-proxy-protocol/issues/6

  1. … 1 more file in changeset.
some small tweaks to get things building again

replace mod_socache_redis.dsp as original was corrupted

  1. … 2 more files in changeset.
avoid ap_set_content_type when processing a _Request_Header set|edit|unset Content-Type.

identified by ylavic

  1. … 1 more file in changeset.
PR 61983: "Header unset Content-Type" doesn't work

Submitted By: Hank Ibell <hwibell gmail.com>

Committed By: covener

  1. … 1 more file in changeset.
APR-ize uint types

Fix format pattern (%lu => %APR_SIZE_T_FMT).

Detected by maintainer mode compilation and GCC error:

.../modules/metadata/mod_remoteip.c:

In function 'remoteip_input_filter':

.../include/http_log.h:117:33:

error: format '%lu' expects argument of type

'long unsigned int', but argument 8 has type

'apr_size_t {aka unsigned int}' [-Werror=format=]

PROXY protocol proposal corrections
  1. … 1 more file in changeset.
Fix remaning compilation warning when MIME_MAGIC_DEBUG is defined.

Style is not perfect, but at least, the warning is fixed.

warning: format ‘%c’ expects argument of type ‘int’, but argument 10 has type ‘long unsigned int’ [-Wformat=]

Fix some compilation warning when MIME_MAGIC_DEBUG is defined.

warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument <n> has type ‘<something> *’ [-Wformat=]

Remove empty line.
When processing a 'SetEnv' directive, warn if the environment variable name includes a '='. It is likely a configuration error. PR 60249
  1. … 2 more files in changeset.
Fix directive name in

(s/RemoteIPProxyProtocolDisableNetworks/RemoteIPProxyProtocolExceptions/)

Use cmd->cmd->name instead to be future proof.

Rename RemoteIPProxyProtocolDisableHosts to RemoteIPProxyProtocolExceptions
  1. … 1 more file in changeset.
Update PROXY handling by removing Optional processing
  1. … 1 more file in changeset.
Finally include feedback from Ruediger Pluem. Add slave "backoff" verified by Sander Hoentjen
* We can have expressions that become true if a regex pattern in the expression

does NOT match. In this case val is NULL and we should just set the value for

the environment variable like in the pattern case.

Change tactic for PROXY processing in Optional case
  1. … 1 more file in changeset.
* modules/metadata/mod_remoteip.c (register_hooks,

remoteip_hook_pre_connection): Reference the filter by handle rather

than name (avoiding tree lookup by name on use).

* modules/metadata/mod_remoteip.c: Fix GCC strict-aliasing warning

by moving deference of header array via a different pointer type

("type-punning") out of line.

Set all read buckets aside in case we need to restore all during optional header processing
* Silence compiler warning
Reinsert attribution to mod_remoteip.c for PROXY protocol
On the trunk:

* mod_remoteip: added cast to fix clang compiler error

Move attribution for mod_remoteip RemoteIPProxyProtocol from file to CHANGES
  1. … 1 more file in changeset.