Checkout Tools
  • last updated 2 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Fix spelling errors found by codespell. [skip ci]

  1. … 100 more files in changeset.
PR62989: DOCTYPE tags in server-generated HTML.

Submitted By: Andra Farkas <deepbluemistake>, Giovanni Bechis <giovanni>

  1. … 11 more files in changeset.
Avoid duplicated APLOGNO.

In this case, the difference is tiny, but it could ease diagniostic (and numbers are cheap anyway)

PR63305: fix graceful restart crashes in LDAP

The cache destruction was not protected by the lock used by other

cache callers.

Pull the static cleanup function into util_ldap.c so it's convenient to

use the existing locking.

Submitted By: Martin Fúsek <mfusek>

Commited By: covener

  1. … 1 more file in changeset.
* modules/ldap/util_ldap_cache_mgr.c (util_ald_create_caches): Destroy

rather than leak caches if all three cannot be allocated (Coverity

warning). Remove unnecessary pointer.

Axe some dead code.

See PR 60086.

fix bld break in r1831165

I had to disable -Werror in maintainer mode for this file in darwin :/

style fix for r1831165

mod_ldap: log and abort locking errors.

related to PR60296 investigation

RMM corruption is really nasty, so abort on locking failures.

  1. … 2 more files in changeset.
mod_ldap: fix format warnings.
10 years after r567503 , fix this properly.

The lock is created in post_config, so we can't copy it

around in a merge_server_config() callback.

  1. … 1 more file in changeset.
PR61891: looping over mostly full LDAP cache

*) mod_ldap: Fix a case where a full LDAP cache would continually fail to

purge old entries and log AH01323. PR61891.

Submitted By: Hendrik Harms <hendrik.harms>

Committed By: covener

  1. … 1 more file in changeset.
  1. … 7 more files in changeset.
Fix spelling in comments and text files.

No functional change.

PR 59990

  1. … 69 more files in changeset.
Fix some style issues on files that can easily be synch'ed with 2.4.x
  1. … 15 more files in changeset.
Silence a sparse warning about inconsistent indenting + some minor style issues
remove old static ldc->reason

--This line, and those bdelow, will be ignored--

M util_ldap.c

stuff unexpected LDAP errors into ldc->reason, not just in trace messages.

fix some enormously long lines introduced recently.

*) mod_ldap: In some case, LDAP_NO_SUCH_ATTRIBUTE could be returned instead of

an error during a compare operation. [Eric Covener]

+ accompanying trace.

Note: the if/else now matches (don't replace unknown compare errors with

LDAP_NO_SUCH_ATTRIBUTE) the logic just above when pulling comparisons

out of the cache.

  1. … 1 more file in changeset.
Fix directive name in error message + fix some style issue
LDAP connection pool did not release/close connections with

"LDAPConnectionPoolTTL 0". PR58037.

Submitted by: Ted Phelps <phelps>

committed by: covener

  1. … 1 more file in changeset.
Give a better hint.

Fix strange indent.
In 2.4.10, AuthLDAPBindDN might not be used for some LDAP searches, causing

LDAP authz failures if AuthLDAPBindDN was able to search through more of

LDAP than web users.

make LDAPConnectionPoolTTL more conservative, use r->request_time rather than

end-of-request time, and only update it after a round-trip with the LDAP

server rather than every time we check back into the pool.

  1. … 4 more files in changeset.
Don't use a hardcoded cn=* in case the subgroup has no CN.

Submitted By: David Hawes <dhawes>

Committed By: Eric Covener

  1. … 1 more file in changeset.
arrange previous fix.

Follow-up to r1526436: Fix compilation error
Fix for PR 54626.

  1. … 1 more file in changeset.
revert comments in r1521973, may be more misleadin then good.