Checkout Tools
  • last updated 6 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Cleanup effort in prep for GA push:

Trim trailing whitespace... no func change

  1. … 63 more files in changeset.
mod_include: Move the request_rec within mod_include to be

exposed within include_ctx_t.

  1. … 3 more files in changeset.
Move the accessenable variable into the private ssi_internal_ctx structure

instead of the public include_ctx_t structure.

  1. … 1 more file in changeset.
mod_include: Add an "if" directive syntax to test whether an URL

is accessible, and if so, conditionally display content. This

allows a webmaster to hide a link to a private page when the user

has no access to that page.

  1. … 3 more files in changeset.
update license header text
  1. … 316 more files in changeset.
Update the copyright year in all .c, .h and .xml files

  1. … 497 more files in changeset.
Doxygen fixup / cleanup

submited by: Neale Ranns neale

reviewed by: Ian Holsman

  1. … 105 more files in changeset.
Update copyright year to 2005 and standardize on current copyright owner line.

  1. … 522 more files in changeset.
general property cleanup

  1. … 712 more files in changeset.
fix name of The Apache Software Foundation

  1. … 361 more files in changeset.
apply Apache License, Version 2.0

  1. … 262 more files in changeset.
update license to 2004.

  1. … 281 more files in changeset.
drop superfluous argument from ap_ssi_parse_string.

The new API should now be stable.

  1. … 3 more files in changeset.
these should be const.

bump mod_include's external API. The API is now more simple and expected

to be better extensible without breaking binary compatibility, since an

opaque pointer to internal structures is part of the public context.

(We can easily add APi functions that operate on this internal struct).

I've tried to keep this change as small as possible - sorry for the big

diff though, but the commit should be atomic. mod_cgi and mod_cgid won't

compile until the next commit, anyway.

  1. … 1 more file in changeset.
major overhaul of mod_include's filter parser. Note that the new code

contains a thin wrapper to ensure binary compatibility. (needed for

2.0 backport).

This is a two-tiered commit for better diffs. This one inserts the new

code (old code #if'd out).

  1. … 2 more files in changeset.
finished that boring job:

update license to 2003.

Happy New Year! ;-))

  1. … 271 more files in changeset.

Need to grok optional fns.


Add an allocator-passing mechanism throughout the bucket brigades API.

From Apache's standpoint, the apr_bucket_alloc_t* used throughout a given

connection is stored in the conn_rec by the create_connection hook. That

means it's the MPM's job to optimize recycling of apr_bucket_alloc_t's --

the MPM must ensure that no two threads can ever use the same one at the

same time, for instance.

  1. … 43 more files in changeset.
Update our copyright for this year.

  1. … 260 more files in changeset.
Paren-protect macro arguments when used. (This will be needed later when

the bucket api gets changed.)

Submitted by: Brian Pane

make it work with flushes

make the false alarm not as generic


Obtained from:

Submitted by:

Reviewed by: Ian, Brian, Justin

  1. … 2 more files in changeset.
Eliminated various large (8KB) string buffers from the stack in

mod_include by adding support for a power-of-two pool-based allocator

in ap_ssi_parse_string(). (The default operation of this function

is backward-compatible, to support the other modules that call it.)

This change should help reduce memory usage for servers delivering

shtml pages.

  1. … 1 more file in changeset.

Ever tried to extract some value of QUERY_STRING from within SSI?

Now you can :) Provides $0..$9 results for any regex evaluation,

and strengthens the expr parser for regex expressions.

  1. … 4 more files in changeset.
allow mod_include to handle different start/end tags instead of the default

<!-- --> ones.


Obtained from:

Submitted by:

Reviewed by:

  1. … 3 more files in changeset.
Fix a file descriptor leak in mod_include. When we include a

file, we use a sub-request, but we didn't destroy the sub-request

immediately, instead we waited until the original request was

done. This patch closes the sub-request as soon as the data is

done being generated.

This passes all tests in the test suite.

Submitted by: Brian Pane <>

Reviewed by: Ryan Bloom and Cliff Woolley

  1. … 2 more files in changeset.
Remove the returned-length "w" parameter from apr_bucket_heap_create()

and apr_bucket_heap_make(). It was useless, since the length is invariant

from the length passed in and from the resulting bucket's b->length. This

takes care of a long-standing issue first brought up in February and

discussed on the dev@apr list. (Issue #2 from the "Bucket API Cleanup

Issues" thread.)


Reviewed by: Ryan Bloom (concept)

  1. … 6 more files in changeset.
This patch zero-fills just the integer and pointer fields in

the structure, plus the first byte of each of the string buffers.

This updated version of the patch doesn't allocate space for

the error_str and time_str buffers in the mod_include filter

context until/unless they're actually needed.


Submitted by: Brian Pane <>

Reviewed by: Ian Holsman

  1. … 1 more file in changeset.
Make mod_include check for BYTE_COUNT_THRESHOLD on a per-bucket basis

rather than on a per-character basis. A significant amount of time

was spent checking the limit. A better place to check for the threshold

is when we read the bucket in not as we read each character in the bucket.

If a bucket manages to be 200MB, it is not this code's problem as it

is a mere filter.

I ran this with the mod_include stuff in httpd-test and it looks good

from here.

Submitted by: Brian Pane <>

Reviewed by: Justin Erenkrantz, Ryan Bloom, Greg Stein, Cliff Woolley,

Paul Reder, etc, etc, etc...

  1. … 2 more files in changeset.

Moved split_and_pass_pretag_buckets back to being a

macro at Ryans's request. Removed the return from it

by setting and returning a return code instead. Updated

the code to check the return code from teh macro and

do the right thing.

  1. … 4 more files in changeset.