Checkout Tools
  • last updated 4 hours ago
Constraints: committers
Constraints: files
Constraints: dates

Changeset 1734817 is being indexed.

mod_include now sets DOCUMENT_ARGS.

* Like DOCUMENT_URI, this is for the SSI document, not for any

subrequest called for the include directive.

* Like QUERY_STRING, this is just r->args (or empty string if there are


The name of the variable is taken from the Zeus SSI implementation.

  1. … 2 more files in changeset.
Added many log numbers to log statements that

had none.

Those were not detected by the coccinelle script.

  1. … 34 more files in changeset.
Follow up to r1715880: revert more abusive ap_casecmpstr[n]() usages.
  1. … 7 more files in changeset.
Use new ap_casecmpstr[n]() functions where appropriate (not exhaustive).

  1. … 32 more files in changeset.
Revert r1715789: will re-commit without spurious functional changes.

  1. … 32 more files in changeset.
Use new ap_casecmpstr[n]() functions where appropriate (not exhaustive).

[Reverted by r1715869]

  1. … 32 more files in changeset.
Remove some useless 'return' statements.
  1. … 1 more file in changeset.
Fix some style issues on files that can easily be synch'ed with 2.4.x
  1. … 15 more files in changeset.
Be consistant with the code below which accepts lower or upper case.
Add missing APLOGNO.

Refactor some lines to keep APLOGNO on the same line as ap_log_error, when applicable.

Split lines longer than 80.

Improve alignment.

  1. … 14 more files in changeset.
Note that the function will be available in APR.

bug 54548 - use new expr parser with 'elif', like 'if'
mod_include: When an include file or virtual path fails, include the result

code that tells us why.

mod_include: When +Includes is not set and we disable mod_include, tell

the administrator where this happened.

Various code cleanup to avoid compiler, cppcheck, or clang warnings:

modules/debugging/mod_firehose.c: Make some internal functions static

(to do: logs_cleanup() is unused)

modules/filters/mod_charset_lite.c: Remove dead assignments

modules/filters/mod_include.c: likewise

modules/metadata/mod_usertrack.c: likewise

modules/proxy/mod_proxy_ftp.c: likewise

modules/ssl/ssl_engine_pphrase.c: likewise

modules/proxy/mod_proxy_balancer.c: likewise;

Remove NULL check that can never happen

modules/proxy/proxy_util.c: Axe NULL-check that can never happen and if it

would, it would just mask another bug

os/unix/unixd.c: likewise

modules/http/http_filters.c: Remove sub-condition that is always true

modules/lua/mod_lua.c: Add default cases to switch statements

modules/generators/mod_autoindex.c: Unsigned value can never be < 0

server/util_expr_eval.c: Fix compiler warnings with VC and on OS2

  1. … 12 more files in changeset.
Add lots of unique tags to error log messages

  1. … 172 more files in changeset.
mod_include: The SSIAccessEnable directive existed to ensure the addition

of the "-A" syntax would not break existing configurations in v2.2. Remove

the directive for v2.4, defaulting the behaviour to enabled.

  1. … 1 more file in changeset.
mod_include: Add support for application/x-www-form-urlencoded encoding

and decoding.

  1. … 6 more files in changeset.
regex related cleanups:

- use AP_MAX_REG_MATCH where appropriate

- in mod_proxy_ftp, compile the "ls -s1" regex only once instead of once per request

- add some coments

  1. … 2 more files in changeset.
Cleanup effort in prep for GA push:

Trim trailing whitespace... no func change

  1. … 118 more files in changeset.
Simplify some overly complicated code using apr_brigade_putstrs and apr_pstrcat

Submitted by: Christophe Jaillet <christophe jaillet wanadoo fr>,

Stefan Fritsch

  1. … 1 more file in changeset.
Add string valued expressions to ap_expr, do some API cleanup

- add possibility to have expressions that evaluate to a string and not to

a boolean value

- modify ap_expr_parse_cmd() interface to support this and make it more

convenient to use in general

- rename AP_EXPR_FLAGS_* to AP_EXPR_FLAG_* for consistency

  1. … 14 more files in changeset.
Simplify code with ap_str_tolower()

Submitted by: Christophe JAILLET <christophe jaillet wanadoo fr>

Fix cut'n'paste error

Use the new "ap_expr" expression parser.

The old parser can still be used by setting the new directive


  1. … 6 more files in changeset.
Fix config setting after r1128430 has changed some elements from int to char

properly merge directory configs in mod_include

  1. … 2 more files in changeset.
Fix various "variable 'x' set but not used" warnings.

  1. … 6 more files in changeset.
mod_include: Add the onerror attribute to the include element, allowing

an URL to be specified to include on error.

  1. … 3 more files in changeset.
Put the expression parser back into mod_include

This reverts r642559 and r642978