mod_heartmonitor.c

Checkout Tools
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Axe an old and apparently out-dated comment.

There is a typo in the comment.

HN_UPDATE_SEC has been renamed HM_UPDATE_SEC.

The TODO seems to have been taken into account in r759862.

Revert r1839247
Axe an old and apparently out-dated comment.

There is a typo in the comment.

HN_UPDATE_SEC has been renamed HM_UPDATE_SEC.

The TODO seems to have been taken into account in r759862.

Reverted in r1839248 and re-committed without un-expexted content in r1839249

mod_heartmonitor: No need to search twice for the same value + fix some style
Added many log numbers to log statements that

had none.

Those were not detected by the coccinelle script.

  1. … 34 more files in changeset.
core, modules: like r1657897 but for core and other modules than mod_proxy.

More uses of ap_map_http_request_error() and AP_FILTER_ERROR so that we never

return an HTTP error status from a handler if some filter generated a response

already.

That is, from a handler, either ap_get_brigade() (an input filter) returned

AP_FILTER_ERROR and we must forward it to ap_die(), or ap_pass_brigade() (an

output filter) failed with any status and we must return AP_FILTER_ERROR in

any case for ap_die() to determine whether a response is needed or not.

  1. … 15 more files in changeset.
Use apr_pstrmemdup instead of apr_pstrndup when this is safe.
  1. … 1 more file in changeset.
mod_lbmethod_heartbeat, mod_heartmonitor: Respect DefaultRuntimeDir/

DEFAULT_REL_RUNTIMEDIR for the heartbeat storage file.

  1. … 3 more files in changeset.
fix various property issues

  1. … 54 more files in changeset.
remove some dead code

found by clang statical analyzer

  1. … 1 more file in changeset.
Further clarify the naming of the entity that directly connects to us by

calling that entity a client instead of a peer.

  1. … 15 more files in changeset.
Various fixes for log message tags:

- Remove tags in ssl_log_ssl_error() and ssl_log_cert_error()

- Instead add tags to various ssl_log_xerror, ssl_log_cxerror

calls (ssl_log_rxerror is unused).

- likewise for modssl_proxy_info_log()

- Fix spelling of APLOG_NOERRNO in coccinelle script

- add support for ssl_log_*error and ap_log_cserror

- add some more tags missing due to APLOG_NOERRNO spelling error

- Remove tags from example modules (we don't want people to blindly copy

those)

  1. … 10 more files in changeset.
Remove usage of APLOG_NOERRNO. It has been a no-op since at least 2.0.x

  1. … 5 more files in changeset.
Change the provider names to match the module names:

mod_slotmem_shm: shared -> shm

mod_socache_memcache: mc -> memcache

  1. … 6 more files in changeset.
Add lots of unique tags to error log messages

  1. … 172 more files in changeset.
Remove more log message prefixes that are now redundant as the

the error log format includes the module name.

  1. … 9 more files in changeset.
Replace a missed version of remote_addr with the new peer_addr.

Cleanup effort in prep for GA push:

Trim trailing whitespace... no func change

  1. … 118 more files in changeset.
fix spelling error in a couple of log messages

Continue if the platform doesnt support file perms.

fix def'n of AP_SLOTMEM_PROVIDER_VERSION, use it

  1. … 5 more files in changeset.
Various code cleanup

PR: 51398

Submitted by: Christophe Jaillet <christophe jaillet wanadoo fr>

  1. … 8 more files in changeset.
fix some dead assignments found by the clang analyzer

  1. … 11 more files in changeset.
Use ap_state_query() to fix many modules that were not correctly initializing

if they were not active during server startup but got enabled later during a

graceful restart (in which case they need to do all work during a single

config run).

  1. … 12 more files in changeset.
Fix spelling of the handler.

Avoid unnecessariy initialisation before we test handler name.

Use the new APLOG_USE_MODULE/AP_DECLARE_MODULE macros everywhere to take

advantage of per-module loglevels

  1. … 169 more files in changeset.
Make the error message correspond to the code, which sets APR_SO_NONBLOCK.

Elaborate on low hanging XXX fruit
  1. … 5 more files in changeset.
change the callable functions in the mod_watchdog API

to optional hooks to avoid module ordering or other symbol

resolution issues; affected:

ap_watchdog_get_instance

ap_watchdog_register_callback

ap_watchdog_set_callback_interval

  1. … 2 more files in changeset.