mod_file_cache.c

Checkout Tools
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Synch style in comment with 2.4.x.

Style was different when r1496711 has been backported in r1772331

core, modules: like r1657897 but for core and other modules than mod_proxy.

More uses of ap_map_http_request_error() and AP_FILTER_ERROR so that we never

return an HTTP error status from a handler if some filter generated a response

already.

That is, from a handler, either ap_get_brigade() (an input filter) returned

AP_FILTER_ERROR and we must forward it to ap_die(), or ap_pass_brigade() (an

output filter) failed with any status and we must return AP_FILTER_ERROR in

any case for ap_die() to determine whether a response is needed or not.

  1. … 15 more files in changeset.
recognize the "defualt handler name" in r->handler, which is used when

no SetHandler/AddHandler and no matching mimetype during type_checker.

  1. … 1 more file in changeset.
Add lots of unique tags to error log messages

  1. … 172 more files in changeset.
Remove more log message prefixes that are now redundant as the

the error log format includes the module name.

  1. … 9 more files in changeset.
Use the new APLOG_USE_MODULE/AP_DECLARE_MODULE macros everywhere to take

advantage of per-module loglevels

  1. … 169 more files in changeset.
ap_meets_conditions() should not be called until all of

the known content metadata has been set, so that said metadata

can be included in the condition tests and in a 304 response.

  1. … 1 more file in changeset.
Remove all references to CORE_PRIVATE.

  1. … 67 more files in changeset.
update license header text
  1. … 316 more files in changeset.
* server/core.c (default_handler): Use apr_brigade_insert_file() to

append the file to the brigade.

* server/protocol.c (ap_send_fd),

modules/proxy/mod_proxy_http.c (spool_reqbody_cl),

modules/cache/mod_mem_cache.c (recall_body),

modules/cache/mod_disk_cache.c (recall_body),

modules/mappers/mod_negotiation.c (handle_map_file),

modules/generators/mod_asis.c (asis_handler),

modules/dav/fs/repos.c [DEBUG_GET_HANDLER] (dav_fs_deliver),

modules/arch/win32/mod_isapi.c (ServerSupportFunction): Likewise.

  1. … 9 more files in changeset.
Update the copyright year in all .c, .h and .xml files

  1. … 497 more files in changeset.
No functional change: remove "internal" tab spacing/formatting.

  1. … 32 more files in changeset.
No functional Change: Removing trailing whitespace. This also

means that "blank" lines consisting of just spaces or

tabs are now really blank lines

  1. … 180 more files in changeset.
No functional change: simple detabbing of indented code.

  1. … 72 more files in changeset.
Update copyright year to 2005 and standardize on current copyright owner line.

  1. … 522 more files in changeset.
general property cleanup

  1. … 712 more files in changeset.
fix name of The Apache Software Foundation

  1. … 361 more files in changeset.
apply Apache License, Version 2.0

  1. … 262 more files in changeset.
update license to 2004.

  1. … 281 more files in changeset.
switch to APR 1.0 API (which is still in flux)

because of the changes to the argument lists of apr_mmap_dup and apr_socket_create,

2.1-dev won't build with apr and apr-util's 0.9 branch anymore

  1. … 42 more files in changeset.
finished that boring job:

update license to 2003.

Happy New Year! ;-))

  1. … 271 more files in changeset.
dup the apr_mmap_t out of the request pool for sending down on the brigade

Fix a problem whereby multiple MMapFile directives would cause a segfault

on startup.

mod_file_cache keeps a hash table in the cmd->pool and puts an entry in

that hash table for each of its files and mmaps, all of which are opened

into cmd->pool. But it registered a cleanup on cmd->pool that would walk

the hash table and close each file and delete each mmap, even though by

the time that happened those things would have been done already anyway

by the files' and mmaps' own cleanups on cmd->pool. So it was deleting

mmaps that were already cleaned up and closing files that were already

cleaned up in all cases. This has never been valid... amazed it ever

worked. But apparently the true bogosity wasn't revealed until the new

mmap cleanup code went into APR.

PR: 16313

  1. … 1 more file in changeset.
update a comment

Well the wrappers work out well... nice to be able to put off committing

these API changes until the evening ;)

  1. … 4 more files in changeset.
stop using APLOG_NOERRNO in calls to ap_log_[pr]error()

  1. … 33 more files in changeset.

Moved the call to apr_mmap_dup outside the error branch so

that it would actually get called. This fixes a core dump

at init everytime you use the MMapFile directive. [Paul J. Reder]

  1. … 1 more file in changeset.
BUCKET FREELISTS

Add an allocator-passing mechanism throughout the bucket brigades API.

From Apache's standpoint, the apr_bucket_alloc_t* used throughout a given

connection is stored in the conn_rec by the create_connection hook. That

means it's the MPM's job to optimize recycling of apr_bucket_alloc_t's --

the MPM must ensure that no two threads can ever use the same one at the

same time, for instance.

  1. … 43 more files in changeset.

Eliminate potential ap_server_root_relative segfaults, with the input

of Jeff Trawick's style changes to the first patches. Doesn't include

the fixes to ssl [more complex], and we won't trap errors that involve

ap_serverroot, since we presume that was normalized on the way in.

Therefore, testing ap_server_root_relative(DEFAULT_FOO) cases

should never become necessary.

  1. … 17 more files in changeset.
make sure we set rc before referencing it

use a somewhat better warning message for a failure of

ap_server_relative_root()