Checkout Tools
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add missing pool tags to help debugging.
  1. … 41 more files in changeset.
Fix spelling errors found by codespell. [skip ci]

  1. … 100 more files in changeset.
Fix spelling in comments and text files.

No functional change.

PR 59990

  1. … 69 more files in changeset.
Added many log numbers to log statements that

had none.

Those were not detected by the coccinelle script.

  1. … 34 more files in changeset.
Added many log numbers to log statements that

had none.

Handled all files in modules/.

I used the coccinelle script provided by Stefan.

  1. … 35 more files in changeset.
Silent a sparse Warning.

cid->ecb->lpszLogData can not be NULL.

It is defined in mod_isapi.h as:

typedef struct EXTENSION_CONTROL_BLOCK {

...

char lpszLogData[80];

...

Fix some style issues on files that can easily be synch'ed with 2.4.x
  1. … 15 more files in changeset.
Add missing APLOGNO.

Refactor some lines to keep APLOGNO on the same line as ap_log_error, when applicable.

Split lines longer than 80.

Improve alignment.

  1. … 14 more files in changeset.
s/equivalant/equivalent/ in comments
  1. … 1 more file in changeset.
Code clean up (remove useless memory allocation)

Submitted by: Christophe JAILLET <christophe jaillet wanadoo fr>

PR: 52648

  1. … 4 more files in changeset.
definAtely

Add lots of unique tags to error log messages

  1. … 172 more files in changeset.
Fix apr_status_t being passed as loglevel

Remove more log message prefixes that are now redundant as the

the error log format includes the module name.

  1. … 9 more files in changeset.
Cleanup effort in prep for GA push:

Trim trailing whitespace... no func change

  1. … 118 more files in changeset.
Add more (trace) logging to the ap_scan_script_header*() functions

Add ap_scan_script_header*_ex() functions that take a module index for

logging.

Make mod_cgi, mod_cgid, mod_proxy_fcgi, mod_proxy_scgi, mod_isapi use the

new functions.

  1. … 9 more files in changeset.
Fix a few warnings about use of uninitialized values.

  1. … 1 more file in changeset.
Use the new APLOG_USE_MODULE/AP_DECLARE_MODULE macros everywhere to take

advantage of per-module loglevels

  1. … 169 more files in changeset.
Prevent future developers from being as easily confused; prefix the

registered callback function names with regfnXxx.

revert r918671; these four functions don't need to be

addressible except via the function pointers in the

EXTENSION_CONTROL_BLOCK

follow up to r918665:

These particular functions can't be static because they're

part of ISAPI, so use a different mechanism to quiet the gcc

warnings.

fix these warnings:

mod_isapi.c:488: warning: no previous prototype for ‘GetServerVariable’

mod_isapi.c:590: warning: no previous prototype for ‘ReadClient’

mod_isapi.c:807: warning: no previous prototype for ‘WriteClient’

mod_isapi.c:863: warning: no previous prototype for ‘ServerSupportFunction’

mod_isapi.c:1407: warning: no previous prototype for ‘isapi_handler’

SECURITY: CVE-2010-0425 (cve.mitre.org)

mod_isapi: Do not unload an isapi .dll module until the request

processing is completed, avoiding orphaned callback pointers.

Submitted by: Brett Gervasoni <brettg senseofsecurity.com>, trawick

Reviewed by: trawick, wrowe

  1. … 1 more file in changeset.

Correctly evaluate the HTTPS condition string.

PR: 40573

Submitted by: Matt Eaton <asf divinehawk.com>

Where any response is sent, return OK from the handler. Where there

is no response (but a status code) return the code. This patch adds

a great number of debugging emits for failed ap_pass_brigade calls,

to help diagnose failure cases, and disambiguates OK from APR_SUCCESS.

PR: 40470

Submitted by: wrowe, Matt Eaton <asf divinehawk.com>

Revert a regression introduced in the recent overhauls of mod_isapi.

PR 40470 points out that we no longer handle ate == headlen, where

there is a headers-only response from the isapi app to the server.

This patch restores the previous behavior of pending those headers

until some amount of body response is ready to be sent to the client.

update license header text
  1. … 316 more files in changeset.

Solve 416291, but in a more elegant manner, and with a little

more attention to clearing the subreq and determining that

an r->filename existed.

Stop appending a backslash if some trailing slash is present.

For cross platform isapi we aught to find out what to add from

apr, slash or backslash, but can't think of the trivial answer

at this hour.

PR: 15993

  1. … 1 more file in changeset.

mod_isapi: Handle "HTTP/1.1 200 OK" style status lines correctly, the

token parser worked while the resulting length was misinterpreted.

We were also off by one in apr_cpystrn which demands room for the

trailing null be counted.

PR: 29098

Submitted by: Brock Bland <bbland serena.com>

  1. … 1 more file in changeset.